fix: two browser-suite runs at once delete each other's image #547

Open
opened 2026-10-14 09:32:04 +02:00 by clawbot · 1 comment
Collaborator

script/test-e2e and script/test-e2e-firefox build their image with a fixed tag (autistmask-e2e-chrome, autistmask-e2e-firefox) and then run it by ID. When two clones run a suite at the same time, the second build moves the tag, and this host's Docker image store then deletes the first build's now-untagged image before or while it runs, so that suite exits 125 without running a test. A worker hit this three times on 2026-10-14. Nothing removes the image afterwards either, so every run leaves one behind.

Severity: major (it makes the browser suites fail spuriously whenever two gate runs overlap)

Definition of done

  • Each run of either script builds and runs an image under a tag of its own (for example, the fixed name suffixed with something unique to the run), and removes that image when it finishes, on success, failure or interrupt.
  • Two clones running the same suite at once each test their own build, and neither leaves an image behind.
  • README.md's End-to-End Tests section matches.

Model: opus-5-5

`script/test-e2e` and `script/test-e2e-firefox` build their image with a fixed tag (`autistmask-e2e-chrome`, `autistmask-e2e-firefox`) and then run it by ID. When two clones run a suite at the same time, the second build moves the tag, and this host's Docker image store then deletes the first build's now-untagged image before or while it runs, so that suite exits 125 without running a test. A worker hit this three times on 2026-10-14. Nothing removes the image afterwards either, so every run leaves one behind. Severity: major (it makes the browser suites fail spuriously whenever two gate runs overlap) ## Definition of done - [ ] Each run of either script builds and runs an image under a tag of its own (for example, the fixed name suffixed with something unique to the run), and removes that image when it finishes, on success, failure or interrupt. - [ ] Two clones running the same suite at once each test their own build, and neither leaves an image behind. - [ ] `README.md`'s End-to-End Tests section matches. Model: opus-5-5
clawbot self-assigned this 2026-10-14 09:32:04 +02:00
Author
Collaborator

Built in #550: each run of script/test-e2e and script/test-e2e-firefox now tags its image with the suite's name and twelve random hex digits, runs it by that tag, and removes it in the existing exit and interrupt cleanup. The End-to-End Tests section of README.md says so.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/AutistMask/pulls/550: each run of `script/test-e2e` and `script/test-e2e-firefox` now tags its image with the suite's name and twelve random hex digits, runs it by that tag, and removes it in the existing exit and interrupt cleanup. The End-to-End Tests section of `README.md` says so. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#547