In src/background/index.js, the port-disconnect handler for approvals keeps a transaction or signing approval pending with the comment "Keep pending — user can reopen the toolbar popup". That no longer describes the code: those approvals open in their own window (windows.create()), and the windows.onRemoved listener rejects them with EIP-1193 code 4001 when that window closes. Split out of #211, item 3.
Definition of done
The comment states why the approval stays pending on a port disconnect: its window's windows.onRemoved listener settles it.
No behaviour changes.
Model: opus-5-5
In `src/background/index.js`, the port-disconnect handler for approvals keeps a transaction or signing approval pending with the comment "Keep pending — user can reopen the toolbar popup". That no longer describes the code: those approvals open in their own window (`windows.create()`), and the `windows.onRemoved` listener rejects them with EIP-1193 code 4001 when that window closes. Split out of https://git.eeqj.de/sneak/AutistMask/issues/211, item 3.
## Definition of done
- [ ] The comment states why the approval stays pending on a port disconnect: its window's `windows.onRemoved` listener settles it.
- [ ] No behaviour changes.
Model: opus-5-5
clawbot
self-assigned this 2026-10-14 03:58:55 +02:00
#521 rewrites both comments in the approval port's disconnect handler, the inline one and the block above the listener, to say that the windows.onRemoved listener settles a transaction or signing approval when its window closes. Comments only; no code changed.
Model: opus-5-5
https://git.eeqj.de/sneak/AutistMask/pulls/521 rewrites both comments in the approval port's disconnect handler, the inline one and the block above the listener, to say that the `windows.onRemoved` listener settles a transaction or signing approval when its window closes. Comments only; no code changed.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In
src/background/index.js, the port-disconnect handler for approvals keeps a transaction or signing approval pending with the comment "Keep pending — user can reopen the toolbar popup". That no longer describes the code: those approvals open in their own window (windows.create()), and thewindows.onRemovedlistener rejects them with EIP-1193 code 4001 when that window closes. Split out of #211, item 3.Definition of done
windows.onRemovedlistener settles it.Model: opus-5-5
#521 rewrites both comments in the approval port's disconnect handler, the inline one and the block above the listener, to say that the
windows.onRemovedlistener settles a transaction or signing approval when its window closes. Comments only; no code changed.Model: opus-5-5