fix: switching the network in Settings does not tell open pages (no chainChanged) #500

New Issue

2026-10-07T23:37:32+02:00

clawbot commented

2026-10-07 23:37:32 +02:00

Switching the network in Settings (the settings-network change handler in src/popup/views/settings.js, which calls onChainSwitch()) saves the new network but sends no chainChanged to open tabs. Only the background's broadcastChainChanged() sends that event, and only a site's approved wallet_switchEthereumChain request reaches it.

A connected page therefore keeps the old chain id in window.ethereum.chainId until it asks eth_chainId again, and can build a transaction for the old chain, which the wallet then refuses when it prepares it.

Definition of done

Switching the network in Settings sends chainChanged with the new chain id to every open tab, as an approved site request does.
A test shows it.

Model: opus-5-5

Switching the network in Settings (the `settings-network` change handler in `src/popup/views/settings.js`, which calls `onChainSwitch()`) saves the new network but sends no `chainChanged` to open tabs. Only the background's `broadcastChainChanged()` sends that event, and only a site's approved `wallet_switchEthereumChain` request reaches it. A connected page therefore keeps the old chain id in `window.ethereum.chainId` until it asks `eth_chainId` again, and can build a transaction for the old chain, which the wallet then refuses when it prepares it. **Definition of done** - Switching the network in Settings sends `chainChanged` with the new chain id to every open tab, as an approved site request does. - A test shows it. Model: opus-5-5

clawbot referenced this issue

2026-10-08 02:13:15 +02:00

decision: a connected site can switch the wallet's network with no prompt #408

clawbot commented

2026-10-08 07:31:01 +02:00

Plan: the Settings switch sends chainChanged through the same background function an approved site request uses, so both paths tell open pages; a switch to the active network sends nothing. A jest test fails first on next.

Model: opus-5-5

Plan: the Settings switch sends `chainChanged` through the same background function an approved site request uses, so both paths tell open pages; a switch to the active network sends nothing. A jest test fails first on `next`. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-08 07:38:03 +02:00

fix: switching the network in Settings tells open pages (closes #500)

clawbot referenced a pull request that will close this issue

2026-10-08 08:20:27 +02:00

fix: switching the network in Settings tells open pages #503

clawbot commented

2026-10-08 08:20:34 +02:00

Built in #503: once Settings has saved a switch, the background sends chainChanged with the new chain id to every open tab through the same function an approved site request uses. Choosing the network already active sends nothing.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/AutistMask/pulls/503: once Settings has saved a switch, the background sends `chainChanged` with the new chain id to every open tab through the same function an approved site request uses. Choosing the network already active sends nothing. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-08 09:13:18 +02:00

fix: switching the network in Settings tells open pages (closes #500)

clawbot closed this issue

2026-10-08 09:13:19 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#500