sneak/AutistMask
1
0
Fork 0
Code Issues 67 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

chore: the testnet and debug banners leak the internal view id, e.g. "[TESTNET] (approve-tx)" #375

New Issue
Closed
opened 2026-08-23 21:06:42 +02:00 by clawbot · 1 comment
clawbot commented 2026-08-23 21:06:42 +02:00
Collaborator
Copy Link
Copy Source

Found by a deployability verification of next at 75a5fa9, observed in a real browser.

The testnet banner renders the internal view id to the user: [TESTNET] (approve-tx). Written deliberately at src/popup/views/helpers.js:122, and it applies to the DEBUG banner too.

Useful while developing, but it is internal vocabulary on a user-facing banner, and on the approval screen it sits directly above the text stating what is being authorized — where every other word has been carefully chosen this milestone.

Definition of done

  • The view id does not appear in a user-facing banner in a release build.
  • If it is wanted for development, it survives only in a debug build — note make build-debug already distinguishes the two and script/verify-build enforces which is which.
  • make check green.
Found by a deployability verification of `next` at `75a5fa9`, observed in a real browser. The testnet banner renders the internal view id to the user: `[TESTNET] (approve-tx)`. Written deliberately at `src/popup/views/helpers.js:122`, and it applies to the DEBUG banner too. Useful while developing, but it is internal vocabulary on a user-facing banner, and on the approval screen it sits directly above the text stating what is being authorized — where every other word has been carefully chosen this milestone. ## Definition of done - [ ] The view id does not appear in a user-facing banner in a release build. - [ ] If it is wanted for development, it survives only in a debug build — note `make build-debug` already distinguishes the two and `script/verify-build` enforces which is which. - [ ] `make check` green.
clawbot added this to the 1.0.0 milestone 2026-09-21 09:19:59 +02:00
clawbot commented 2026-09-21 09:30:35 +02:00
Author
Collaborator
Copy Link
Copy Source

The banner no longer shows the internal view id in a release build. The suffix that produced text like [TESTNET] (approve-tx) is now gated on the compile-time DEBUG constant rather than isDebug() (which is also true for a testnet or the runtime debug toggle), so it survives only in a debug build; a testnet or the runtime toggle still raises the banner, just without the view id.

PR: #389

Model: opus-4-8

The banner no longer shows the internal view id in a release build. The suffix that produced text like `[TESTNET] (approve-tx)` is now gated on the compile-time `DEBUG` constant rather than `isDebug()` (which is also true for a testnet or the runtime debug toggle), so it survives only in a debug build; a testnet or the runtime toggle still raises the banner, just without the view id. PR: https://git.eeqj.de/sneak/AutistMask/pulls/389 Model: opus-4-8
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone 1.0.0
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#375