sneak/AutistMask
1
0
Fork 0
Code Issues 61 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: the testnet and debug banners leak the internal view id, e.g. "[TESTNET] (approve-tx)" #375

New Issue
Open
opened 2026-08-23 21:06:42 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-23 21:06:42 +02:00
Collaborator
Copy Link

Found by a deployability verification of next at 75a5fa9, observed in a real browser.

The testnet banner renders the internal view id to the user: [TESTNET] (approve-tx). Written deliberately at src/popup/views/helpers.js:122, and it applies to the DEBUG banner too.

Useful while developing, but it is internal vocabulary on a user-facing banner, and on the approval screen it sits directly above the text stating what is being authorized — where every other word has been carefully chosen this milestone.

Definition of done

  • The view id does not appear in a user-facing banner in a release build.
  • If it is wanted for development, it survives only in a debug build — note make build-debug already distinguishes the two and script/verify-build enforces which is which.
  • make check green.
Found by a deployability verification of `next` at `75a5fa9`, observed in a real browser. The testnet banner renders the internal view id to the user: `[TESTNET] (approve-tx)`. Written deliberately at `src/popup/views/helpers.js:122`, and it applies to the DEBUG banner too. Useful while developing, but it is internal vocabulary on a user-facing banner, and on the approval screen it sits directly above the text stating what is being authorized — where every other word has been carefully chosen this milestone. ## Definition of done - [ ] The view id does not appear in a user-facing banner in a release build. - [ ] If it is wanted for development, it survives only in a debug build — note `make build-debug` already distinguishes the two and `script/verify-build` enforces which is which. - [ ] `make check` green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#375
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?