sneak/AutistMask
1
0
Fork 0
Code Issues 61 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: a popup already open when storage becomes unreadable keeps rendering the stale profile #373

New Issue
Open
opened 2026-08-23 21:06:25 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-23 21:06:25 +02:00
Collaborator
Copy Link

Found by a deployability verification of next at 75a5fa9, observed in a real browser.

If storage becomes unreadable while the popup is already open, the popup keeps rendering the stale profile — view-main with the old balance — instead of moving to the recovery screen added by #311. Reopening the popup recovers correctly.

Benign as it stands: nothing can be signed without a password, and the stale view is read-only. But it is the #311 family — the recovery screen exists precisely so the user is never left looking at something untrue about their wallet, and here they are, until they happen to reopen.

Not in milestone 1.0.0: it requires storage to fail underneath a live popup, and the failure is read-only and self-correcting on reopen.

Definition of done

  • A popup that discovers unreadable state while open moves to the recovery screen rather than continuing to render the last good profile.
  • It must not thrash: a transient read failure should not flap the user between views.
  • Test: corrupt storage under an open popup and assert the view changes. Fails against current head — state the mutation and observed result.
  • make check green.
Found by a deployability verification of `next` at `75a5fa9`, observed in a real browser. If storage becomes unreadable **while the popup is already open**, the popup keeps rendering the stale profile — `view-main` with the old balance — instead of moving to the recovery screen added by https://git.eeqj.de/sneak/AutistMask/issues/311. Reopening the popup recovers correctly. Benign as it stands: nothing can be signed without a password, and the stale view is read-only. But it is the https://git.eeqj.de/sneak/AutistMask/issues/311 family — the recovery screen exists precisely so the user is never left looking at something untrue about their wallet, and here they are, until they happen to reopen. Not in milestone 1.0.0: it requires storage to fail underneath a live popup, and the failure is read-only and self-correcting on reopen. ## Definition of done - [ ] A popup that discovers unreadable state while open moves to the recovery screen rather than continuing to render the last good profile. - [ ] It must not thrash: a transient read failure should not flap the user between views. - [ ] Test: corrupt storage under an open popup and assert the view changes. Fails against current head — state the mutation and observed result. - [ ] `make check` green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#373
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?