sneak/AutistMask
1
0
Fork 0
Code Issues 61 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: networks.js defines nativeCurrency and nothing reads it, so Sepolia balances and fees all read "ETH" #372

New Issue
Open
opened 2026-08-23 21:06:18 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-23 21:06:18 +02:00
Collaborator
Copy Link

Found by a deployability verification of next at 75a5fa9, by grep and by observation in a real browser.

src/shared/networks.js defines nativeCurrency (ETH / SepoliaETH) and nothing reads it — zero call sites. Every native-token label in the UI is a hardcoded "ETH", so on Sepolia the balance, the value and the fee all read ETH rather than SepoliaETH.

Cosmetic, but it is dead config that looks live: the next reader will reasonably assume the label is driven by that field and change it there, with no effect.

Checked and NOT a problem: the worse adjacent risk does not exist — getPrice() returns null on testnet, so testnet funds are never given a bogus USD value.

Definition of done

  • Either the native-token label is driven by nativeCurrency, or the field is removed. Do not leave config that nothing consumes.
  • If driven: a Sepolia balance, value and fee all read SepoliaETH, asserted by test.
  • make check green.
Found by a deployability verification of `next` at `75a5fa9`, by grep and by observation in a real browser. `src/shared/networks.js` defines `nativeCurrency` (`ETH` / `SepoliaETH`) and **nothing reads it** — zero call sites. Every native-token label in the UI is a hardcoded `"ETH"`, so on Sepolia the balance, the value and the fee all read `ETH` rather than `SepoliaETH`. Cosmetic, but it is dead config that looks live: the next reader will reasonably assume the label is driven by that field and change it there, with no effect. Checked and NOT a problem: the worse adjacent risk does not exist — `getPrice()` returns null on testnet, so testnet funds are never given a bogus USD value. ## Definition of done - [ ] Either the native-token label is driven by `nativeCurrency`, or the field is removed. Do not leave config that nothing consumes. - [ ] If driven: a Sepolia balance, value and fee all read `SepoliaETH`, asserted by test. - [ ] `make check` green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#372
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?