fix: neither manifest declares icons, so both browsers show a generic puzzle piece #371

New Issue

clawbot · 2026-08-23T21:06:07+02:00

clawbot commented

2026-08-23 21:06:07 +02:00

Found by a deployability verification of next at 75a5fa9 — built the real artifacts and loaded them in the pinned Chrome and Firefox harnesses.

Neither manifest/chrome.json nor manifest/firefox.json declares any icons. Both browsers therefore render a generic puzzle-piece in the toolbar.

In the milestone because it is the most visible remaining day-one rough edge: it is the first thing the owner sees, every time he opens the browser, and an unbranded puzzle piece is also how a user tells a real extension from a look-alike. Small — two manifests, the packager, and one test.

Definition of done

icons declared at 16/32/48/128 in both manifest/chrome.json and manifest/firefox.json.
Real PNGs at those sizes shipped INSIDE both archives — verify by unpacking the built artifacts, not by reading the build script. dist/styles.css is precedent for a file that exists at dist/ root but is shipped per-browser; make sure the icons do not repeat that trap.
script/package's reference-resolver covers them, so a missing icon fails the build rather than shipping a broken reference.
tests/manifest.test.js asserts the declaration.
make check and make build green, and both e2e suites still pass.

Found by a deployability verification of `next` at `75a5fa9` — built the real artifacts and loaded them in the pinned Chrome and Firefox harnesses. Neither `manifest/chrome.json` nor `manifest/firefox.json` declares any `icons`. Both browsers therefore render a generic puzzle-piece in the toolbar. In the milestone because it is the most visible remaining day-one rough edge: it is the first thing the owner sees, every time he opens the browser, and an unbranded puzzle piece is also how a user tells a real extension from a look-alike. Small — two manifests, the packager, and one test. ## Definition of done - [ ] `icons` declared at 16/32/48/128 in both `manifest/chrome.json` and `manifest/firefox.json`. - [ ] Real PNGs at those sizes shipped INSIDE both archives — verify by unpacking the built artifacts, not by reading the build script. `dist/styles.css` is precedent for a file that exists at `dist/` root but is shipped per-browser; make sure the icons do not repeat that trap. - [ ] `script/package`'s reference-resolver covers them, so a missing icon fails the build rather than shipping a broken reference. - [ ] `tests/manifest.test.js` asserts the declaration. - [ ] `make check` and `make build` green, and both e2e suites still pass.

clawbot added this to the 1.0.0 milestone 2026-08-23 21:06:07 +02:00

clawbot referenced this issue from a commit

2026-08-23 21:16:13 +02:00

fix: declare toolbar icons and ship real PNGs in both archives (closes #371)

clawbot referenced a pull request that will close this issue

2026-08-23 21:16:49 +02:00

fix: declare toolbar icons and ship real PNGs in both archives (closes #371) #376

clawbot referenced this issue

2026-08-23 21:25:18 +02:00

fix: declare toolbar icons and ship real PNGs in both archives (closes #371) #376

clawbot closed this issue

2026-08-23 21:26:15 +02:00