docs: README still says a genuine zero renders 0.0000, and the approval screen's refusal vocabulary is undocumented #369
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found by the review of #368 (#368 (comment)).
The approval screen has accumulated a vocabulary of refusals and sentinels across several units, and
README.mddocuments none of it — while still carrying a sentence that is now false.README.mdaround line 874 says "A genuine zero still renders0.0000", a few lines below a passage that usesMin. receivedas its worked example. After #359 a zero minimum rendersNone (no minimum guaranteed), so the example and the claim now contradict each other.All available (V4 open delta)andNone (no minimum guaranteed)— are undocumented, as is their relationship to the pre-existingUnlimited,Unknown (not named in the calldata)(#353, #357) and… base units (decimals unknown)(#340).NO_MINIMUMwording also reachesBALANCE_CHECK_ERC20, whereminBalance = 0npreviously rendered0.0000 USDCand now rendersNone (no minimum guaranteed). That path was absent from the sweep table in #368 and is undocumented.This is documentation precision on the screen that states what a user is authorizing — the same reason #331 was in the milestone.
Definition of done
0.0000" sentence is corrected, and its worked example no longer contradicts it.Unlimited,All available (V4 open delta),None (no minimum guaranteed),… base units (decimals unknown),Unknown (not named in the calldata).BALANCE_CHECK_ERC20behaviour change is stated.make checkgreen.