fix: a swap to a token absent from the bundled list shows no Token Out line at all #346

New Issue

clawbot · 2026-08-23T15:51:05+02:00

clawbot commented

2026-08-23 15:51:05 +02:00

Found while implementing #340. Not fixed there — same screen and same affected population, but an omitted line rather than a wrong number, so it fell outside that DoD.

In src/shared/uniswap.js the Token Out detail line is pushed only if (outSymbol). A swap whose output token is absent from the bundled list has no symbol, so the line is not rendered at all: the approval screen shows a Min. received figure with no statement of which token is being received.

The Token In line already handles this correctly by falling back to the address, so the fix has a precedent in the same file. Affects every token not in the bundled list, which includes every newly listed token.

Definition of done

A swap always names its output token. When no symbol is known, show the address, as the Token In line already does.
Test: a swap to a token absent from the bundled list renders a Token Out line naming the address. Fails against current head — state the mutation and observed result.
make check green.

Found while implementing https://git.eeqj.de/sneak/AutistMask/issues/340. Not fixed there — same screen and same affected population, but an omitted line rather than a wrong number, so it fell outside that DoD. In `src/shared/uniswap.js` the `Token Out` detail line is pushed only `if (outSymbol)`. A swap whose output token is absent from the bundled list has no symbol, so the line is not rendered at all: the approval screen shows a `Min. received` figure with **no statement of which token is being received**. The `Token In` line already handles this correctly by falling back to the address, so the fix has a precedent in the same file. Affects every token not in the bundled list, which includes every newly listed token. ## Definition of done - [ ] A swap always names its output token. When no symbol is known, show the address, as the `Token In` line already does. - [ ] Test: a swap to a token absent from the bundled list renders a `Token Out` line naming the address. Fails against current head — state the mutation and observed result. - [ ] `make check` green.

clawbot added this to the 1.0.0 milestone 2026-08-23 15:51:05 +02:00

clawbot referenced this issue

2026-08-23 16:02:49 +02:00

harden: resolve the swap approval screen's token scale, or refuse to format #345

clawbot referenced this issue from a commit

2026-08-23 16:24:53 +02:00

fix: always name a swap's output token, by address when no symbol is known (closes #346)

clawbot referenced a pull request that will close this issue

2026-08-23 16:25:10 +02:00

fix: always name a swap's output token, by address when no symbol is known (closes #346) #352

clawbot referenced this issue

2026-08-23 16:30:11 +02:00