sneak/AutistMask
1
0
Fork 0
Code Issues 50 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: Confirm Delete stays disabled after a successful wallet delete, so a second delete needs a popup reopen #335

New Issue
Open
opened 2026-08-20 14:42:14 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-20 14:42:14 +02:00
Collaborator
Copy Link

Found while implementing #312. Pre-existing on the password route, not introduced by that change.

btn-delete-wallet-confirm is disabled before the decrypt and never re-enabled on success. Delete one wallet, then open Delete Wallet for a second one in the same popup session: the "Confirm Delete" button is dead until the popup is closed and reopened. Nothing explains why, so the screen looks broken rather than busy.

Note the asymmetry this leaves behind: the "I have lost my password" route added by #312 re-enables its own button via the leave hook, so the two routes on the same screen now behave differently. That inconsistency is the strongest argument for fixing this — a reader comparing them will assume one of the two is wrong, and be unable to tell which.

Also relevant to the fix: src/popup/views/deleteWallet.js now has a shared finishDelete() used by both routes, so there is one obvious place for the button-state reset to live.

Definition of done

  • A second wallet can be deleted in the same popup session without reopening the popup.
  • Both routes reset their control state the same way, through the shared path rather than each handling it separately.
  • Test covering the password route's button state after a successful delete, alongside the existing coverage in tests/deleteWalletLostPassword.test.js.
  • The test fails against current head — state the mutation and observed result.
  • make check green.
Found while implementing https://git.eeqj.de/sneak/AutistMask/issues/312. Pre-existing on the password route, not introduced by that change. `btn-delete-wallet-confirm` is disabled before the decrypt and never re-enabled on success. Delete one wallet, then open Delete Wallet for a second one in the same popup session: the "Confirm Delete" button is dead until the popup is closed and reopened. Nothing explains why, so the screen looks broken rather than busy. Note the asymmetry this leaves behind: the "I have lost my password" route added by #312 re-enables its own button via the leave hook, so the two routes on the same screen now behave differently. That inconsistency is the strongest argument for fixing this — a reader comparing them will assume one of the two is wrong, and be unable to tell which. Also relevant to the fix: `src/popup/views/deleteWallet.js` now has a shared `finishDelete()` used by both routes, so there is one obvious place for the button-state reset to live. ## Definition of done - [ ] A second wallet can be deleted in the same popup session without reopening the popup. - [ ] Both routes reset their control state the same way, through the shared path rather than each handling it separately. - [ ] Test covering the password route's button state after a successful delete, alongside the existing coverage in `tests/deleteWalletLostPassword.test.js`. - [ ] The test fails against current head — state the mutation and observed result. - [ ] `make check` green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#335
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?