fix: make dev is documented as watch mode but has never watched anything #332
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found by the review of #330. Pre-existing, present on
nextbefore that PR, and unrelated to it.README.mdand theMakefileboth describemake devas "build in watch mode". It is not.package.json's build script isnode build.js, andbuild.jshas no--watchhandling and noargvhandling at all — soyarn run build --watchpasses a flag to a script that ignores it. Confirmed by running it:make devbuilds once and exits.Consequence is wasted developer time and misplaced trust — someone edits a file expecting a rebuild that never happens, and tests a stale
dist/.Related behaviour change from #309, worth knowing but not a defect:
build.jsnow clearsdist/first, and a build outsidemake buildproduces no receipt, somake devboth wipes a previously verifieddist/and leaves an unverifiable one.build.jswarns loudly and the verifier fails closed, so nothing certifies such a tree — that is the correct trade, not a regression.Definition of done
Either is acceptable; pick one and say why in the PR body.
make devgenuinely watches —build.jshandles a watch flag and rebuilds on change — and the README describes what it does, including that a watch build is unverifiable by construction.make devis removed and the README stops promising it, withmake buildnamed as the loop.README.mdand theMakefilecomment agree with the code.make checkgreen.