sneak/AutistMask
1
0
Fork 0
Code Issues 25 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

chore: eth_chainId and net_version are listed in PROXY_METHODS but intercepted earlier, so both entries are dead #326

New Issue
Closed
opened 2026-08-20 13:12:04 +02:00 by clawbot · 1 comment
clawbot commented 2026-08-20 13:12:04 +02:00
Collaborator
Copy Link
Copy Source

Found by the review of #319. Pre-existing, harmless today.

eth_chainId (src/background/index.js:626) and net_version (:642) appear in PROXY_METHODS while both are intercepted by an earlier branch in handleRpc and answered locally. The two list entries are unreachable.

No behaviour depends on them, which is why this is not in the 1.0.0 milestone. It is worth removing because the list reads as the authoritative statement of which methods are proxied to the RPC endpoint, and it currently names two that are not — so a reader auditing what leaves the extension gets a wrong answer from the obvious place to look.

Definition of done

  • Both entries removed, or the list restructured so a locally-answered method cannot appear in it.
  • Every other PROXY_METHODS entry checked against handleRpc's earlier branches for the same shadowing; report the result.
  • make check green.
Found by the review of https://git.eeqj.de/sneak/AutistMask/pulls/319. Pre-existing, harmless today. `eth_chainId` (`src/background/index.js:626`) and `net_version` (`:642`) appear in `PROXY_METHODS` while both are intercepted by an earlier branch in `handleRpc` and answered locally. The two list entries are unreachable. No behaviour depends on them, which is why this is not in the 1.0.0 milestone. It is worth removing because the list reads as the authoritative statement of which methods are proxied to the RPC endpoint, and it currently names two that are not — so a reader auditing what leaves the extension gets a wrong answer from the obvious place to look. ## Definition of done - [ ] Both entries removed, or the list restructured so a locally-answered method cannot appear in it. - [ ] Every other `PROXY_METHODS` entry checked against `handleRpc`'s earlier branches for the same shadowing; report the result. - [ ] `make check` green.
clawbot commented 2026-10-05 15:35:06 +02:00
Author
Collaborator
Copy Link
Copy Source

Built in #470: both entries are removed from PROXY_METHODS. None of the other 19 entries is answered before the proxy branch. A new test sends every listed method from a page and fails on any whose answer does not come from the RPC endpoint.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/AutistMask/pulls/470: both entries are removed from `PROXY_METHODS`. None of the other 19 entries is answered before the proxy branch. A new test sends every listed method from a page and fails on any whose answer does not come from the RPC endpoint. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#326