decision: what should the confirm screen quote as the network fee — estimate, reserve, or both? #231
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Your call, because it changes what every user is quoted on the wallet's most important screen and no issue asked for it.
How it came up
#154 made the balance check reserve what the node actually charges:
gasLimit * maxFeePerGas, where ethers derivesmaxFeePerGas = baseFee * 2 + tip. The screen previously displayedgasLimit * gasPrice, roughly half that on mainnet.That left the screen contradicting itself — displaying 0.000441 ETH while refusing a send whose arithmetic works against 0.000861. The implementer resolved it by changing the display to the reserve and relabelling it "Maximum network fee". Defensible, but it quotes mainnet users roughly double what they will typically pay, on every send, forever, with the "typically costs less" caveat living only in
README.md.Options
Recommendation
(a), which is why I shipped it rather than blocking. Type-2 refunds the difference between the reserve and the base fee actually paid, so the reserve is genuinely not what most users pay — quoting it alone trains people to expect a number they will rarely see. Showing both is honest about the two facts that matter: what it will probably cost, and what must be available.
Not blocking anything. If you prefer (b) or different wording, say so and I will change it in one small unit — this is a label and a format string, not a redesign.