sneak/AutistMask
1
0
Fork 0
Code Issues 42 Pull Requests 8 Actions Packages Projects Releases Wiki Activity

fix: loadState reads hasWallet from storage without reconciling it against wallets.length #195

New Issue
Closed
opened 2026-08-11 14:19:15 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-11 14:19:15 +02:00
Collaborator
Copy Link

loadState() in src/shared/state.js takes hasWallet straight from storage and never checks it against wallets.length.

Consequence: any profile already saved in an inconsistent state stays broken after the fix in #156 — the extension keeps believing a wallet exists, and only a subsequent add or delete repairs it. That is every user who deleted their last wallet on a build predating that fix. The fix there corrects the write path; this is the read path.

Found while implementing #156 and deliberately left out of its scope.

Implementation requirements

  • loadState() must derive hasWallet from wallets.length rather than trusting the persisted value, or reconcile and persist the correction on load.
  • Decide and state which: silently deriving is simplest, but if any code depends on hasWallet differing from wallets.length legitimately, that must be established first rather than assumed.
  • Do not widen this into a general state-migration framework.

Definition of done

  • A stored state with hasWallet: true and zero wallets loads as having no wallet, and the popup lands on the welcome screen.
  • A stored state with hasWallet: false and one or more wallets loads as having a wallet.
  • Unit tests cover both directions of the inconsistency, and are demonstrated failing against the current code.
  • TODO.md updated in the same commit.
  • make check passes.
`loadState()` in `src/shared/state.js` takes `hasWallet` straight from storage and never checks it against `wallets.length`. Consequence: any profile already saved in an inconsistent state stays broken after the fix in https://git.eeqj.de/sneak/AutistMask/issues/156 — the extension keeps believing a wallet exists, and only a subsequent add or delete repairs it. That is every user who deleted their last wallet on a build predating that fix. The fix there corrects the write path; this is the read path. Found while implementing https://git.eeqj.de/sneak/AutistMask/issues/156 and deliberately left out of its scope. ## Implementation requirements - `loadState()` must derive `hasWallet` from `wallets.length` rather than trusting the persisted value, or reconcile and persist the correction on load. - Decide and state which: silently deriving is simplest, but if any code depends on `hasWallet` differing from `wallets.length` legitimately, that must be established first rather than assumed. - Do not widen this into a general state-migration framework. ## Definition of done - [ ] A stored state with `hasWallet: true` and zero wallets loads as having no wallet, and the popup lands on the welcome screen. - [ ] A stored state with `hasWallet: false` and one or more wallets loads as having a wallet. - [ ] Unit tests cover both directions of the inconsistency, and are demonstrated failing against the current code. - [ ] `TODO.md` updated in the same commit. - [ ] `make check` passes.
clawbot added this to the 1.0.0 milestone 2026-08-11 14:19:15 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone 1.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#195
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?