sneak/AutistMask
1
0
Fork 0
Code Issues 67 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

feat: show estimated USD value for ETH in approve-tx view #141

Merged
sneak merged 2 commits from fix/issue-138-eth-value-estimate into main 2026-03-01 20:16:00 +01:00
Conversation 2 Commits 2 Files Changed 1
+8 -1
clawbot commented 2026-03-01 20:10:15 +01:00
Collaborator
Copy Link
Copy Source

The approve-tx view (dapp-initiated transaction approval) now shows the estimated USD value next to the ETH amount being transferred, using the existing getPrice/formatUsd from shared/prices.js.

This matches the behavior already present in the manual send confirmation view (confirmTx.js).

When ETH price is available, the value line shows e.g. 0.5000 ETH ($1,650.00). When price is unavailable, it falls back gracefully to just the ETH amount.

closes #138

The approve-tx view (dapp-initiated transaction approval) now shows the estimated USD value next to the ETH amount being transferred, using the existing `getPrice`/`formatUsd` from `shared/prices.js`. This matches the behavior already present in the manual send confirmation view (`confirmTx.js`). When ETH price is available, the value line shows e.g. `0.5000 ETH ($1,650.00)`. When price is unavailable, it falls back gracefully to just the ETH amount. closes #138
clawbot added 1 commit 2026-03-01 20:10:15 +01:00
feat: show estimated USD value for ETH in approve-tx view
check / check (push) Successful in 13s
Details
71c79e72a8 
Use getPrice/formatUsd from shared/prices to display the USD estimate
next to the ETH amount in the dapp transaction approval view, matching
the behavior already present in the manual send confirmation view.

closes #138
clawbot added the needs-review label 2026-03-01 20:10:25 +01:00
clawbot added needs-checks and removed needs-review labels 2026-03-01 20:12:04 +01:00
clawbot commented 2026-03-01 20:12:04 +01:00
Author
Collaborator
Copy Link
Copy Source

Review (self-authored PR — cannot formally approve):

LGTM. The diff correctly imports getPrice/formatUsd from shared/prices.js and applies the same USD display pattern used in confirmTx.js (valueWithUsd). Docker build passes (make check + make build). Clean, minimal 8-line change.

Moving to needs-checks.

**Review (self-authored PR — cannot formally approve):** LGTM. The diff correctly imports `getPrice`/`formatUsd` from `shared/prices.js` and applies the same USD display pattern used in `confirmTx.js` (`valueWithUsd`). Docker build passes (`make check` + `make build`). Clean, minimal 8-line change. Moving to `needs-checks`.
sneak commented 2026-03-01 20:15:14 +01:00
Owner
Copy Link
Copy Source

@clawbot

could you please compare approve-tx and confirm-tx and make an issue identifying any inconsistencies?

then review the rest of the codebase to find inconsistencies like this and file issues for them.

@clawbot could you please compare approve-tx and confirm-tx and make an issue identifying any inconsistencies? then review the rest of the codebase to find inconsistencies like this and file issues for them.
sneak added 1 commit 2026-03-01 20:15:21 +01:00
Merge branch 'main' into fix/issue-138-eth-value-estimate
check / check (push) Successful in 12s
Details
8ec2126f07
sneak merged commit 6b40fa8836 into main 2026-03-01 20:16:00 +01:00
sneak deleted branch fix/issue-138-eth-value-estimate 2026-03-01 20:16:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels needs-checks
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#141