Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
30b089a3f5 |
@@ -1396,7 +1396,9 @@ lists, the send-screen token selector, the address total and the remove-address
|
|||||||
warning (`isBelowOneMillionth()` in `src/shared/amountDisplay.js`). The Send and
|
warning (`isBelowOneMillionth()` in `src/shared/amountDisplay.js`). The Send and
|
||||||
confirmation screens show it when its token is the one being sent. Tracked
|
confirmation screens show it when its token is the one being sent. Tracked
|
||||||
tokens with a zero balance are listed as well while "Show tracked tokens with
|
tokens with a zero balance are listed as well while "Show tracked tokens with
|
||||||
zero balance" is on.
|
zero balance" is on; a token just added on AddToken or SettingsAddToken whose
|
||||||
|
balance no refresh has fetched yet is listed there as `quantity unknown` (see
|
||||||
|
AddToken).
|
||||||
|
|
||||||
#### Stored state and its version
|
#### Stored state and its version
|
||||||
|
|
||||||
@@ -1567,6 +1569,13 @@ such as an edit typed into Settings and not yet saved. Home is the one screen
|
|||||||
"Back" always re-renders, so the wallet list reflects anything that changed
|
"Back" always re-renders, so the wallet list reflects anything that changed
|
||||||
while the user was away from it.
|
while the user was away from it.
|
||||||
|
|
||||||
|
The popup refreshes balances every ten seconds while it is open
|
||||||
|
(`doRefreshAndRender()` in `src/popup/index.js`). Each refresh that returns
|
||||||
|
draws the wallet list again and, when AddressDetail or AddressToken is up, that
|
||||||
|
screen's USD total and balance lines; its transaction list is left alone. No
|
||||||
|
other screen is drawn again by a refresh, DeleteAddress and its balance lines
|
||||||
|
included.
|
||||||
|
|
||||||
A network switch leaves every screen on the page showing the previous network.
|
A network switch leaves every screen on the page showing the previous network.
|
||||||
The user makes it in Settings, or approves a site's request and the background
|
The user makes it in Settings, or approves a site's request and the background
|
||||||
saves it. Any other popup open meanwhile takes the switch from the stored
|
saves it. Any other popup open meanwhile takes the switch from the stored
|
||||||
@@ -2078,7 +2087,14 @@ view would leave a wallet one click from deletion.
|
|||||||
- "Add" button
|
- "Add" button
|
||||||
- **Transitions**:
|
- **Transitions**:
|
||||||
- "Add" (valid contract) → tracks the token, pops the stack, and re-renders
|
- "Add" (valid contract) → tracks the token, pops the stack, and re-renders
|
||||||
**AddressDetail**
|
**AddressDetail**. The token's balance is not known until a balance
|
||||||
|
refresh that started with it tracked has fetched every address's token
|
||||||
|
balances; until then its balance line reads `quantity unknown`, never
|
||||||
|
`0.0000`, unless the explorer had already listed a holding of it. That
|
||||||
|
holds after the popup is closed and opened again, as the tokens still
|
||||||
|
waiting for a fetch are stored with the profile. A refresh that returns
|
||||||
|
draws AddressDetail's balances again (see Navigation), so the fetched
|
||||||
|
balance shows without the screen being reopened
|
||||||
- "Add" with a token already tracked, a scam-listed address, or a failed
|
- "Add" with a token already tracked, a scam-listed address, or a failed
|
||||||
contract lookup → flash message, no screen change
|
contract lookup → flash message, no screen change
|
||||||
- "Add", then a network switch in Settings before the contract lookup
|
- "Add", then a network switch in Settings before the contract lookup
|
||||||
@@ -2355,7 +2371,9 @@ view would leave a wallet one click from deletion.
|
|||||||
add path
|
add path
|
||||||
- **Transitions**:
|
- **Transitions**:
|
||||||
- Any of the add paths shown, on success → adds the token and shows an
|
- Any of the add paths shown, on success → adds the token and shows an
|
||||||
"Added SYMBOL" flash message (no screen change)
|
"Added SYMBOL" flash message (no screen change). Until its balance is
|
||||||
|
fetched, its balance line reads `quantity unknown`, as after "Add" on
|
||||||
|
AddToken
|
||||||
- A duplicate, a scam-listed address, or a failed contract lookup → flash
|
- A duplicate, a scam-listed address, or a failed contract lookup → flash
|
||||||
message, no screen change
|
message, no screen change
|
||||||
- "Add" by contract address, then a network switch in Settings before the
|
- "Add" by contract address, then a network switch in Settings before the
|
||||||
|
|||||||
@@ -82,12 +82,26 @@ let refreshTimer = null;
|
|||||||
// (https://git.eeqj.de/sneak/AutistMask/issues/577). A dropped refresh is not
|
// (https://git.eeqj.de/sneak/AutistMask/issues/577). A dropped refresh is not
|
||||||
// recorded as done. Results are copied by address, so an address added or
|
// recorded as done. Results are copied by address, so an address added or
|
||||||
// removed meanwhile is left as it is.
|
// removed meanwhile is left as it is.
|
||||||
|
//
|
||||||
|
// Once the save is done, the wallet list is drawn again, and so are the
|
||||||
|
// balances on AddressDetail or AddressToken when that is the screen up. No
|
||||||
|
// other screen is drawn again, DeleteAddress and its balance lines included.
|
||||||
async function doRefreshAndRender() {
|
async function doRefreshAndRender() {
|
||||||
if (refreshInFlight) return;
|
if (refreshInFlight) return;
|
||||||
refreshInFlight = true;
|
refreshInFlight = true;
|
||||||
try {
|
try {
|
||||||
const networkId = state.networkId;
|
const networkId = state.networkId;
|
||||||
|
// The tracked tokens this refresh asks the explorer about. A token
|
||||||
|
// added on AddToken after this point is not among them, so this
|
||||||
|
// refresh does not count as having fetched it.
|
||||||
|
const tokens = state.trackedTokens.map((t) => t.address.toLowerCase());
|
||||||
const wallets = structuredClone(state.wallets);
|
const wallets = structuredClone(state.wallets);
|
||||||
|
// Taken off the copy, so that an address whose token balances the
|
||||||
|
// explorer did not return comes back without any and keeps its
|
||||||
|
// stored ones.
|
||||||
|
for (const wallet of wallets) {
|
||||||
|
for (const addr of wallet.addresses) delete addr.tokenBalances;
|
||||||
|
}
|
||||||
await Promise.all([
|
await Promise.all([
|
||||||
refreshPrices(),
|
refreshPrices(),
|
||||||
refreshBalances(
|
refreshBalances(
|
||||||
@@ -100,9 +114,13 @@ async function doRefreshAndRender() {
|
|||||||
),
|
),
|
||||||
]);
|
]);
|
||||||
const refreshed = new Map();
|
const refreshed = new Map();
|
||||||
|
let allTokenBalancesFetched = true;
|
||||||
for (const wallet of wallets) {
|
for (const wallet of wallets) {
|
||||||
for (const addr of wallet.addresses) {
|
for (const addr of wallet.addresses) {
|
||||||
refreshed.set(addr.address, addr);
|
refreshed.set(addr.address, addr);
|
||||||
|
if (addr.tokenBalances === undefined) {
|
||||||
|
allTokenBalancesFetched = false;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
await saveState((stored) => {
|
await saveState((stored) => {
|
||||||
@@ -117,10 +135,19 @@ async function doRefreshAndRender() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
// Each token this refresh asked about is now fetched for every
|
||||||
|
// address.
|
||||||
|
if (allTokenBalancesFetched) {
|
||||||
|
state.tokensNotFetched = state.tokensNotFetched.filter(
|
||||||
|
(token) => !tokens.includes(token),
|
||||||
|
);
|
||||||
|
}
|
||||||
state.lastBalanceRefresh = Date.now();
|
state.lastBalanceRefresh = Date.now();
|
||||||
return true;
|
return true;
|
||||||
});
|
});
|
||||||
renderWalletList();
|
renderWalletList();
|
||||||
|
if (state.currentView === "address") addressDetail.renderBalances();
|
||||||
|
if (state.currentView === "address-token") addressToken.renderBalance();
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
// Every call site fires this and walks away — the boot below, the ten
|
// Every call site fires this and walks away — the boot below, the ten
|
||||||
// second interval, and eight views through ctx — so it must never
|
// second interval, and eight views through ctx — so it must never
|
||||||
|
|||||||
@@ -1,4 +1,11 @@
|
|||||||
const { $, showView, showFlash, escapeHtml, goBack } = require("./helpers");
|
const {
|
||||||
|
$,
|
||||||
|
showView,
|
||||||
|
showFlash,
|
||||||
|
escapeHtml,
|
||||||
|
goBack,
|
||||||
|
trackToken,
|
||||||
|
} = require("./helpers");
|
||||||
const { getTopTokens } = require("../../shared/tokenList");
|
const { getTopTokens } = require("../../shared/tokenList");
|
||||||
const { state, saveState, currentNetwork } = require("../../shared/state");
|
const { state, saveState, currentNetwork } = require("../../shared/state");
|
||||||
const { lookupTokenInfo } = require("../../shared/balances");
|
const { lookupTokenInfo } = require("../../shared/balances");
|
||||||
@@ -72,7 +79,7 @@ function init(ctx) {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
log.infof("Adding token", info.symbol, contractAddr);
|
log.infof("Adding token", info.symbol, contractAddr);
|
||||||
state.trackedTokens.push({
|
trackToken({
|
||||||
address: contractAddr,
|
address: contractAddr,
|
||||||
symbol: info.symbol,
|
symbol: info.symbol,
|
||||||
decimals: info.decimals,
|
decimals: info.decimals,
|
||||||
|
|||||||
@@ -65,11 +65,25 @@ function show() {
|
|||||||
});
|
});
|
||||||
$("address-line").dataset.full = addr.address;
|
$("address-line").dataset.full = addr.address;
|
||||||
attachCopyHandlers($("address-line"));
|
attachCopyHandlers($("address-line"));
|
||||||
const usdTotal = formatAddressTotal(getAddressValue(addr));
|
|
||||||
$("address-usd-total").innerHTML = escapeHtml(usdTotal) || " ";
|
|
||||||
const ensEl = $("address-ens");
|
const ensEl = $("address-ens");
|
||||||
// ENS is now shown inside renderAddressHtml, hide the separate element
|
// ENS is now shown inside renderAddressHtml, hide the separate element
|
||||||
ensEl.classList.add("hidden");
|
ensEl.classList.add("hidden");
|
||||||
|
renderBalances();
|
||||||
|
renderSendTokenSelect(addr);
|
||||||
|
$("tx-list").innerHTML =
|
||||||
|
'<div class="text-muted text-xs py-1">Loading...</div>';
|
||||||
|
showView("address");
|
||||||
|
loadTransactions(addr.address);
|
||||||
|
}
|
||||||
|
|
||||||
|
// The USD total and the balance list. Drawn again by each balance refresh
|
||||||
|
// that returns while this screen is up (doRefreshAndRender() in
|
||||||
|
// src/popup/index.js), which leaves the rest of the screen as it is.
|
||||||
|
function renderBalances() {
|
||||||
|
const addr =
|
||||||
|
state.wallets[state.selectedWallet].addresses[state.selectedAddress];
|
||||||
|
const usdTotal = formatAddressTotal(getAddressValue(addr));
|
||||||
|
$("address-usd-total").innerHTML = escapeHtml(usdTotal) || " ";
|
||||||
$("address-balances").innerHTML = balanceLinesForAddress(
|
$("address-balances").innerHTML = balanceLinesForAddress(
|
||||||
addr,
|
addr,
|
||||||
state.trackedTokens,
|
state.trackedTokens,
|
||||||
@@ -83,11 +97,6 @@ function show() {
|
|||||||
ctx.showAddressToken();
|
ctx.showAddressToken();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
renderSendTokenSelect(addr);
|
|
||||||
$("tx-list").innerHTML =
|
|
||||||
'<div class="text-muted text-xs py-1">Loading...</div>';
|
|
||||||
showView("address");
|
|
||||||
loadTransactions(addr.address);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
let loadedTxs = [];
|
let loadedTxs = [];
|
||||||
@@ -280,4 +289,4 @@ function init(_ctx) {
|
|||||||
exportPrivkey.init();
|
exportPrivkey.init();
|
||||||
}
|
}
|
||||||
|
|
||||||
module.exports = { init, show };
|
module.exports = { init, show, renderBalances };
|
||||||
|
|||||||
@@ -48,37 +48,18 @@ function show() {
|
|||||||
const addr = wallet.addresses[state.selectedAddress];
|
const addr = wallet.addresses[state.selectedAddress];
|
||||||
const ai = state.selectedAddress;
|
const ai = state.selectedAddress;
|
||||||
const tokenId = state.selectedToken;
|
const tokenId = state.selectedToken;
|
||||||
|
|
||||||
// Determine token symbol and balance
|
|
||||||
let symbol, amount, price;
|
|
||||||
const knownToken = TOKEN_BY_ADDRESS.get(tokenId.toLowerCase());
|
const knownToken = TOKEN_BY_ADDRESS.get(tokenId.toLowerCase());
|
||||||
if (tokenId === "ETH") {
|
currentSymbol =
|
||||||
symbol = nativeCurrency();
|
tokenId === "ETH"
|
||||||
amount = parseFloat(addr.balance || "0");
|
? nativeCurrency()
|
||||||
price = getPrice("ETH");
|
: resolveSymbol(tokenId, addr.tokenBalances, state.trackedTokens);
|
||||||
} else {
|
|
||||||
const tb = (addr.tokenBalances || []).find(
|
|
||||||
(t) => t.address.toLowerCase() === tokenId.toLowerCase(),
|
|
||||||
);
|
|
||||||
symbol = resolveSymbol(
|
|
||||||
tokenId,
|
|
||||||
addr.tokenBalances,
|
|
||||||
state.trackedTokens,
|
|
||||||
);
|
|
||||||
// null when the scale is unknown: no quantity to show, and none to
|
|
||||||
// price. balanceLine() states that rather than printing 0.0000.
|
|
||||||
amount = tb ? unknownableAmount(tb.balance) : 0;
|
|
||||||
price = getPrice(symbol);
|
|
||||||
}
|
|
||||||
|
|
||||||
currentSymbol = symbol;
|
|
||||||
|
|
||||||
$("address-token-title").textContent =
|
$("address-token-title").textContent =
|
||||||
wallet.name +
|
wallet.name +
|
||||||
" \u2014 Address " +
|
" \u2014 Address " +
|
||||||
(ai + 1) +
|
(ai + 1) +
|
||||||
" \u2014 " +
|
" \u2014 " +
|
||||||
displaySymbol(symbol);
|
displaySymbol(currentSymbol);
|
||||||
|
|
||||||
// Blockie
|
// Blockie
|
||||||
const blockieEl = $("address-token-jazzicon");
|
const blockieEl = $("address-token-jazzicon");
|
||||||
@@ -100,13 +81,7 @@ function show() {
|
|||||||
$("address-token-line").dataset.full = addr.address;
|
$("address-token-line").dataset.full = addr.address;
|
||||||
attachCopyHandlers($("address-token-line"));
|
attachCopyHandlers($("address-token-line"));
|
||||||
|
|
||||||
// USD total for this token only
|
renderBalance();
|
||||||
const usdVal = price && amount !== null ? amount * price : null;
|
|
||||||
const usdStr = formatUsd(usdVal);
|
|
||||||
$("address-token-usd-total").innerHTML = escapeHtml(usdStr) || " ";
|
|
||||||
|
|
||||||
// Single token balance line (no tokenId — not clickable here)
|
|
||||||
$("address-token-balance").innerHTML = balanceLine(symbol, amount, price);
|
|
||||||
|
|
||||||
// Token contract details (ERC-20 only)
|
// Token contract details (ERC-20 only)
|
||||||
const contractInfo = $("address-token-contract-info");
|
const contractInfo = $("address-token-contract-info");
|
||||||
@@ -168,6 +143,44 @@ function show() {
|
|||||||
loadTransactions(addr.address, tokenId);
|
loadTransactions(addr.address, tokenId);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// The USD total and the balance line of the selected token. Drawn again by
|
||||||
|
// each balance refresh that returns while this screen is up
|
||||||
|
// (doRefreshAndRender() in src/popup/index.js), which leaves the rest of the
|
||||||
|
// screen as it is.
|
||||||
|
function renderBalance() {
|
||||||
|
const addr =
|
||||||
|
state.wallets[state.selectedWallet].addresses[state.selectedAddress];
|
||||||
|
const tokenId = state.selectedToken;
|
||||||
|
let amount, price;
|
||||||
|
if (tokenId === "ETH") {
|
||||||
|
amount = parseFloat(addr.balance || "0");
|
||||||
|
price = getPrice("ETH");
|
||||||
|
} else {
|
||||||
|
const id = tokenId.toLowerCase();
|
||||||
|
const tb = (addr.tokenBalances || []).find(
|
||||||
|
(t) => t.address.toLowerCase() === id,
|
||||||
|
);
|
||||||
|
// null when the scale is unknown, or when no refresh has fetched a
|
||||||
|
// token just added: no quantity to show, and none to price.
|
||||||
|
// balanceLine() states that rather than printing 0.0000.
|
||||||
|
if (tb) amount = unknownableAmount(tb.balance);
|
||||||
|
else amount = state.tokensNotFetched.includes(id) ? null : 0;
|
||||||
|
price = getPrice(currentSymbol);
|
||||||
|
}
|
||||||
|
|
||||||
|
// USD total for this token only
|
||||||
|
const usdVal = price && amount !== null ? amount * price : null;
|
||||||
|
const usdStr = formatUsd(usdVal);
|
||||||
|
$("address-token-usd-total").innerHTML = escapeHtml(usdStr) || " ";
|
||||||
|
|
||||||
|
// Single token balance line (no tokenId — not clickable here)
|
||||||
|
$("address-token-balance").innerHTML = balanceLine(
|
||||||
|
currentSymbol,
|
||||||
|
amount,
|
||||||
|
price,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
async function loadTransactions(address, tokenId) {
|
async function loadTransactions(address, tokenId) {
|
||||||
try {
|
try {
|
||||||
const rawTxs = await fetchRecentTransactions(
|
const rawTxs = await fetchRecentTransactions(
|
||||||
@@ -343,4 +356,4 @@ function init(_ctx) {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
module.exports = { init, show };
|
module.exports = { init, show, renderBalance };
|
||||||
|
|||||||
@@ -380,6 +380,18 @@ function balanceLine(symbol, amount, price, tokenId) {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Tracks `token` on the active network, as every add path on AddToken and
|
||||||
|
// SettingsAddToken does, and lists it in `state.tokensNotFetched`: no refresh
|
||||||
|
// has fetched its balance yet. An address with no balance row for it has no
|
||||||
|
// known balance of it, so its line says the quantity is unknown rather than
|
||||||
|
// 0.0000. doRefreshAndRender() in src/popup/index.js takes it off once a
|
||||||
|
// refresh that started with it tracked has fetched every address's token
|
||||||
|
// balances (https://git.eeqj.de/sneak/AutistMask/issues/516).
|
||||||
|
function trackToken(token) {
|
||||||
|
state.trackedTokens.push(token);
|
||||||
|
state.tokensNotFetched.push(token.address.toLowerCase());
|
||||||
|
}
|
||||||
|
|
||||||
function balanceLinesForAddress(addr, trackedTokens, showZero) {
|
function balanceLinesForAddress(addr, trackedTokens, showZero) {
|
||||||
let html = balanceLine(
|
let html = balanceLine(
|
||||||
nativeCurrency(),
|
nativeCurrency(),
|
||||||
@@ -409,12 +421,13 @@ function balanceLinesForAddress(addr, trackedTokens, showZero) {
|
|||||||
}
|
}
|
||||||
if (showZero && trackedTokens) {
|
if (showZero && trackedTokens) {
|
||||||
for (const t of trackedTokens) {
|
for (const t of trackedTokens) {
|
||||||
if (seen.has(t.address.toLowerCase())) continue;
|
const id = t.address.toLowerCase();
|
||||||
|
if (seen.has(id)) continue;
|
||||||
html += balanceLine(
|
html += balanceLine(
|
||||||
t.symbol,
|
t.symbol,
|
||||||
0,
|
state.tokensNotFetched.includes(id) ? null : 0,
|
||||||
getPrice(t.symbol),
|
getPrice(t.symbol),
|
||||||
t.address.toLowerCase(),
|
id,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -786,6 +799,7 @@ module.exports = {
|
|||||||
flashCopyFeedback,
|
flashCopyFeedback,
|
||||||
balanceLine,
|
balanceLine,
|
||||||
balanceLinesForAddress,
|
balanceLinesForAddress,
|
||||||
|
trackToken,
|
||||||
addressHoldsFunds,
|
addressHoldsFunds,
|
||||||
keyMaterialName,
|
keyMaterialName,
|
||||||
unknownableAmount,
|
unknownableAmount,
|
||||||
|
|||||||
@@ -1,4 +1,11 @@
|
|||||||
const { $, showView, showFlash, escapeHtml, goBack } = require("./helpers");
|
const {
|
||||||
|
$,
|
||||||
|
showView,
|
||||||
|
showFlash,
|
||||||
|
escapeHtml,
|
||||||
|
goBack,
|
||||||
|
trackToken,
|
||||||
|
} = require("./helpers");
|
||||||
const { getTopTokens } = require("../../shared/tokenList");
|
const { getTopTokens } = require("../../shared/tokenList");
|
||||||
const { state, saveState, currentNetwork } = require("../../shared/state");
|
const { state, saveState, currentNetwork } = require("../../shared/state");
|
||||||
const { lookupTokenInfo } = require("../../shared/balances");
|
const { lookupTokenInfo } = require("../../shared/balances");
|
||||||
@@ -43,7 +50,7 @@ function renderTop10() {
|
|||||||
decimals: parseInt(btn.dataset.decimals, 10),
|
decimals: parseInt(btn.dataset.decimals, 10),
|
||||||
name: btn.dataset.name || btn.dataset.symbol,
|
name: btn.dataset.name || btn.dataset.symbol,
|
||||||
};
|
};
|
||||||
state.trackedTokens.push(token);
|
trackToken(token);
|
||||||
await saveState();
|
await saveState();
|
||||||
showFlash("Added " + token.symbol);
|
showFlash("Added " + token.symbol);
|
||||||
renderTop10();
|
renderTop10();
|
||||||
@@ -110,7 +117,7 @@ function init(_ctx) {
|
|||||||
decimals: parseInt(opt.dataset.decimals, 10),
|
decimals: parseInt(opt.dataset.decimals, 10),
|
||||||
name: opt.dataset.name || opt.dataset.symbol,
|
name: opt.dataset.name || opt.dataset.symbol,
|
||||||
};
|
};
|
||||||
state.trackedTokens.push(token);
|
trackToken(token);
|
||||||
await saveState();
|
await saveState();
|
||||||
showFlash("Added " + token.symbol);
|
showFlash("Added " + token.symbol);
|
||||||
renderTop10();
|
renderTop10();
|
||||||
@@ -156,7 +163,7 @@ function init(_ctx) {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
log.infof("Adding token", info.symbol, addr);
|
log.infof("Adding token", info.symbol, addr);
|
||||||
state.trackedTokens.push({
|
trackToken({
|
||||||
address: addr,
|
address: addr,
|
||||||
symbol: info.symbol,
|
symbol: info.symbol,
|
||||||
decimals: info.decimals,
|
decimals: info.decimals,
|
||||||
|
|||||||
@@ -28,6 +28,13 @@ const DEFAULT_STATE = {
|
|||||||
// others are restored from when the active network changes. See
|
// others are restored from when the active network changes. See
|
||||||
// applyChainSwitchFields().
|
// applyChainSwitchFields().
|
||||||
networkTrackedTokens: {},
|
networkTrackedTokens: {},
|
||||||
|
// Contract addresses, lowercased, of the tokens the user added that no
|
||||||
|
// balance refresh has fetched yet. trackToken() in
|
||||||
|
// src/popup/views/helpers.js adds one, and doRefreshAndRender() in
|
||||||
|
// src/popup/index.js takes it off. Stored, so a token added just before
|
||||||
|
// the popup closed still reads `quantity unknown` when it opens again
|
||||||
|
// (https://git.eeqj.de/sneak/AutistMask/issues/516).
|
||||||
|
tokensNotFetched: [],
|
||||||
networkId: "mainnet",
|
networkId: "mainnet",
|
||||||
rpcUrl: DEFAULT_RPC_URL,
|
rpcUrl: DEFAULT_RPC_URL,
|
||||||
blockscoutUrl: DEFAULT_BLOCKSCOUT_URL,
|
blockscoutUrl: DEFAULT_BLOCKSCOUT_URL,
|
||||||
@@ -412,6 +419,8 @@ function normalizePersisted(saved) {
|
|||||||
// so a stored string walks through the `|| []` and a stored number walks
|
// so a stored string walks through the `|| []` and a stored number walks
|
||||||
// through an Array.isArray().
|
// through an Array.isArray().
|
||||||
out.fraudContracts = textList(saved.fraudContracts);
|
out.fraudContracts = textList(saved.fraudContracts);
|
||||||
|
// Contract addresses too, read with `includes()` and `filter()`.
|
||||||
|
out.tokensNotFetched = textList(saved.tokensNotFetched);
|
||||||
out.tokenHolderCache = structuredClone(saved.tokenHolderCache || {});
|
out.tokenHolderCache = structuredClone(saved.tokenHolderCache || {});
|
||||||
out.theme = saved.theme || "system";
|
out.theme = saved.theme || "system";
|
||||||
out.debugMode = saved.debugMode !== undefined ? saved.debugMode : false;
|
out.debugMode = saved.debugMode !== undefined ? saved.debugMode : false;
|
||||||
|
|||||||
@@ -0,0 +1,273 @@
|
|||||||
|
// After "Add" on AddToken, AddressDetail lists the new token, and its line reads
|
||||||
|
// `quantity unknown`, not 0.0000, until a balance refresh that asked the
|
||||||
|
// explorer about the token has returned for every address, the popup closing
|
||||||
|
// and opening again meanwhile included; so does a token added on
|
||||||
|
// SettingsAddToken, wherever it is listed. A refresh that returns draws the
|
||||||
|
// balances on AddressDetail or AddressToken again, so the fetched balance shows
|
||||||
|
// without the screen being reopened
|
||||||
|
// (https://git.eeqj.de/sneak/AutistMask/issues/516). Driven through the real
|
||||||
|
// popup over a stored profile on Ethereum Mainnet, with "Show tracked tokens
|
||||||
|
// with zero balance" on, as it is by default.
|
||||||
|
|
||||||
|
const {
|
||||||
|
bootPopup,
|
||||||
|
cleanupPopup,
|
||||||
|
unversionedValidProfile,
|
||||||
|
} = require("./support/popupBoot");
|
||||||
|
|
||||||
|
// Tracked by nobody until a test adds it.
|
||||||
|
const NEW_TOKEN = "0xBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB";
|
||||||
|
|
||||||
|
// The explorer's row for a holding of a million NEW_TOKEN, in the shape
|
||||||
|
// fetchTokenBalances() stores it.
|
||||||
|
const MILLION = {
|
||||||
|
address: NEW_TOKEN,
|
||||||
|
name: "New Token",
|
||||||
|
symbol: "NEW",
|
||||||
|
decimals: 18,
|
||||||
|
balance: "1000000.0",
|
||||||
|
holders: 3,
|
||||||
|
};
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
cleanupPopup();
|
||||||
|
});
|
||||||
|
|
||||||
|
// The popup reopened onto AddressDetail for the one address.
|
||||||
|
function bootOnAddress() {
|
||||||
|
return bootPopup(
|
||||||
|
unversionedValidProfile({
|
||||||
|
currentView: "address",
|
||||||
|
selectedWallet: 0,
|
||||||
|
selectedAddress: 0,
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Holds the next balance refresh open. The returned function lets it finish
|
||||||
|
// with the address's ETH balance at 2 and `tokenBalances` as the explorer's
|
||||||
|
// rows for it, or with no token balances at all when given null: an explorer
|
||||||
|
// that did not answer, which the real refreshBalances() leaves unwritten.
|
||||||
|
function holdNextRefresh(page) {
|
||||||
|
const { refreshBalances } = require("../src/shared/balances");
|
||||||
|
let release;
|
||||||
|
refreshBalances.mockImplementationOnce(async (wallets) => {
|
||||||
|
const tokenBalances = await new Promise((resolve) => {
|
||||||
|
release = resolve;
|
||||||
|
});
|
||||||
|
wallets[0].addresses[0].balance = "2.0";
|
||||||
|
if (tokenBalances !== null) {
|
||||||
|
wallets[0].addresses[0].tokenBalances = tokenBalances;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
return async (tokenBalances) => {
|
||||||
|
release(tokenBalances);
|
||||||
|
await page.settle();
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// "+ Token", NEW_TOKEN typed in, and "Add", with the contract lookup
|
||||||
|
// answering at once.
|
||||||
|
async function addNewToken(page) {
|
||||||
|
const { lookupTokenInfo } = require("../src/shared/balances");
|
||||||
|
lookupTokenInfo.mockResolvedValueOnce({
|
||||||
|
symbol: "NEW",
|
||||||
|
decimals: 18,
|
||||||
|
name: "New Token",
|
||||||
|
});
|
||||||
|
await page.click("btn-add-token");
|
||||||
|
page.node("add-token-address").value = NEW_TOKEN;
|
||||||
|
await page.click("btn-add-token-confirm");
|
||||||
|
}
|
||||||
|
|
||||||
|
// NEW_TOKEN's row in the balance list in element `id`, AddressDetail's unless
|
||||||
|
// another is named, as markup.
|
||||||
|
function newTokenRow(page, id = "address-balances") {
|
||||||
|
return page
|
||||||
|
.node(id)
|
||||||
|
.innerHTML.split("<div ")
|
||||||
|
.find((row) =>
|
||||||
|
row.includes('data-token="' + NEW_TOKEN.toLowerCase() + '"'),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
// AddressDetail for the one address opened from Home, as its `[info]` button
|
||||||
|
// does.
|
||||||
|
async function openAddress(page) {
|
||||||
|
const { state } = require("../src/shared/state");
|
||||||
|
state.selectedWallet = 0;
|
||||||
|
state.selectedAddress = 0;
|
||||||
|
require("../src/popup/views/helpers").pushCurrentView();
|
||||||
|
require("../src/popup/views/addressDetail").show();
|
||||||
|
await page.settle();
|
||||||
|
}
|
||||||
|
|
||||||
|
// AddressToken for `token` opened from AddressDetail, as tapping the token's
|
||||||
|
// row there does.
|
||||||
|
async function openToken(page, token) {
|
||||||
|
const { state } = require("../src/shared/state");
|
||||||
|
state.selectedToken = token;
|
||||||
|
require("../src/popup/views/helpers").pushCurrentView();
|
||||||
|
require("../src/popup/views/addressToken").show();
|
||||||
|
await page.settle();
|
||||||
|
}
|
||||||
|
|
||||||
|
test("until the refresh Add started returns, the new token's line reads quantity unknown", async () => {
|
||||||
|
const page = await bootOnAddress();
|
||||||
|
expect(page.pageErrors).toEqual([]);
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
|
||||||
|
await addNewToken(page);
|
||||||
|
|
||||||
|
expect(page.visibleViews()).toEqual(["address"]);
|
||||||
|
const row = newTokenRow(page);
|
||||||
|
expect(row).toContain("quantity unknown");
|
||||||
|
expect(row).not.toContain("0.0000");
|
||||||
|
await finish([MILLION]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("once that refresh returns, AddressDetail shows the fetched balance without being reopened", async () => {
|
||||||
|
const page = await bootOnAddress();
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
await addNewToken(page);
|
||||||
|
// Stands for the transactions on the screen, which only show() replaces.
|
||||||
|
page.node("tx-list").innerHTML = "transactions on the screen";
|
||||||
|
|
||||||
|
await finish([MILLION]);
|
||||||
|
|
||||||
|
expect(page.visibleViews()).toEqual(["address"]);
|
||||||
|
expect(newTokenRow(page)).toContain("1000000.0000");
|
||||||
|
// Only the balances are drawn again, not the transaction list.
|
||||||
|
expect(page.node("tx-list").innerHTML).toBe("transactions on the screen");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a refresh already running when the token is added does not count as fetching it", async () => {
|
||||||
|
const page = await bootOnAddress();
|
||||||
|
const finishRunning = holdNextRefresh(page);
|
||||||
|
const ticking = page.tick();
|
||||||
|
await page.settle();
|
||||||
|
|
||||||
|
await addNewToken(page);
|
||||||
|
await finishRunning([]);
|
||||||
|
await ticking;
|
||||||
|
|
||||||
|
expect(newTokenRow(page)).toContain("quantity unknown");
|
||||||
|
|
||||||
|
// The next one asks the explorer about the token, which lists no holding
|
||||||
|
// of it: a fetched zero.
|
||||||
|
const finishNext = holdNextRefresh(page);
|
||||||
|
const next = page.tick();
|
||||||
|
await page.settle();
|
||||||
|
await finishNext([]);
|
||||||
|
await next;
|
||||||
|
|
||||||
|
expect(newTokenRow(page)).toContain("0.0000");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("closed and opened again before any refresh has fetched it, the new token's line still reads quantity unknown", async () => {
|
||||||
|
const closed = await bootOnAddress();
|
||||||
|
holdNextRefresh(closed);
|
||||||
|
await addNewToken(closed);
|
||||||
|
cleanupPopup();
|
||||||
|
|
||||||
|
// The refresh this boot starts gets no token balances back: the boot's
|
||||||
|
// stub of refreshBalances() writes none.
|
||||||
|
const page = await bootPopup(undefined, { storage: closed.storage });
|
||||||
|
expect(page.visibleViews()).toEqual(["address"]);
|
||||||
|
const row = newTokenRow(page);
|
||||||
|
expect(row).toContain("quantity unknown");
|
||||||
|
expect(row).not.toContain("0.0000");
|
||||||
|
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
const ticking = page.tick();
|
||||||
|
await page.settle();
|
||||||
|
await finish([MILLION]);
|
||||||
|
await ticking;
|
||||||
|
|
||||||
|
expect(newTokenRow(page)).toContain("1000000.0000");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a refresh in which the explorer did not answer leaves the new token's line quantity unknown", async () => {
|
||||||
|
const page = await bootOnAddress();
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
await addNewToken(page);
|
||||||
|
|
||||||
|
await finish(null);
|
||||||
|
|
||||||
|
// Drawn again: the ETH balance it fetched is shown.
|
||||||
|
expect(page.node("address-balances").innerHTML).toContain("2.0000");
|
||||||
|
expect(newTokenRow(page)).toContain("quantity unknown");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("AddressToken for the new token reads quantity unknown until the refresh returns, then the fetched balance", async () => {
|
||||||
|
const page = await bootOnAddress();
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
await addNewToken(page);
|
||||||
|
|
||||||
|
await openToken(page, NEW_TOKEN.toLowerCase());
|
||||||
|
|
||||||
|
expect(page.visibleViews()).toEqual(["address-token"]);
|
||||||
|
const before = page.node("address-token-balance").innerHTML;
|
||||||
|
expect(before).toContain("quantity unknown");
|
||||||
|
expect(before).not.toContain("0.0000");
|
||||||
|
|
||||||
|
await finish([MILLION]);
|
||||||
|
|
||||||
|
expect(page.node("address-token-balance").innerHTML).toContain(
|
||||||
|
"1000000.0000",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a token added by contract address on SettingsAddToken reads quantity unknown until the refresh returns", async () => {
|
||||||
|
const page = await bootPopup(unversionedValidProfile());
|
||||||
|
expect(page.visibleViews()).toEqual(["main"]);
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
const { lookupTokenInfo } = require("../src/shared/balances");
|
||||||
|
lookupTokenInfo.mockResolvedValueOnce({
|
||||||
|
symbol: "NEW",
|
||||||
|
decimals: 18,
|
||||||
|
name: "New Token",
|
||||||
|
});
|
||||||
|
|
||||||
|
await page.click("btn-settings");
|
||||||
|
await page.click("btn-settings-add-token");
|
||||||
|
page.node("settings-addtoken-address").value = NEW_TOKEN;
|
||||||
|
await page.click("btn-settings-addtoken-manual");
|
||||||
|
await page.click("btn-settings-addtoken-back");
|
||||||
|
await page.click("btn-settings-back");
|
||||||
|
expect(page.visibleViews()).toEqual(["main"]);
|
||||||
|
const onHome = newTokenRow(page, "wallet-list");
|
||||||
|
expect(onHome).toContain("quantity unknown");
|
||||||
|
expect(onHome).not.toContain("0.0000");
|
||||||
|
|
||||||
|
await openAddress(page);
|
||||||
|
const onAddress = newTokenRow(page);
|
||||||
|
expect(onAddress).toContain("quantity unknown");
|
||||||
|
expect(onAddress).not.toContain("0.0000");
|
||||||
|
|
||||||
|
await finish([MILLION]);
|
||||||
|
|
||||||
|
expect(newTokenRow(page)).toContain("1000000.0000");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a refresh that returns while AddressToken is up draws its balance again", async () => {
|
||||||
|
const page = await bootPopup(
|
||||||
|
unversionedValidProfile({
|
||||||
|
currentView: "address-token",
|
||||||
|
viewStack: ["main", "address"],
|
||||||
|
selectedWallet: 0,
|
||||||
|
selectedAddress: 0,
|
||||||
|
selectedToken: "ETH",
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(page.visibleViews()).toEqual(["address-token"]);
|
||||||
|
expect(page.node("address-token-balance").innerHTML).toContain("1.5000");
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
const ticking = page.tick();
|
||||||
|
await page.settle();
|
||||||
|
|
||||||
|
await finish(null);
|
||||||
|
await ticking;
|
||||||
|
|
||||||
|
expect(page.node("address-token-balance").innerHTML).toContain("2.0000");
|
||||||
|
});
|
||||||
+2
-1
@@ -651,7 +651,8 @@ test("a token added by its contract address is listed on the address screen (#15
|
|||||||
await visible(env.page, "#view-address");
|
await visible(env.page, "#view-address");
|
||||||
|
|
||||||
// No wait: the confirm renders the balance list before it shows the
|
// No wait: the confirm renders the balance list before it shows the
|
||||||
// screen, and nothing renders the list again while the screen is up.
|
// screen. The refresh it starts draws the list again, with the row still
|
||||||
|
// in it.
|
||||||
const row = env.page.locator(
|
const row = env.page.locator(
|
||||||
'#address-balances [data-token="' + STUB_TOKEN.address + '"]',
|
'#address-balances [data-token="' + STUB_TOKEN.address + '"]',
|
||||||
{ hasText: STUB_TOKEN.symbol },
|
{ hasText: STUB_TOKEN.symbol },
|
||||||
|
|||||||
@@ -88,6 +88,7 @@ describe.each([
|
|||||||
showFlash: (msg) => flashes.push(msg),
|
showFlash: (msg) => flashes.push(msg),
|
||||||
escapeHtml: (s) => s,
|
escapeHtml: (s) => s,
|
||||||
goBack: () => {},
|
goBack: () => {},
|
||||||
|
trackToken: () => {},
|
||||||
}));
|
}));
|
||||||
|
|
||||||
require("../src/popup/views/" + view).init({
|
require("../src/popup/views/" + view).init({
|
||||||
|
|||||||
@@ -248,6 +248,13 @@ const CONTRACT = [
|
|||||||
floorOnly: [[42], [null], [{}], [[TOKEN_ADDRESS]]],
|
floorOnly: [[42], [null], [{}], [[TOKEN_ADDRESS]]],
|
||||||
holds: (v) => everyEntry(v, isText),
|
holds: (v) => everyEntry(v, isText),
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
field: "tokensNotFetched",
|
||||||
|
kind: KIND.ENTRIES,
|
||||||
|
hostile: [42, "notalist", { a: 1 }],
|
||||||
|
floorOnly: [[42], [null], [{}], [[TOKEN_ADDRESS]]],
|
||||||
|
holds: (v) => everyEntry(v, isText),
|
||||||
|
},
|
||||||
{
|
{
|
||||||
field: "viewStack",
|
field: "viewStack",
|
||||||
kind: KIND.ENTRIES,
|
kind: KIND.ENTRIES,
|
||||||
|
|||||||
Reference in New Issue
Block a user