Compare commits
1 Commits
issue-280-
...
993afbc5da
| Author | SHA1 | Date | |
|---|---|---|---|
| 993afbc5da |
7
Makefile
7
Makefile
@@ -1,4 +1,4 @@
|
|||||||
.PHONY: bootstrap setup install test test-e2e test-e2e-firefox lint fmt fmt-check check docker hooks build build-debug verify-build clean dev
|
.PHONY: bootstrap setup install test test-e2e lint fmt fmt-check check docker hooks build build-debug verify-build clean dev
|
||||||
|
|
||||||
# Standard targets are thin shims; the implementations live in script/
|
# Standard targets are thin shims; the implementations live in script/
|
||||||
# per the scripts-to-rule-them-all pattern (see the Entrypoints section
|
# per the scripts-to-rule-them-all pattern (see the Entrypoints section
|
||||||
@@ -16,13 +16,10 @@ install:
|
|||||||
test:
|
test:
|
||||||
@script/test
|
@script/test
|
||||||
|
|
||||||
# Browser end-to-end suites. Both require docker; neither is part of check.
|
# Browser end-to-end suite. Requires docker; not part of check.
|
||||||
test-e2e:
|
test-e2e:
|
||||||
@script/test-e2e
|
@script/test-e2e
|
||||||
|
|
||||||
test-e2e-firefox:
|
|
||||||
@script/test-e2e-firefox
|
|
||||||
|
|
||||||
lint:
|
lint:
|
||||||
@script/lint
|
@script/lint
|
||||||
|
|
||||||
|
|||||||
131
README.md
131
README.md
@@ -83,10 +83,7 @@ provide:
|
|||||||
git pre-commit hook
|
git pre-commit hook
|
||||||
- `script/projectname` — print the project name (used for the Docker image tag)
|
- `script/projectname` — print the project name (used for the Docker image tag)
|
||||||
- `script/test` — run the test suite (jest)
|
- `script/test` — run the test suite (jest)
|
||||||
- `script/test-e2e` — run the Chrome browser end-to-end suite (docker required;
|
- `script/test-e2e` — run the browser end-to-end suite (docker required; see
|
||||||
see [End-to-End Tests](#end-to-end-tests))
|
|
||||||
- `script/test-e2e-firefox` — run the Firefox browser end-to-end suite (docker
|
|
||||||
required; builds its own pinned image, see
|
|
||||||
[End-to-End Tests](#end-to-end-tests))
|
[End-to-End Tests](#end-to-end-tests))
|
||||||
- `script/lint` — run the linter
|
- `script/lint` — run the linter
|
||||||
- `script/fmt` — format all files (writes)
|
- `script/fmt` — format all files (writes)
|
||||||
@@ -126,14 +123,6 @@ The Makefile shims to those. It also carries a few targets that have no
|
|||||||
|
|
||||||
## End-to-End Tests
|
## End-to-End Tests
|
||||||
|
|
||||||
There are two suites, one per browser, and they share no code. Chrome runs on
|
|
||||||
Playwright; Firefox has its own WebDriver client, because Playwright cannot
|
|
||||||
observe errors on a Firefox extension page at all — see
|
|
||||||
[Firefox](#firefox-make-test-e2e-firefox) below. Both require docker, and both
|
|
||||||
are outside `make check`.
|
|
||||||
|
|
||||||
### Chrome (`make test-e2e`)
|
|
||||||
|
|
||||||
`make test-e2e` builds `dist/chrome/` and drives the **real popup in a real
|
`make test-e2e` builds `dist/chrome/` and drives the **real popup in a real
|
||||||
Chrome**, loaded as an unpacked MV3 extension inside a pinned
|
Chrome**, loaded as an unpacked MV3 extension inside a pinned
|
||||||
`mcr.microsoft.com/playwright` container (pinned by digest in `script/test-e2e`;
|
`mcr.microsoft.com/playwright` container (pinned by digest in `script/test-e2e`;
|
||||||
@@ -169,34 +158,6 @@ reserve while sitting on the same side of the estimate, so swapping the two in
|
|||||||
what [#154](https://git.eeqj.de/sneak/AutistMask/issues/154) was, and it was
|
what [#154](https://git.eeqj.de/sneak/AutistMask/issues/154) was, and it was
|
||||||
previously correct by reading only.
|
previously correct by reading only.
|
||||||
|
|
||||||
It also covers the **dApp approval round trips** — the one place where the
|
|
||||||
content script, the inpage provider, the background worker and the approval
|
|
||||||
popup all have to work together. A local test page is served by the route
|
|
||||||
handler on a reserved-TLD origin, gets `window.ethereum` from the shipped
|
|
||||||
`MAIN`-world content script like any other page, and drives
|
|
||||||
`eth_requestAccounts`, `personal_sign`, `eth_signTypedData_v4` and
|
|
||||||
`eth_sendTransaction` through the real prompts. Every signature is recovered in
|
|
||||||
the runner and compared against the active address, the transaction assertions
|
|
||||||
run against the raw signed transaction captured at `eth_sendRawTransaction`
|
|
||||||
rather than against anything the extension reported, rejecting each prompt is
|
|
||||||
required to return a rejection to the page rather than hang or resolve, and the
|
|
||||||
password is required to be absent from every message the approval window sends
|
|
||||||
to the background — with the message that would carry it required to be present,
|
|
||||||
so that check cannot pass by observing nothing. That last one is the standing
|
|
||||||
floor under [#157](https://git.eeqj.de/sneak/AutistMask/issues/157).
|
|
||||||
|
|
||||||
Three limits of that coverage, none of them papered over. The RPC is stubbed
|
|
||||||
throughout, so this is **not** a real dApp against a real network with real
|
|
||||||
funds; that remains a human pass before 1.0.0. The site-connection prompt is
|
|
||||||
raised through `chrome.action.openPopup()`, and headless Chromium's
|
|
||||||
browser-action popup is not a page Playwright can see or click, so that one
|
|
||||||
prompt is driven at the URL the extension itself puts on the action — the same
|
|
||||||
page and the same approval id, but whether a real toolbar click shows it is not
|
|
||||||
observable here. And the EIP-1193 error code does not survive the last hop: the
|
|
||||||
rejection that crosses the boundary carries code 4001 and is asserted to, but
|
|
||||||
`src/content/inpage.js` rebuilds it as `new Error(message)`, so the calling page
|
|
||||||
catches an error with no `code` property.
|
|
||||||
|
|
||||||
Any test that drives a failure path on purpose declares the `console.error` it
|
Any test that drives a failure path on purpose declares the `console.error` it
|
||||||
is about to provoke, via `errors.expect()`. That is not a mute: the declaration
|
is about to provoke, via `errors.expect()`. That is not a mute: the declaration
|
||||||
consumes exactly one matching record, and a declaration nothing matched fails
|
consumes exactly one matching record, and a declaration nothing matched fails
|
||||||
@@ -239,90 +200,12 @@ a `ReferenceError` from a used-but-not-imported identifier is invisible to
|
|||||||
`make check` (`script/lint` is only `prettier --check`) but fatal in a browser,
|
`make check` (`script/lint` is only `prettier --check`) but fatal in a browser,
|
||||||
and this suite exists because exactly that class of bug shipped twice.
|
and this suite exists because exactly that class of bug shipped twice.
|
||||||
|
|
||||||
### Firefox (`make test-e2e-firefox`)
|
`make test-e2e` is deliberately **not** part of `make check` or `make test`.
|
||||||
|
`REPO_POLICIES.md` caps `make test` at 20 seconds and a browser suite does not
|
||||||
`make test-e2e-firefox` builds `dist/firefox/` and drives the **real popup in a
|
fit; nothing in `tests/e2e/` is named `*.test.js`, so jest cannot pick it up
|
||||||
real Firefox**, installed as an unpacked MV2 temporary add-on via geckodriver.
|
either. It is also not wired into the Gitea workflow yet — docker-in-docker in
|
||||||
It covers popup load, wallet creation through the UI, and the Add Token screen.
|
CI is a separate question. Run it locally before changing anything under
|
||||||
The suite lives in `tests/e2e/firefox/` and has **no npm dependencies at all**:
|
`src/popup/views/`.
|
||||||
it is a small WebDriver client built on global `fetch` and `child_process`
|
|
||||||
against geckodriver's HTTP API.
|
|
||||||
|
|
||||||
Unlike the Chrome suite it builds its own container image rather than pulling a
|
|
||||||
published one, because no published image carries both a pinned Firefox and a
|
|
||||||
matching geckodriver. `tests/e2e/firefox/Dockerfile` pins all three external
|
|
||||||
artifacts by digest — the `node` base image, the Firefox 153.0.3 tarball, and
|
|
||||||
geckodriver 0.36.0 — and the Firefox version in particular must not float:
|
|
||||||
`-remote-allow-system-access` is **mandatory** on 153 and was not on 142.
|
|
||||||
Without that flag, both navigating to `moz-extension://` and running
|
|
||||||
chrome-context script fail with `unsupported operation`. The flag grants the
|
|
||||||
driver full chrome privileges over that browser, which is acceptable only
|
|
||||||
because it is a throwaway container.
|
|
||||||
|
|
||||||
The popup's `moz-extension://` uuid is **pinned, not discovered**: the profile
|
|
||||||
pref `extensions.webextensions.uuids` maps the extension id that
|
|
||||||
`manifest/firefox.json` already declares to a fixed uuid, so the popup URL is
|
|
||||||
deterministic. Navigation uses **classic** WebDriver `POST /session/{id}/url`,
|
|
||||||
because BiDi's `browsingContext.navigate` refuses `moz-extension://` outright.
|
|
||||||
|
|
||||||
**Any uncaught error from a `moz-extension://` source fails the run**, including
|
|
||||||
errors from the background page, which the suite never navigates to: a `throw`
|
|
||||||
at the top of `src/background/index.js` kills the background page and fails
|
|
||||||
step 1. Content-script errors should arrive by the same route, but this suite
|
|
||||||
does not exercise it and does not claim it — with `--network none` there is no
|
|
||||||
`http://` page for a content script to be injected into. Errors from add-on
|
|
||||||
install and background startup are folded into step 1 rather than discarded.
|
|
||||||
Errors are read from the privileged `nsIConsoleService` in Marionette's chrome
|
|
||||||
context and filtered to non-warning entries whose `sourceName` is the extension
|
|
||||||
origin. That mechanism is not a stylistic choice. WebDriver BiDi's
|
|
||||||
`log.entryAdded` delivers **nothing** for extension pages: on a plain `http://`
|
|
||||||
page it reports uncaught errors with stack traces, and on the `moz-extension://`
|
|
||||||
popup it reports zero events, because Firefox's remote agent excludes extension
|
|
||||||
browsing contexts from BiDi observation. Any harness built on Playwright-BiDi or
|
|
||||||
Puppeteer-BiDi would therefore see nothing and report success, which is exactly
|
|
||||||
the vacuous check this repo has already shipped twice. Do not migrate this suite
|
|
||||||
to BiDi.
|
|
||||||
|
|
||||||
Two limits are worth knowing, both real differences from the Chrome suite:
|
|
||||||
|
|
||||||
- **Error capture is poll-based, not event-streamed.** The console is drained at
|
|
||||||
each step boundary, so an error is attributed to the step it was drained
|
|
||||||
after, not to a moment within it. The window that is drained runs from add-on
|
|
||||||
install to **≈1.5s** after the last step returns — a 500ms settle, a 1000ms
|
|
||||||
tail sleep and two drain round trips — and then the browser is torn down. That
|
|
||||||
cut-off is not a hard boundary: with throws scheduled at fixed offsets, three
|
|
||||||
runs reported everything up to +1.5s and one of the three also reported +1.6s,
|
|
||||||
so an error landing near it may or may not be seen, and anything well past it
|
|
||||||
is not. Inside the window there is no race — each drain reads and clears the
|
|
||||||
console in a single chrome round trip, so an error logged mid-drain lands in
|
|
||||||
that batch or the next rather than being destroyed unread — but there is a
|
|
||||||
**capacity limit**: `nsIConsoleService` keeps a ring buffer of 250 messages
|
|
||||||
and silently evicts the oldest, so more than 250 console messages between two
|
|
||||||
drains destroys the excess unread. 400 throws inside one step are reported as
|
|
||||||
exactly the newest 250, three runs running. That buffer is shared with
|
|
||||||
Firefox's own console noise; a clean run peaks at 4 of 250 at the install
|
|
||||||
drain and 0 at every later drain, so the three steps here have wide headroom,
|
|
||||||
but a step that logs heavily could evict unread errors. What poll-based costs
|
|
||||||
is location, not coverage: an error cannot be placed within a step the way the
|
|
||||||
Chrome suite's `pageerror` events place it.
|
|
||||||
- **Nothing is stubbed, which inverts the coverage of network-dependent code.**
|
|
||||||
There is no fixture layer; the container runs with `--network none` instead,
|
|
||||||
so the run is offline and deterministic and no request can escape. The
|
|
||||||
extension swallows its own fetch failures, so the flows are unaffected — but
|
|
||||||
every network call fails, so only the _failure_ branches of code that depends
|
|
||||||
on one are ever executed. A `ReferenceError` in the success path of
|
|
||||||
`renderTransactions`, or of price or balance rendering, passes this suite
|
|
||||||
green. The offline run is also weaker than the Chrome suite's interception: it
|
|
||||||
proves nothing got out, but it cannot report which requests were attempted.
|
|
||||||
Closing that gap needs a fixture layer, deliberately out of scope for this
|
|
||||||
harness.
|
|
||||||
|
|
||||||
Neither `make test-e2e` nor `make test-e2e-firefox` is part of `make check` or
|
|
||||||
`make test`. `REPO_POLICIES.md` caps `make test` at 20 seconds and a browser
|
|
||||||
suite does not fit; nothing in `tests/e2e/` is named `*.test.js`, so jest cannot
|
|
||||||
pick it up either. Neither is wired into the Gitea workflow yet —
|
|
||||||
docker-in-docker in CI is a separate question. Run them locally before changing
|
|
||||||
anything under `src/popup/views/`.
|
|
||||||
|
|
||||||
## Rationale
|
## Rationale
|
||||||
|
|
||||||
|
|||||||
105
TODO.md
105
TODO.md
@@ -30,10 +30,9 @@ compiled off.
|
|||||||
|
|
||||||
The backlog lives on the
|
The backlog lives on the
|
||||||
[Gitea tracker](https://git.eeqj.de/sneak/AutistMask/issues), which is
|
[Gitea tracker](https://git.eeqj.de/sneak/AutistMask/issues), which is
|
||||||
authoritative; this file does not duplicate it. Full policy file set present.
|
authoritative; this file does not duplicate it. Full policy file set present. A
|
||||||
Real-browser end-to-end suites (`make test-e2e` for Chrome,
|
real-browser end-to-end suite (`make test-e2e`) now sits alongside `make check`,
|
||||||
`make test-e2e-firefox` for Firefox) now sit alongside `make check`, which
|
which cannot see a runtime `ReferenceError` in a popup view.
|
||||||
cannot see a runtime `ReferenceError` in a popup view.
|
|
||||||
|
|
||||||
# Next Step
|
# Next Step
|
||||||
|
|
||||||
@@ -45,96 +44,6 @@ undefined identifiers, which is how
|
|||||||
|
|
||||||
# Completed Steps
|
# Completed Steps
|
||||||
|
|
||||||
- 2026-08-14: A background message handler that throws now rejects the page
|
|
||||||
instead of hanging it. `handleRpc(...).then(sendResponse)` had no `.catch()`,
|
|
||||||
and `sendResponse` is the only thing that settles the dApp's
|
|
||||||
`window.ethereum.request()` promise — so any throw inside `handleRpc` left
|
|
||||||
that promise pending forever, with no error and no timeout, indistinguishable
|
|
||||||
from a slow wallet. It now answers `{ code: -32603, message }` (the JSON-RPC
|
|
||||||
internal error EIP-1474 defines and EIP-1193 defers to; no EIP-1193 4xxx code
|
|
||||||
describes "the wallet broke" and none was invented) and logs the method and
|
|
||||||
the throw to the background console rather than swallowing them. The two async
|
|
||||||
IIFEs behind `AUTISTMASK_TX_RESPONSE` and `AUTISTMASK_SIGN_RESPONSE` were the
|
|
||||||
same shape one level down — every statement inside a `try`, but a throw out of
|
|
||||||
a `catch` block escaping unhandled — and each got a last-resort `.catch()`
|
|
||||||
settling the approval through `settleApproval()` and answering the popup; the
|
|
||||||
transaction one reports the broadcast stage, because it cannot tell whether
|
|
||||||
the transaction reached the network. Every other handler on the path is
|
|
||||||
synchronous. All three are driven by real failures — a rejecting storage read,
|
|
||||||
and a failure classifier that throws while classifying a genuine verification
|
|
||||||
failure — and were demonstrated failing first, the RPC one with `sendResponse`
|
|
||||||
at zero calls ([#280](https://git.eeqj.de/sneak/AutistMask/issues/280)).
|
|
||||||
- 2026-08-12: EIP-1193 error codes now reach the page. `src/content/inpage.js`
|
|
||||||
rebuilt every failure as `new Error(error.message)`, so the code the
|
|
||||||
background produced and the content script relayed intact was dropped in the
|
|
||||||
last hop and a dApp checking `err.code === 4001` saw `undefined` — a wallet
|
|
||||||
the user deliberately declined was indistinguishable from one that broke. The
|
|
||||||
provider now rejects with a `ProviderRpcError` carrying `code` and, where the
|
|
||||||
boundary sent one, `data`, passed through verbatim rather than matched against
|
|
||||||
a list, so 4001, 4100 and 4902 all arrive and a future code needs no edit
|
|
||||||
here. An error the background sent with no code stays a plain `Error` with no
|
|
||||||
`code` property, and `message` is unchanged in every case. All four request
|
|
||||||
entry points (`request`, `enable`, `send`, `sendAsync`) are covered by
|
|
||||||
`tests/inpageErrors.test.js`, and the e2e probe that printed the missing code
|
|
||||||
now requires it on the page's Error as well as on the wire, for all four
|
|
||||||
rejected flows ([#274](https://git.eeqj.de/sneak/AutistMask/issues/274)).
|
|
||||||
- 2026-08-12: `KNOWN_SYMBOLS` now maps a symbol to the set of contract addresses
|
|
||||||
that bear it, not to one of them. A ticker is not unique: seven of the 512
|
|
||||||
bundled tokens — `FRAX`, `REUSD`, `TON`, `EURE`, `MSUSD`, `MUSD` and `JPYC` —
|
|
||||||
share a symbol with another bundled entry at a different real contract, and
|
|
||||||
the table, built from the list first-wins, kept only the earlier one. The
|
|
||||||
other seven were judged spoofs of their own symbol at their own address and
|
|
||||||
hidden from the balance list, the history and the send selector, so a holder
|
|
||||||
could not spend them. Both contracts of each pair come from the same CoinGecko
|
|
||||||
fetch of 2026-02-27, so neither was stale and neither was dropped.
|
|
||||||
`isSpoofedSymbol()` asks set membership instead of equality, which does not
|
|
||||||
loosen the rule — a contract outside the set is still a spoof — and a test now
|
|
||||||
walks `TOKENS` asserting no bundled token is filtered at its own address,
|
|
||||||
which is the walk the suite lacked
|
|
||||||
([#276](https://git.eeqj.de/sneak/AutistMask/issues/276)).
|
|
||||||
- 2026-08-12: The dApp approval round trips are driven end to end in the
|
|
||||||
browser. A test page served by the harness speaks EIP-1193 to the real inpage
|
|
||||||
provider through the real content script, background worker and approval popup
|
|
||||||
for `eth_requestAccounts`, `personal_sign`, `eth_signTypedData_v4` and
|
|
||||||
`eth_sendTransaction`. Every signature is recovered and compared against the
|
|
||||||
active address, the transaction is checked against the bytes handed to the
|
|
||||||
stubbed RPC, each rejection must reach the page as a rejection, and the
|
|
||||||
password must appear in no message the approval window sends — the assertion
|
|
||||||
that gives [#157](https://git.eeqj.de/sneak/AutistMask/issues/157) a permanent
|
|
||||||
floor. This does not discharge a real dApp with real funds against mainnet
|
|
||||||
([#183](https://git.eeqj.de/sneak/AutistMask/issues/183)).
|
|
||||||
- 2026-08-12: The known-symbol spoof rule now judges the symbol a user actually
|
|
||||||
sees. `isSpoofedSymbol()` normalizes before the lookup — NFKC, then every
|
|
||||||
character that paints nothing removed (the format and default-ignorable
|
|
||||||
characters, plus U+007F), then trimmed — so `" ETH "`, a no-break space, a
|
|
||||||
zero-width space, a Hangul filler, a variation selector, a DELETE and a
|
|
||||||
fullwidth `ETH` are all caught on the balance list, the history and the
|
|
||||||
send selector at once. Confusables that are distinct letters (Cyrillic `Е`),
|
|
||||||
bidi reordering and the visible C0/C1 controls — which measure 48.00px, a box,
|
|
||||||
in the pinned e2e Chromium where an invisible prefix measures 32.00px — stay
|
|
||||||
knowingly open and are asserted as open in the suite. No bundled symbol
|
|
||||||
contains whitespace or a non-ASCII character, so nothing legitimate is newly
|
|
||||||
filtered; the balance list's token-type gate also became case-insensitive,
|
|
||||||
which no longer drops a real holding if an explorer writes `erc-20`
|
|
||||||
([#260](https://git.eeqj.de/sneak/AutistMask/issues/260)).
|
|
||||||
- 2026-08-12: A containerized Firefox end-to-end harness
|
|
||||||
(`make test-e2e-firefox`) drives the real popup in a real Firefox with the MV2
|
|
||||||
build installed as a temporary add-on. Zero npm dependencies — a WebDriver
|
|
||||||
client over `fetch` against geckodriver — with `node`, Firefox 153.0.3 and
|
|
||||||
geckodriver 0.36.0 all pinned by digest. Uncaught errors are read from the
|
|
||||||
privileged console service in Marionette's chrome context, because BiDi
|
|
||||||
`log.entryAdded` reports nothing at all for extension pages; each drain reads
|
|
||||||
and clears the console in one chrome round trip, so no error is destroyed
|
|
||||||
unread by the drain itself, and errors logged during add-on install and
|
|
||||||
background startup are folded into step 1 instead of being cleared. The two
|
|
||||||
measured limits are documented rather than claimed away: the console ring
|
|
||||||
buffer holds 250 messages (a clean run peaks at 4), and the drained window
|
|
||||||
ends ≈1.5s after the last step returns. Demonstrated discriminating by exiting
|
|
||||||
1 on a `throw` at the top of `src/background/index.js`, on a build with one
|
|
||||||
import removed, on a `setTimeout` throw whose UI assertions all pass, on an
|
|
||||||
unhandled `Promise.reject` and on an undefined identifier in `home.js`, and 0
|
|
||||||
on the branch as it stands
|
|
||||||
([#184](https://git.eeqj.de/sneak/AutistMask/issues/184)).
|
|
||||||
- 2026-08-12: The transaction a dApp asks for is now populated in the background
|
- 2026-08-12: The transaction a dApp asks for is now populated in the background
|
||||||
before the approval window opens, so the object the user is shown is the
|
before the approval window opens, so the object the user is shown is the
|
||||||
object the signed artifact is verified against — nonce, gas limit and every
|
object the signed artifact is verified against — nonce, gas limit and every
|
||||||
@@ -370,9 +279,9 @@ tracker.
|
|||||||
- Pre-1.0 security review of the extension (key handling, DEBUG mode policy, RPC
|
- Pre-1.0 security review of the extension (key handling, DEBUG mode policy, RPC
|
||||||
input validation) before any 1.0rc tag. Individual filed issues are parts of
|
input validation) before any 1.0rc tag. Individual filed issues are parts of
|
||||||
it, but the review is broader than any of them.
|
it, but the review is broader than any of them.
|
||||||
- Decide whether docker-in-docker makes `make test-e2e` and
|
- Decide whether docker-in-docker makes `make test-e2e` runnable in the Gitea
|
||||||
`make test-e2e-firefox` runnable in the Gitea workflow. Extending the Chrome
|
workflow. Extending the suite itself is tracked as
|
||||||
suite itself is tracked as
|
[#183](https://git.eeqj.de/sneak/AutistMask/issues/183) and
|
||||||
[#183](https://git.eeqj.de/sneak/AutistMask/issues/183).
|
[#184](https://git.eeqj.de/sneak/AutistMask/issues/184).
|
||||||
- Cut 1.0.0 once the milestone is empty, then continue tagging as milestones
|
- Cut 1.0.0 once the milestone is empty, then continue tagging as milestones
|
||||||
land.
|
land.
|
||||||
|
|||||||
@@ -1,63 +0,0 @@
|
|||||||
#!/bin/sh
|
|
||||||
# script/test-e2e-firefox: build the extension and drive the real popup in
|
|
||||||
# a real Firefox inside a pinned container. The Firefox counterpart to
|
|
||||||
# script/test-e2e. Our own extension to scripts-to-rule-them-all.
|
|
||||||
#
|
|
||||||
# Deliberately NOT called by script/check or script/test, for the same
|
|
||||||
# reason as the Chrome suite: REPO_POLICIES.md caps make test at 20 seconds
|
|
||||||
# and a browser suite does not fit.
|
|
||||||
#
|
|
||||||
# Unlike script/test-e2e this builds its image locally, because no
|
|
||||||
# published image carries both a pinned Firefox and a matching geckodriver.
|
|
||||||
# All three external artifacts are pinned by digest inside the Dockerfile;
|
|
||||||
# see tests/e2e/firefox/Dockerfile.
|
|
||||||
set -eu
|
|
||||||
|
|
||||||
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd -P)"
|
|
||||||
ROOT="$(cd "$SCRIPT_DIR/.." && pwd -P)"
|
|
||||||
|
|
||||||
IMAGE="$("$SCRIPT_DIR/projectname")-e2e-firefox"
|
|
||||||
|
|
||||||
main() {
|
|
||||||
cd "$ROOT"
|
|
||||||
|
|
||||||
if ! command -v docker >/dev/null 2>&1; then
|
|
||||||
echo "test-e2e-firefox: docker is required to run the e2e suite" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
|
|
||||||
echo "Building extension for e2e..."
|
|
||||||
yarn run build 2>&1
|
|
||||||
|
|
||||||
# The build context is tests/e2e/firefox/ and holds nothing but the
|
|
||||||
# Dockerfile: the harness itself arrives over the bind mount below, so
|
|
||||||
# editing it never invalidates an image layer.
|
|
||||||
echo "Building the pinned Firefox e2e image..."
|
|
||||||
docker build -t "$IMAGE" "$ROOT/tests/e2e/firefox"
|
|
||||||
|
|
||||||
echo "Running the Firefox e2e suite..."
|
|
||||||
# --shm-size=1g: Firefox needs more than the default 64MB /dev/shm.
|
|
||||||
# --network none: the suite stubs nothing, so this is what keeps the
|
|
||||||
# run offline and deterministic. The extension swallows its own
|
|
||||||
# fetch failures, so the popup flows work unchanged; see the
|
|
||||||
# network note in README.md. Weaker than the Chrome suite's
|
|
||||||
# fixture interception, and honestly so — it proves no request
|
|
||||||
# escaped, but it cannot report which ones were attempted.
|
|
||||||
# --user: keep files the suite touches owned by the caller, not root.
|
|
||||||
# HOME=/tmp: the mapped uid has no home directory in the image.
|
|
||||||
#
|
|
||||||
# No --privileged. Firefox's sandbox logs
|
|
||||||
# "CanCreateUserNamespace() clone() failure: EPERM" on startup here;
|
|
||||||
# it is cosmetic and headless Firefox runs fine without it.
|
|
||||||
docker run --rm \
|
|
||||||
--shm-size=1g \
|
|
||||||
--network none \
|
|
||||||
--user "$(id -u):$(id -g)" \
|
|
||||||
-e HOME=/tmp \
|
|
||||||
-v "$ROOT:/work" \
|
|
||||||
-w /work \
|
|
||||||
"$IMAGE" \
|
|
||||||
node tests/e2e/firefox/run.js dist/firefox
|
|
||||||
}
|
|
||||||
|
|
||||||
main "$@"
|
|
||||||
@@ -57,16 +57,6 @@ const connectedSites = {};
|
|||||||
// Pending approval requests: { id: { origin, hostname, resolve } }
|
// Pending approval requests: { id: { origin, hostname, resolve } }
|
||||||
const pendingApprovals = {};
|
const pendingApprovals = {};
|
||||||
|
|
||||||
// What the page is told when a request failed in a way the wallet has no
|
|
||||||
// specific answer for. -32603 is the JSON-RPC internal error EIP-1474 defines
|
|
||||||
// and EIP-1193 defers to for RPC-layer failures; no EIP-1193 4xxx code
|
|
||||||
// describes "the wallet broke", and one is not invented here. The cause is
|
|
||||||
// logged rather than put in the message: the page gets a stable sentence, the
|
|
||||||
// background console gets the throw.
|
|
||||||
const INTERNAL_ERROR_CODE = -32603;
|
|
||||||
const INTERNAL_ERROR_MESSAGE =
|
|
||||||
"AutistMask could not complete this request because of an internal error.";
|
|
||||||
|
|
||||||
async function getState() {
|
async function getState() {
|
||||||
const result = await storageApi.get("autistmask");
|
const result = await storageApi.get("autistmask");
|
||||||
return (
|
return (
|
||||||
@@ -875,26 +865,9 @@ runtime.onMessage.addListener((msg, sender, sendResponse) => {
|
|||||||
// keep fallback
|
// keep fallback
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
handleRpc(msg.method, msg.params, trustedOrigin)
|
handleRpc(msg.method, msg.params, trustedOrigin).then((response) => {
|
||||||
.then((response) => {
|
sendResponse(response);
|
||||||
sendResponse(response);
|
});
|
||||||
})
|
|
||||||
.catch((err) => {
|
|
||||||
// Without this the page's window.ethereum.request() promise
|
|
||||||
// stays pending forever: no response is sent, the content
|
|
||||||
// script posts nothing back, and the dApp cannot tell the
|
|
||||||
// failure from a slow wallet. handleRpc does real work —
|
|
||||||
// state loads, provider calls, transaction population — so
|
|
||||||
// "it does not throw today" is not a property anyone is
|
|
||||||
// maintaining.
|
|
||||||
log.errorf("RPC request failed:", msg.method, err);
|
|
||||||
sendResponse({
|
|
||||||
error: {
|
|
||||||
code: INTERNAL_ERROR_CODE,
|
|
||||||
message: INTERNAL_ERROR_MESSAGE,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
});
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1078,31 +1051,7 @@ runtime.onMessage.addListener((msg, sender, sendResponse) => {
|
|||||||
stage: TX_STAGE_BROADCAST,
|
stage: TX_STAGE_BROADCAST,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
})().catch((e) => {
|
})();
|
||||||
// Every statement above is inside a try, but a throw from one of
|
|
||||||
// the catch blocks escapes as an unhandled rejection and neither
|
|
||||||
// the popup nor the page is ever answered. Settle both, through
|
|
||||||
// the same chokepoint as every other retirement. The stage is
|
|
||||||
// broadcast because this cannot tell whether the transaction
|
|
||||||
// reached the network, and that is the wording that does not
|
|
||||||
// invite a second send.
|
|
||||||
log.errorf("transaction approval response failed:", e);
|
|
||||||
settleApproval(
|
|
||||||
msg.id,
|
|
||||||
{
|
|
||||||
error: {
|
|
||||||
code: INTERNAL_ERROR_CODE,
|
|
||||||
message: INTERNAL_ERROR_MESSAGE,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
{ holdsClaim: true },
|
|
||||||
);
|
|
||||||
sendResponse({
|
|
||||||
error: INTERNAL_ERROR_MESSAGE,
|
|
||||||
retryable: false,
|
|
||||||
stage: TX_STAGE_BROADCAST,
|
|
||||||
});
|
|
||||||
});
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1186,25 +1135,7 @@ runtime.onMessage.addListener((msg, sender, sendResponse) => {
|
|||||||
}
|
}
|
||||||
sendResponse({ error: errMsg, retryable });
|
sendResponse({ error: errMsg, retryable });
|
||||||
}
|
}
|
||||||
})().catch((e) => {
|
})();
|
||||||
// Same shape as the transaction path: a throw out of the catch
|
|
||||||
// block above would leave the popup and the page both waiting.
|
|
||||||
log.errorf("sign approval response failed:", e);
|
|
||||||
settleApproval(
|
|
||||||
msg.id,
|
|
||||||
{
|
|
||||||
error: {
|
|
||||||
code: INTERNAL_ERROR_CODE,
|
|
||||||
message: INTERNAL_ERROR_MESSAGE,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
{ holdsClaim: true },
|
|
||||||
);
|
|
||||||
sendResponse({
|
|
||||||
error: INTERNAL_ERROR_MESSAGE,
|
|
||||||
retryable: false,
|
|
||||||
});
|
|
||||||
});
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -11,39 +11,6 @@
|
|||||||
let nextId = 1;
|
let nextId = 1;
|
||||||
const pending = {};
|
const pending = {};
|
||||||
|
|
||||||
// EIP-1193 ProviderRpcError: `code`, `message`, optional `data`. A class
|
|
||||||
// rather than properties bolted onto an Error because this object crosses
|
|
||||||
// no boundary after construction — it is built in the page's own realm and
|
|
||||||
// handed straight to the caller's catch — so the prototype survives and
|
|
||||||
// `error.name` is a stable thing for a dApp to see.
|
|
||||||
class ProviderRpcError extends Error {
|
|
||||||
constructor(code, message, data) {
|
|
||||||
super(message);
|
|
||||||
this.name = "ProviderRpcError";
|
|
||||||
this.code = code;
|
|
||||||
if (data !== undefined) this.data = data;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Rebuild a boundary error as the error the page catches, carrying the
|
|
||||||
// code (and data) the extension reported. Without this a dApp cannot tell
|
|
||||||
// a user's refusal (4001) from a wallet that broke, and retries or shows
|
|
||||||
// an error instead of accepting the refusal.
|
|
||||||
//
|
|
||||||
// Whatever code arrived is passed through verbatim rather than being
|
|
||||||
// matched against a list: the extension emits 4001, 4100 and 4902 today,
|
|
||||||
// and a code this file has never heard of is still the truth about what
|
|
||||||
// happened. An error reported with no code at all stays a plain Error —
|
|
||||||
// a ProviderRpcError whose `code` is undefined would advertise a
|
|
||||||
// conformance it does not have. `message` is untouched in every case.
|
|
||||||
function toPageError(error) {
|
|
||||||
const message = (error && error.message) || "Request failed";
|
|
||||||
if (error && error.code !== undefined && error.code !== null) {
|
|
||||||
return new ProviderRpcError(error.code, message, error.data);
|
|
||||||
}
|
|
||||||
return new Error(message);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Listen for responses from the content script
|
// Listen for responses from the content script
|
||||||
window.addEventListener("message", function onUuid(event) {
|
window.addEventListener("message", function onUuid(event) {
|
||||||
if (event.source !== window) return;
|
if (event.source !== window) return;
|
||||||
@@ -53,7 +20,7 @@
|
|||||||
if (!p) return;
|
if (!p) return;
|
||||||
delete pending[id];
|
delete pending[id];
|
||||||
if (error) {
|
if (error) {
|
||||||
p.reject(toPageError(error));
|
p.reject(new Error(error.message || "Request failed"));
|
||||||
} else {
|
} else {
|
||||||
p.resolve(result);
|
p.resolve(result);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -66,12 +66,7 @@ async function fetchTokenBalances(address, blockscoutUrl, trackedTokens) {
|
|||||||
|
|
||||||
const balances = [];
|
const balances = [];
|
||||||
for (const item of items) {
|
for (const item of items) {
|
||||||
// Case-insensitive: the token type is an explorer's label, not a
|
if (item.token?.type !== "ERC-20") continue;
|
||||||
// protocol value, and an exact comparison silently drops a real
|
|
||||||
// holding if one ever writes "erc-20". Which types are admitted
|
|
||||||
// is unchanged.
|
|
||||||
const type = String(item.token?.type || "").toUpperCase();
|
|
||||||
if (type !== "ERC-20") continue;
|
|
||||||
const decimals = parseInt(item.token.decimals || "18", 10);
|
const decimals = parseInt(item.token.decimals || "18", 10);
|
||||||
const bal = formatTokenBalance(item.value || "0", decimals);
|
const bal = formatTokenBalance(item.value || "0", decimals);
|
||||||
if (bal === "0.0") continue;
|
if (bal === "0.0") continue;
|
||||||
|
|||||||
@@ -8,23 +8,11 @@
|
|||||||
// either verdict alone, because the balance list is where the user forms
|
// either verdict alone, because the balance list is where the user forms
|
||||||
// their belief about what they own (issue #235).
|
// their belief about what they own (issue #235).
|
||||||
//
|
//
|
||||||
// KNOWN_SYMBOLS maps a symbol to the set of lowercased contract addresses
|
// KNOWN_SYMBOLS maps a symbol to the lowercased contract address that may
|
||||||
// that may bear it, or to null. Null means the symbol belongs to the native
|
// bear it, or to null. Null means the symbol belongs to the native asset,
|
||||||
// asset, which has no contract at all, so no contract may bear it and every
|
// which has no contract at all, so no contract may bear it and every one
|
||||||
// one that does is a spoof. "ETH" is the only such entry today; the rule is
|
// that does is a spoof. "ETH" is the only such entry today; the rule is
|
||||||
// written so that a second one needs no change here or at any call site.
|
// written so that a second one needs no change here or at any call site.
|
||||||
//
|
|
||||||
// The value is a set because a ticker is not unique: seven symbols in the
|
|
||||||
// bundled list belong to two real contracts each, and answering with one of
|
|
||||||
// them hid the other one's holders' money (issue #276). Membership, not
|
|
||||||
// equality, is therefore the question — but it is the same question, asked of
|
|
||||||
// a table that can now state the truth. Every address in a set is one the
|
|
||||||
// wallet ships as a real token; a contract outside the set is still a spoof.
|
|
||||||
//
|
|
||||||
// The symbol is attacker-controlled — it is whatever the ERC-20 contract
|
|
||||||
// returns — so the lookup is done on a normalized form (issue #260): the
|
|
||||||
// question is whether the symbol reaches the user's eye as a known one,
|
|
||||||
// since that is what the user acts on.
|
|
||||||
|
|
||||||
const { KNOWN_SYMBOLS } = require("./tokenList");
|
const { KNOWN_SYMBOLS } = require("./tokenList");
|
||||||
|
|
||||||
@@ -34,59 +22,6 @@ function normalizeAddress(addr) {
|
|||||||
return (addr || "").toLowerCase();
|
return (addr || "").toLowerCase();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Fold a symbol onto what a user actually sees, and no further:
|
|
||||||
//
|
|
||||||
// NFKC collapses compatibility variants that render as the ASCII
|
|
||||||
// letters they imitate — fullwidth ETH, styled mathematical
|
|
||||||
// letters — and maps the non-ASCII spaces onto U+0020.
|
|
||||||
// strip drops what paints nothing: \p{Cf} plus
|
|
||||||
// \p{Default_Ignorable_Code_Point} plus U+007F. That covers
|
|
||||||
// the format characters (zero-width space, joiner and
|
|
||||||
// non-joiner, word joiner, soft hyphen, byte-order mark, bidi
|
|
||||||
// marks and overrides), the variation selectors, the Hangul
|
|
||||||
// fillers, and DELETE. Removed everywhere, not merely at the
|
|
||||||
// ends.
|
|
||||||
// trim removes surrounding whitespace, which HTML collapses:
|
|
||||||
// `" ETH "` is painted next to the user's real ETH as `ETH`.
|
|
||||||
// toUpperCase makes the comparison case-insensitive, as before.
|
|
||||||
//
|
|
||||||
// The rule is "strip what paints nothing". The Unicode classes are how
|
|
||||||
// that is spelled, not what it means, which is why U+007F is named on its
|
|
||||||
// own: it is a control rather than a default-ignorable character, so no
|
|
||||||
// class here reaches it, yet it paints nothing all the same. Measured in
|
|
||||||
// the repo's pinned e2e Chromium (16px sans-serif, plain `ETH` = 32.00px,
|
|
||||||
// so an invisible prefix leaves 32.00px):
|
|
||||||
//
|
|
||||||
// U+007F, U+3164, U+115F, U+FE0F, U+FE00 32.00px — invisible
|
|
||||||
// U+FFA0 40.00px — a box
|
|
||||||
// U+1160 48.00px — a box
|
|
||||||
// U+0001, U+0085, U+0090 48.00px — a box
|
|
||||||
//
|
|
||||||
// U+1160 and U+FFA0 are `Default_Ignorable_Code_Point` members that font
|
|
||||||
// fallback nonetheless draws, and they are stripped anyway: erring toward
|
|
||||||
// hiding a token that does not look like `ETH` is the harmless direction of
|
|
||||||
// the two. The other controls are left alone for the same reason read the
|
|
||||||
// other way — a symbol carrying a visible box does not reach the eye as
|
|
||||||
// `ETH`, so filtering it would hide a token the user could not have
|
|
||||||
// confused with the native asset.
|
|
||||||
//
|
|
||||||
// Deliberately not folded, and asserted as open in tests/symbolSpoof.test.js:
|
|
||||||
// interior whitespace (`E T H` renders as `E T H`, so folding it would filter
|
|
||||||
// a token nobody could confuse with the native asset), confusables that are
|
|
||||||
// distinct letters rather than compatibility variants (Cyrillic capital Ie,
|
|
||||||
// U+0415; Greek capital Epsilon, U+0395), bidi reordering, which needs the
|
|
||||||
// bidi algorithm rather than a character filter, and the visible controls.
|
|
||||||
//
|
|
||||||
// This decides only how the question is asked. Nothing here changes what a
|
|
||||||
// surface displays; a token still shows the symbol it reports.
|
|
||||||
function normalizeSymbol(symbol) {
|
|
||||||
return String(symbol || "")
|
|
||||||
.normalize("NFKC")
|
|
||||||
.replace(/[\p{Cf}\p{Default_Ignorable_Code_Point}\x7F]/gu, "")
|
|
||||||
.trim()
|
|
||||||
.toUpperCase();
|
|
||||||
}
|
|
||||||
|
|
||||||
// True when a token bearing `symbol` from contract `contractAddress` is
|
// True when a token bearing `symbol` from contract `contractAddress` is
|
||||||
// impersonating a known symbol.
|
// impersonating a known symbol.
|
||||||
//
|
//
|
||||||
@@ -96,11 +31,11 @@ function normalizeSymbol(symbol) {
|
|||||||
function isSpoofedSymbol(symbol, contractAddress) {
|
function isSpoofedSymbol(symbol, contractAddress) {
|
||||||
const contract = normalizeAddress(contractAddress);
|
const contract = normalizeAddress(contractAddress);
|
||||||
if (!contract) return false;
|
if (!contract) return false;
|
||||||
const sym = normalizeSymbol(symbol);
|
const sym = (symbol || "").toUpperCase();
|
||||||
if (!KNOWN_SYMBOLS.has(sym)) return false;
|
if (!KNOWN_SYMBOLS.has(sym)) return false;
|
||||||
const legit = KNOWN_SYMBOLS.get(sym);
|
const legit = KNOWN_SYMBOLS.get(sym);
|
||||||
if (legit === null) return true;
|
if (legit === null) return true;
|
||||||
return !legit.has(contract);
|
return contract !== normalizeAddress(legit);
|
||||||
}
|
}
|
||||||
|
|
||||||
module.exports = {
|
module.exports = {
|
||||||
|
|||||||
@@ -3607,33 +3607,14 @@ for (const t of TOKENS) {
|
|||||||
TOKEN_BY_ADDRESS.set(t.address.toLowerCase(), t);
|
TOKEN_BY_ADDRESS.set(t.address.toLowerCase(), t);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Build a map of symbol (uppercased) -> the set of contract addresses
|
// Build a map of symbol (uppercased) -> legitimate contract address (lowercased).
|
||||||
// (lowercased) that legitimately bear it. Used for spoofed-symbol detection.
|
// Used for spoofed-symbol detection. "ETH" maps to null (native token).
|
||||||
// "ETH" maps to null: the native asset has no contract, so no contract may
|
|
||||||
// bear its symbol.
|
|
||||||
//
|
|
||||||
// The value is a set and not a single address because tickers are not unique
|
|
||||||
// and the list above proves it: seven of these 512 tokens share a symbol with
|
|
||||||
// another entry — FRAX, REUSD, TON, EURE, MSUSD, MUSD and JPYC — at two
|
|
||||||
// different real contracts each, all of them from the same source fetch. A
|
|
||||||
// one-address-per-symbol table can only answer that by picking a winner, and
|
|
||||||
// the loser is then a token in our own bundled list that the spoof filter
|
|
||||||
// hides from the balance list, the history and the send selector at its own
|
|
||||||
// address, so the user cannot spend it (issue #276). Naming every address
|
|
||||||
// that bears the symbol is the only shape that says what is true; it does not
|
|
||||||
// loosen the rule, because a contract outside the set is still a spoof.
|
|
||||||
const KNOWN_SYMBOLS = new Map();
|
const KNOWN_SYMBOLS = new Map();
|
||||||
KNOWN_SYMBOLS.set("ETH", null);
|
KNOWN_SYMBOLS.set("ETH", null);
|
||||||
for (const t of TOKENS) {
|
for (const t of TOKENS) {
|
||||||
const upper = t.symbol.toUpperCase();
|
const upper = t.symbol.toUpperCase();
|
||||||
if (!KNOWN_SYMBOLS.has(upper)) {
|
if (!KNOWN_SYMBOLS.has(upper)) {
|
||||||
KNOWN_SYMBOLS.set(upper, new Set());
|
KNOWN_SYMBOLS.set(upper, t.address.toLowerCase());
|
||||||
}
|
|
||||||
const addresses = KNOWN_SYMBOLS.get(upper);
|
|
||||||
// A null entry is the native asset and stays null: an ERC-20 that reports
|
|
||||||
// the native symbol does not thereby become entitled to it.
|
|
||||||
if (addresses !== null) {
|
|
||||||
addresses.add(t.address.toLowerCase());
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -133,14 +133,6 @@ function loadBackground(options) {
|
|||||||
ensureRecurringAlarms: jest.fn(async () => {}),
|
ensureRecurringAlarms: jest.fn(async () => {}),
|
||||||
registerAlarmHandlers: jest.fn(),
|
registerAlarmHandlers: jest.fn(),
|
||||||
}));
|
}));
|
||||||
// The real verification module, except where a test replaces one export
|
|
||||||
// with a throw to drive the handler's own error handling into failing.
|
|
||||||
if (opts.approvalVerify) {
|
|
||||||
jest.doMock("../src/shared/approvalVerify", () => ({
|
|
||||||
...jest.requireActual("../src/shared/approvalVerify"),
|
|
||||||
...opts.approvalVerify,
|
|
||||||
}));
|
|
||||||
}
|
|
||||||
|
|
||||||
const persisted = {
|
const persisted = {
|
||||||
wallets: [
|
wallets: [
|
||||||
@@ -160,10 +152,7 @@ function loadBackground(options) {
|
|||||||
global.chrome = {
|
global.chrome = {
|
||||||
storage: {
|
storage: {
|
||||||
local: {
|
local: {
|
||||||
get: jest.fn(
|
get: jest.fn(async () => ({ autistmask: persisted })),
|
||||||
opts.storageGet ||
|
|
||||||
(async () => ({ autistmask: persisted })),
|
|
||||||
),
|
|
||||||
set: jest.fn(async () => {}),
|
set: jest.fn(async () => {}),
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -291,25 +280,6 @@ async function settle() {
|
|||||||
for (let i = 0; i < 50; i++) await Promise.resolve();
|
for (let i = 0; i < 50; i++) await Promise.resolve();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Node aborts the worker process on an unhandled rejection; an extension
|
|
||||||
// service worker does not — the promise is simply never settled, nothing is
|
|
||||||
// sent back, and the page's window.ethereum.request() waits forever. Recording
|
|
||||||
// them instead of dying on them keeps that difference visible: the assertion
|
|
||||||
// that the page WAS answered is what reports the failure, and the recording is
|
|
||||||
// asserted empty alongside it.
|
|
||||||
const unhandledRejections = [];
|
|
||||||
process.on("unhandledRejection", (reason) => {
|
|
||||||
unhandledRejections.push(reason);
|
|
||||||
});
|
|
||||||
|
|
||||||
// Node reports an unhandled rejection on the macrotask turn after the promise
|
|
||||||
// was left unhandled, which is past everything settle() waits for.
|
|
||||||
async function settleIncludingRejections() {
|
|
||||||
await settle();
|
|
||||||
await new Promise((resolve) => setImmediate(resolve));
|
|
||||||
await new Promise((resolve) => setImmediate(resolve));
|
|
||||||
}
|
|
||||||
|
|
||||||
afterEach(() => {
|
afterEach(() => {
|
||||||
delete global.chrome;
|
delete global.chrome;
|
||||||
jest.resetModules();
|
jest.resetModules();
|
||||||
@@ -1064,147 +1034,6 @@ describe("a claimed approval outlives every other retirement path", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
// A handler that throws must still answer. `sendResponse` is the only thing
|
|
||||||
// that settles the page's window.ethereum.request() promise, so a throw that
|
|
||||||
// escapes a handler leaves that promise pending forever — no error, no
|
|
||||||
// timeout, indistinguishable from a slow wallet. Each case below drives a real
|
|
||||||
// throw out of a handler rather than asserting the catch block exists.
|
|
||||||
describe("a handler that throws still settles the page", () => {
|
|
||||||
const INTERNAL_ERROR = {
|
|
||||||
code: -32603,
|
|
||||||
message:
|
|
||||||
"AutistMask could not complete this request because of an internal error.",
|
|
||||||
};
|
|
||||||
|
|
||||||
let errorLog;
|
|
||||||
beforeEach(() => {
|
|
||||||
errorLog = jest.spyOn(console, "error").mockImplementation(() => {});
|
|
||||||
unhandledRejections.length = 0;
|
|
||||||
});
|
|
||||||
afterEach(() => {
|
|
||||||
errorLog.mockRestore();
|
|
||||||
});
|
|
||||||
|
|
||||||
// getState() awaits extension storage unguarded, and every read path in
|
|
||||||
// handleRpc goes through it. A storage read that rejects is the whole
|
|
||||||
// failure — no hook in the handler itself.
|
|
||||||
test("a rejected handleRpc rejects the page instead of hanging it", async () => {
|
|
||||||
const bg = loadBackground({
|
|
||||||
storageGet: async () => {
|
|
||||||
throw new Error("storage unavailable");
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const answer = bg.send(
|
|
||||||
{ type: "AUTISTMASK_RPC", method: "eth_accounts", params: [] },
|
|
||||||
{ origin: ORIGIN },
|
|
||||||
);
|
|
||||||
await settleIncludingRejections();
|
|
||||||
|
|
||||||
// The channel is held open for the async answer, and the answer
|
|
||||||
// arrives.
|
|
||||||
expect(answer.kept).toBe(true);
|
|
||||||
expect(answer.sendResponse).toHaveBeenCalledWith({
|
|
||||||
error: INTERNAL_ERROR,
|
|
||||||
});
|
|
||||||
expect(unhandledRejections).toEqual([]);
|
|
||||||
// Not swallowed: the throw is on the background console, which is how
|
|
||||||
// this class gets caught in future.
|
|
||||||
expect(errorLog).toHaveBeenCalledWith(
|
|
||||||
"[AutistMask]",
|
|
||||||
"RPC request failed:",
|
|
||||||
"eth_accounts",
|
|
||||||
expect.objectContaining({ message: "storage unavailable" }),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The transaction response handler wraps every statement in a try, so what
|
|
||||||
// escapes it is a throw from inside one of its catch blocks. Here the
|
|
||||||
// failure classifier itself throws while classifying a real verification
|
|
||||||
// failure — the approval is left claimed, so nothing else can settle it.
|
|
||||||
test("a throw while handling a failed transaction settles both the page and the popup", async () => {
|
|
||||||
const bg = loadBackground({
|
|
||||||
approvalVerify: {
|
|
||||||
describeTxFailure: () => {
|
|
||||||
throw new Error("classifier broke");
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
const pending = bg.requestTx();
|
|
||||||
await settle();
|
|
||||||
const id = pending.id();
|
|
||||||
|
|
||||||
// A real verification failure: the artifact is signed at a nonce the
|
|
||||||
// approval never displayed.
|
|
||||||
const answer = bg.send(
|
|
||||||
{
|
|
||||||
type: "AUTISTMASK_TX_RESPONSE",
|
|
||||||
id,
|
|
||||||
approved: true,
|
|
||||||
rawSignedTx: await signedAtNonce(NONCE + 1),
|
|
||||||
},
|
|
||||||
{ url: bg.fromPopup.url },
|
|
||||||
);
|
|
||||||
await settleIncludingRejections();
|
|
||||||
|
|
||||||
expect(bg.broadcastTransaction).not.toHaveBeenCalled();
|
|
||||||
expect(pending.result()).toEqual({ error: INTERNAL_ERROR });
|
|
||||||
expect(answer.sendResponse).toHaveBeenCalledWith({
|
|
||||||
error: INTERNAL_ERROR.message,
|
|
||||||
retryable: false,
|
|
||||||
// The handler cannot tell whether the transaction reached the
|
|
||||||
// network, so the popup must not say "start again from the site".
|
|
||||||
stage: "broadcast",
|
|
||||||
});
|
|
||||||
expect(unhandledRejections).toEqual([]);
|
|
||||||
expect(errorLog).toHaveBeenCalledWith(
|
|
||||||
"[AutistMask]",
|
|
||||||
"transaction approval response failed:",
|
|
||||||
expect.objectContaining({ message: "classifier broke" }),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a throw while handling a failed signature settles both the page and the popup", async () => {
|
|
||||||
const bg = loadBackground({
|
|
||||||
approvalVerify: {
|
|
||||||
failureIsRetryable: () => {
|
|
||||||
throw new Error("classifier broke");
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
const pending = bg.requestSign();
|
|
||||||
await settle();
|
|
||||||
|
|
||||||
// A real verification failure: the active address moved after the
|
|
||||||
// approval was raised.
|
|
||||||
bg.setActiveAddress(other.address);
|
|
||||||
const answer = bg.send(
|
|
||||||
{
|
|
||||||
type: "AUTISTMASK_SIGN_RESPONSE",
|
|
||||||
id: pending.id(),
|
|
||||||
approved: true,
|
|
||||||
signature: await signer.signMessage(
|
|
||||||
Buffer.from(MESSAGE.slice(2), "hex"),
|
|
||||||
),
|
|
||||||
},
|
|
||||||
{ url: bg.fromPopup.url },
|
|
||||||
);
|
|
||||||
await settleIncludingRejections();
|
|
||||||
|
|
||||||
expect(pending.result()).toEqual({ error: INTERNAL_ERROR });
|
|
||||||
expect(answer.sendResponse).toHaveBeenCalledWith({
|
|
||||||
error: INTERNAL_ERROR.message,
|
|
||||||
retryable: false,
|
|
||||||
});
|
|
||||||
expect(unhandledRejections).toEqual([]);
|
|
||||||
expect(errorLog).toHaveBeenCalledWith(
|
|
||||||
"[AutistMask]",
|
|
||||||
"sign approval response failed:",
|
|
||||||
expect.objectContaining({ message: "classifier broke" }),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("popup-only messages", () => {
|
describe("popup-only messages", () => {
|
||||||
test("a page sender cannot answer an approval", async () => {
|
test("a page sender cannot answer an approval", async () => {
|
||||||
const bg = loadBackground();
|
const bg = loadBackground();
|
||||||
|
|||||||
@@ -1,51 +0,0 @@
|
|||||||
# Firefox end-to-end image: stock Firefox plus geckodriver on a node base,
|
|
||||||
# built by script/test-e2e-firefox. The repo is bind-mounted at /work; the
|
|
||||||
# harness itself has no dependencies, so nothing is installed for it.
|
|
||||||
#
|
|
||||||
# All three external artifacts are pinned by digest. The Firefox version in
|
|
||||||
# particular must not float: -remote-allow-system-access is mandatory on 153
|
|
||||||
# and was not on 142, so the flag the harness passes is version-coupled.
|
|
||||||
|
|
||||||
# node:22-bookworm-slim, 2026-08-12
|
|
||||||
FROM node@sha256:d649c27dae7ba0137b3cef5dd75baa422c08dc3d9e3fc0c23dfb172dc3cc6436
|
|
||||||
|
|
||||||
ENV DEBIAN_FRONTEND=noninteractive
|
|
||||||
|
|
||||||
# Firefox's shared-library dependencies on a slim base, plus the two tools
|
|
||||||
# needed to fetch and unpack the pinned tarballs.
|
|
||||||
RUN apt-get update \
|
|
||||||
&& apt-get install -y --no-install-recommends \
|
|
||||||
ca-certificates \
|
|
||||||
curl \
|
|
||||||
libasound2 \
|
|
||||||
libdbus-glib-1-2 \
|
|
||||||
libgtk-3-0 \
|
|
||||||
libx11-xcb1 \
|
|
||||||
libxt6 \
|
|
||||||
libxtst6 \
|
|
||||||
xz-utils \
|
|
||||||
&& rm -rf /var/lib/apt/lists/*
|
|
||||||
|
|
||||||
# Firefox 153.0.3, linux-x86_64, en-US
|
|
||||||
ARG FIREFOX_URL=https://ftp.mozilla.org/pub/firefox/releases/153.0.3/linux-x86_64/en-US/firefox-153.0.3.tar.xz
|
|
||||||
ARG FIREFOX_SHA256=22b312280900bfb174b685ece32c7b3c6d72e7f8e53d6d30f21ac41a8dc500a2
|
|
||||||
RUN curl -fsSL -o /tmp/firefox.tar.xz "$FIREFOX_URL" \
|
|
||||||
&& echo "$FIREFOX_SHA256 /tmp/firefox.tar.xz" | sha256sum -c - \
|
|
||||||
&& tar -xJf /tmp/firefox.tar.xz -C /opt \
|
|
||||||
&& rm /tmp/firefox.tar.xz \
|
|
||||||
&& /opt/firefox/firefox --version
|
|
||||||
|
|
||||||
# geckodriver v0.36.0, linux64
|
|
||||||
ARG GECKODRIVER_URL=https://github.com/mozilla/geckodriver/releases/download/v0.36.0/geckodriver-v0.36.0-linux64.tar.gz
|
|
||||||
ARG GECKODRIVER_SHA256=0bde38707eb0a686a20c6bd50f4adcc7d60d4f73c60eb83ee9e0db8f65823e04
|
|
||||||
RUN curl -fsSL -o /tmp/geckodriver.tar.gz "$GECKODRIVER_URL" \
|
|
||||||
&& echo "$GECKODRIVER_SHA256 /tmp/geckodriver.tar.gz" | sha256sum -c - \
|
|
||||||
&& tar -xzf /tmp/geckodriver.tar.gz -C /usr/local/bin \
|
|
||||||
&& rm /tmp/geckodriver.tar.gz \
|
|
||||||
&& geckodriver --version
|
|
||||||
|
|
||||||
ENV FIREFOX_BIN=/opt/firefox/firefox
|
|
||||||
ENV GECKODRIVER=/usr/local/bin/geckodriver
|
|
||||||
|
|
||||||
WORKDIR /work
|
|
||||||
CMD ["node", "tests/e2e/firefox/run.js", "dist/firefox"]
|
|
||||||
@@ -1,464 +0,0 @@
|
|||||||
// A minimal WebDriver client for geckodriver, plus the privileged console
|
|
||||||
// reader the error assertions are built on. No npm dependencies: global
|
|
||||||
// fetch and child_process against geckodriver's HTTP API is less code than
|
|
||||||
// a driver library and keeps the harness at zero packages.
|
|
||||||
//
|
|
||||||
// Run through script/test-e2e-firefox, which builds dist/firefox/ and the
|
|
||||||
// pinned container around this. FIREFOX_BIN and GECKODRIVER locate the two
|
|
||||||
// binaries; the image sets both.
|
|
||||||
|
|
||||||
"use strict";
|
|
||||||
|
|
||||||
const { spawn } = require("child_process");
|
|
||||||
const net = require("net");
|
|
||||||
|
|
||||||
const FIREFOX_BIN = process.env.FIREFOX_BIN || "firefox";
|
|
||||||
const GECKODRIVER = process.env.GECKODRIVER || "geckodriver";
|
|
||||||
|
|
||||||
// The extension id declared in manifest/firefox.json, and the uuid the
|
|
||||||
// popup is served from. Firefox normally assigns that uuid randomly per
|
|
||||||
// profile, which would make the popup URL undiscoverable without querying
|
|
||||||
// privileged state; setting extensions.webextensions.uuids before launch
|
|
||||||
// pins it instead. This only works because the manifest declares a fixed
|
|
||||||
// browser_specific_settings.gecko.id — without one the mapping has no key.
|
|
||||||
const EXTENSION_ID = "autistmask@sneak.berlin";
|
|
||||||
const EXTENSION_UUID = "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee";
|
|
||||||
const EXTENSION_ORIGIN = "moz-extension://" + EXTENSION_UUID;
|
|
||||||
|
|
||||||
// The W3C web element identifier. Getting the last character wrong yields
|
|
||||||
// an element reference of "undefined" and a bewildering "element with the
|
|
||||||
// reference undefined is not known" from geckodriver, so findElement()
|
|
||||||
// below checks for the key rather than indexing blindly.
|
|
||||||
const WEB_ELEMENT_KEY = "element-6066-11e4-a52e-4f735466cecf";
|
|
||||||
|
|
||||||
const SCRIPT_TIMEOUT_MS = 120000;
|
|
||||||
const DEFAULT_WAIT_MS = 20000;
|
|
||||||
const POLL_INTERVAL_MS = 100;
|
|
||||||
|
|
||||||
function sleep(ms) {
|
|
||||||
return new Promise((resolve) => setTimeout(resolve, ms));
|
|
||||||
}
|
|
||||||
|
|
||||||
// An ephemeral port picked by the kernel, then handed to geckodriver.
|
|
||||||
// There is a race between closing this listener and geckodriver binding,
|
|
||||||
// but this host runs many sessions at once and a fixed 4444 is a
|
|
||||||
// guaranteed collision rather than a possible one.
|
|
||||||
function freePort() {
|
|
||||||
return new Promise((resolve, reject) => {
|
|
||||||
const srv = net.createServer();
|
|
||||||
srv.on("error", reject);
|
|
||||||
srv.listen(0, "127.0.0.1", () => {
|
|
||||||
const { port } = srv.address();
|
|
||||||
srv.close(() => resolve(port));
|
|
||||||
});
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
class WebDriverError extends Error {
|
|
||||||
constructor(command, body) {
|
|
||||||
const v = (body && body.value) || {};
|
|
||||||
super(
|
|
||||||
command +
|
|
||||||
" failed: " +
|
|
||||||
(v.error || "unknown error") +
|
|
||||||
": " +
|
|
||||||
(v.message || JSON.stringify(body)),
|
|
||||||
);
|
|
||||||
this.name = "WebDriverError";
|
|
||||||
this.error = v.error;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
class Driver {
|
|
||||||
constructor(proc, base) {
|
|
||||||
this.proc = proc;
|
|
||||||
this.base = base;
|
|
||||||
this.sessionId = null;
|
|
||||||
this.context = "content";
|
|
||||||
}
|
|
||||||
|
|
||||||
async send(method, path, body) {
|
|
||||||
const url = this.base + path;
|
|
||||||
const res = await fetch(url, {
|
|
||||||
method,
|
|
||||||
headers: { "Content-Type": "application/json" },
|
|
||||||
body: body === undefined ? undefined : JSON.stringify(body),
|
|
||||||
});
|
|
||||||
const text = await res.text();
|
|
||||||
let parsed;
|
|
||||||
try {
|
|
||||||
parsed = JSON.parse(text);
|
|
||||||
} catch (_) {
|
|
||||||
throw new Error(
|
|
||||||
method + " " + path + ": non-JSON response: " + text,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
if (!res.ok) throw new WebDriverError(method + " " + path, parsed);
|
|
||||||
return parsed.value;
|
|
||||||
}
|
|
||||||
|
|
||||||
session(method, path, body) {
|
|
||||||
return this.send(method, "/session/" + this.sessionId + path, body);
|
|
||||||
}
|
|
||||||
|
|
||||||
// ------------------------------------------------------------ setup
|
|
||||||
|
|
||||||
async newSession() {
|
|
||||||
const prefs = {
|
|
||||||
// See EXTENSION_UUID above. The pref is a string pref whose
|
|
||||||
// value is itself JSON.
|
|
||||||
"extensions.webextensions.uuids": JSON.stringify({
|
|
||||||
[EXTENSION_ID]: EXTENSION_UUID,
|
|
||||||
}),
|
|
||||||
};
|
|
||||||
|
|
||||||
const value = await this.send("POST", "/session", {
|
|
||||||
capabilities: {
|
|
||||||
alwaysMatch: {
|
|
||||||
browserName: "firefox",
|
|
||||||
"moz:firefoxOptions": {
|
|
||||||
binary: FIREFOX_BIN,
|
|
||||||
args: [
|
|
||||||
"-headless",
|
|
||||||
// Mandatory on Firefox 153: without it,
|
|
||||||
// navigating to moz-extension:// and running
|
|
||||||
// chrome-context script both fail with
|
|
||||||
// "unsupported operation".
|
|
||||||
//
|
|
||||||
// It grants the driver FULL CHROME PRIVILEGES
|
|
||||||
// over this browser. Acceptable only because
|
|
||||||
// the browser is a throwaway in a CI
|
|
||||||
// container; never point a session with this
|
|
||||||
// flag at anything you care about.
|
|
||||||
"-remote-allow-system-access",
|
|
||||||
],
|
|
||||||
prefs,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
this.sessionId = value.sessionId;
|
|
||||||
await this.session("POST", "/timeouts", { script: SCRIPT_TIMEOUT_MS });
|
|
||||||
return value;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Installs the unpacked MV2 build straight from a directory.
|
|
||||||
// temporary:true bypasses signature checks, so no XPI and no signing
|
|
||||||
// are involved, and the add-on dies with the profile.
|
|
||||||
async installAddon(dir) {
|
|
||||||
return this.session("POST", "/moz/addon/install", {
|
|
||||||
path: dir,
|
|
||||||
temporary: true,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
// Classic navigation on purpose. BiDi's browsingContext.navigate
|
|
||||||
// refuses moz-extension:// URLs outright.
|
|
||||||
async navigate(url) {
|
|
||||||
await this.session("POST", "/url", { url });
|
|
||||||
}
|
|
||||||
|
|
||||||
async quit() {
|
|
||||||
if (this.sessionId) {
|
|
||||||
await this.session("DELETE", "").catch(() => {});
|
|
||||||
this.sessionId = null;
|
|
||||||
}
|
|
||||||
this.proc.kill("SIGTERM");
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---------------------------------------------------------- scripts
|
|
||||||
|
|
||||||
async setContext(context) {
|
|
||||||
if (this.context === context) return;
|
|
||||||
await this.session("POST", "/moz/context", { context });
|
|
||||||
this.context = context;
|
|
||||||
}
|
|
||||||
|
|
||||||
async execute(script, args = []) {
|
|
||||||
await this.setContext("content");
|
|
||||||
return this.session("POST", "/execute/sync", { script, args });
|
|
||||||
}
|
|
||||||
|
|
||||||
// Runs in the privileged chrome scope, where Services and Ci exist.
|
|
||||||
async executeChrome(script, args = []) {
|
|
||||||
await this.setContext("chrome");
|
|
||||||
try {
|
|
||||||
return await this.session("POST", "/execute/sync", {
|
|
||||||
script,
|
|
||||||
args,
|
|
||||||
});
|
|
||||||
} finally {
|
|
||||||
await this.setContext("content");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ------------------------------------------------------- page waits
|
|
||||||
|
|
||||||
// Polls a content-context expression until it returns truthy. Every
|
|
||||||
// wait in the suite goes through here so a timeout always says which
|
|
||||||
// condition it was waiting on rather than "timed out".
|
|
||||||
async waitFor(what, script, args = [], timeout = DEFAULT_WAIT_MS) {
|
|
||||||
const deadline = Date.now() + timeout;
|
|
||||||
let last = null;
|
|
||||||
for (;;) {
|
|
||||||
try {
|
|
||||||
const v = await this.execute(script, args);
|
|
||||||
if (v) return v;
|
|
||||||
last = null;
|
|
||||||
} catch (e) {
|
|
||||||
// A navigation or view swap in flight makes execute
|
|
||||||
// throw; that is a not-yet, not a failure, until the
|
|
||||||
// deadline says otherwise.
|
|
||||||
last = e.message;
|
|
||||||
}
|
|
||||||
if (Date.now() >= deadline) {
|
|
||||||
throw new Error(
|
|
||||||
"timed out after " +
|
|
||||||
timeout +
|
|
||||||
"ms waiting for " +
|
|
||||||
what +
|
|
||||||
(last ? " (last error: " + last + ")" : ""),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
await sleep(POLL_INTERVAL_MS);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Shown means shown: in the popup a view is switched by toggling a
|
|
||||||
// "hidden" class, and an element that is present but collapsed is not
|
|
||||||
// the thing a test means by visible.
|
|
||||||
async waitVisible(selector, timeout = DEFAULT_WAIT_MS) {
|
|
||||||
return this.waitFor(
|
|
||||||
"selector " + selector + " to be visible",
|
|
||||||
`const el = document.querySelector(arguments[0]);
|
|
||||||
if (!el) return false;
|
|
||||||
const r = el.getBoundingClientRect();
|
|
||||||
return r.width > 0 && r.height > 0;`,
|
|
||||||
[selector],
|
|
||||||
timeout,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async isVisible(selector) {
|
|
||||||
return this.execute(
|
|
||||||
`const el = document.querySelector(arguments[0]);
|
|
||||||
if (!el) return false;
|
|
||||||
const r = el.getBoundingClientRect();
|
|
||||||
return r.width > 0 && r.height > 0;`,
|
|
||||||
[selector],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async count(selector) {
|
|
||||||
return this.execute(
|
|
||||||
"return document.querySelectorAll(arguments[0]).length;",
|
|
||||||
[selector],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async text(selector) {
|
|
||||||
return this.execute(
|
|
||||||
`const el = document.querySelector(arguments[0]);
|
|
||||||
return el ? el.textContent : null;`,
|
|
||||||
[selector],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async title() {
|
|
||||||
return this.session("GET", "/title");
|
|
||||||
}
|
|
||||||
|
|
||||||
// The id of the view element currently on top, which is what a
|
|
||||||
// failing step needs to report: "the screen did not change" is only
|
|
||||||
// useful if it says which screen it stayed on.
|
|
||||||
async currentView() {
|
|
||||||
return this.execute(
|
|
||||||
`const views = document.querySelectorAll('[id^="view-"]');
|
|
||||||
for (const v of views) {
|
|
||||||
const r = v.getBoundingClientRect();
|
|
||||||
if (r.width > 0 && r.height > 0) return v.id;
|
|
||||||
}
|
|
||||||
return null;`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// ----------------------------------------------------- interactions
|
|
||||||
|
|
||||||
async findElement(selector) {
|
|
||||||
const value = await this.session("POST", "/element", {
|
|
||||||
using: "css selector",
|
|
||||||
value: selector,
|
|
||||||
});
|
|
||||||
const ref = value && value[WEB_ELEMENT_KEY];
|
|
||||||
if (typeof ref !== "string") {
|
|
||||||
throw new Error(
|
|
||||||
"no " +
|
|
||||||
WEB_ELEMENT_KEY +
|
|
||||||
" in the element response for " +
|
|
||||||
selector +
|
|
||||||
": " +
|
|
||||||
JSON.stringify(value),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
return ref;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Real WebDriver clicks and real key events rather than in-page
|
|
||||||
// .click() and value assignment: the popup's handlers are wired to
|
|
||||||
// events, and synthesising them from inside the page would test the
|
|
||||||
// harness's idea of the UI instead of the UI.
|
|
||||||
async click(selector) {
|
|
||||||
await this.waitVisible(selector);
|
|
||||||
const id = await this.findElement(selector);
|
|
||||||
await this.session("POST", "/element/" + id + "/click", {});
|
|
||||||
}
|
|
||||||
|
|
||||||
async fill(selector, value) {
|
|
||||||
await this.waitVisible(selector);
|
|
||||||
const id = await this.findElement(selector);
|
|
||||||
await this.session("POST", "/element/" + id + "/clear", {});
|
|
||||||
await this.session("POST", "/element/" + id + "/value", {
|
|
||||||
text: String(value),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
async value(selector) {
|
|
||||||
return this.execute(
|
|
||||||
`const el = document.querySelector(arguments[0]);
|
|
||||||
return el ? el.value : null;`,
|
|
||||||
[selector],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ------------------------------------------------------- error capture
|
|
||||||
|
|
||||||
// Uncaught errors from extension code, read out of the privileged console
|
|
||||||
// service.
|
|
||||||
//
|
|
||||||
// This is not the obvious mechanism, and the obvious one does not work:
|
|
||||||
// WebDriver BiDi's log.entryAdded delivers NOTHING for extension pages.
|
|
||||||
// Verified on Firefox 142 and 153 against a same-session control — a plain
|
|
||||||
// http:// page yields uncaught errors with stack traces, the
|
|
||||||
// moz-extension:// popup yields zero events, because the remote agent
|
|
||||||
// excludes extension browsing contexts from BiDi observation. A harness
|
|
||||||
// built on Playwright-BiDi or Puppeteer-BiDi therefore sees nothing and
|
|
||||||
// reports success. Do not "simplify" this back to BiDi.
|
|
||||||
//
|
|
||||||
// nsIConsoleService is not per-page: it also carries errors from the
|
|
||||||
// background page, which BiDi would not have covered even if it worked.
|
|
||||||
// Background-page capture is verified by probe — a throw at the top of
|
|
||||||
// src/background/index.js, which kills the background page outright, fails
|
|
||||||
// the run. Content-script errors should arrive by the same route, but that
|
|
||||||
// is UNVERIFIED here and must not be claimed: the container runs with
|
|
||||||
// --network none, so there is no http:// page for a content script to be
|
|
||||||
// injected into and this suite never exercises one.
|
|
||||||
//
|
|
||||||
// Warnings are excluded so the semantics match Playwright's pageerror:
|
|
||||||
// uncaught errors only.
|
|
||||||
//
|
|
||||||
// The read and the clear are ONE chrome script on purpose. Splitting them
|
|
||||||
// into two round trips leaves a blind window between them in which an
|
|
||||||
// error is logged into a buffer that is about to be discarded, and is
|
|
||||||
// destroyed unread rather than deferred to the next drain. That was not
|
|
||||||
// theoretical: with a separate reset() call, a probe of 100 sequenced
|
|
||||||
// throws at 20ms spacing lost one of them outright.
|
|
||||||
const DRAIN_ERRORS_SCRIPT = `
|
|
||||||
const origin = arguments[0];
|
|
||||||
const out = [];
|
|
||||||
for (const raw of Services.console.getMessageArray() || []) {
|
|
||||||
let e;
|
|
||||||
try {
|
|
||||||
e = raw.QueryInterface(Ci.nsIScriptError);
|
|
||||||
} catch (_) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
if (e.flags & Ci.nsIScriptError.warningFlag) continue;
|
|
||||||
const src = e.sourceName || "";
|
|
||||||
if (!src.startsWith(origin)) continue;
|
|
||||||
out.push({
|
|
||||||
msg: e.errorMessage,
|
|
||||||
src: src,
|
|
||||||
line: e.lineNumber,
|
|
||||||
cat: e.category,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
Services.console.reset();
|
|
||||||
return out;
|
|
||||||
`;
|
|
||||||
|
|
||||||
class ConsoleErrors {
|
|
||||||
constructor(driver, originPrefix) {
|
|
||||||
this.driver = driver;
|
|
||||||
this.originPrefix = originPrefix;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Everything logged since the last take, read and cleared atomically
|
|
||||||
// in a single chrome round trip. Poll-based, so an error is attributed
|
|
||||||
// to the step that was running when it was drained, not to the moment
|
|
||||||
// inside that step at which it happened — see the limitation note in
|
|
||||||
// run.js. An error that arrives mid-drain is not lost — it makes this
|
|
||||||
// batch or the next one — but the console service ring buffer holds
|
|
||||||
// only 250 messages, so more than that between two takes evicts the
|
|
||||||
// oldest unread. A clean run peaks at 4.
|
|
||||||
async take() {
|
|
||||||
const found = await this.driver.executeChrome(DRAIN_ERRORS_SCRIPT, [
|
|
||||||
this.originPrefix,
|
|
||||||
]);
|
|
||||||
return found || [];
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ------------------------------------------------------------- startup
|
|
||||||
|
|
||||||
async function waitForDriverReady(base, timeoutMs) {
|
|
||||||
const deadline = Date.now() + timeoutMs;
|
|
||||||
for (;;) {
|
|
||||||
try {
|
|
||||||
const res = await fetch(base + "/status");
|
|
||||||
if (res.ok) {
|
|
||||||
const body = await res.json();
|
|
||||||
if (body && body.value && body.value.ready !== false) return;
|
|
||||||
}
|
|
||||||
} catch (_) {
|
|
||||||
// not listening yet
|
|
||||||
}
|
|
||||||
if (Date.now() >= deadline) {
|
|
||||||
throw new Error(
|
|
||||||
"geckodriver did not become ready within " + timeoutMs + "ms",
|
|
||||||
);
|
|
||||||
}
|
|
||||||
await sleep(POLL_INTERVAL_MS);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function start() {
|
|
||||||
const port = await freePort();
|
|
||||||
const proc = spawn(
|
|
||||||
GECKODRIVER,
|
|
||||||
["--port", String(port), "--host", "127.0.0.1"],
|
|
||||||
{ stdio: ["ignore", "inherit", "inherit"] },
|
|
||||||
);
|
|
||||||
proc.on("error", (e) => {
|
|
||||||
console.error("geckodriver failed to spawn: " + e.message);
|
|
||||||
});
|
|
||||||
|
|
||||||
const base = "http://127.0.0.1:" + port;
|
|
||||||
try {
|
|
||||||
await waitForDriverReady(base, 30000);
|
|
||||||
} catch (e) {
|
|
||||||
proc.kill("SIGKILL");
|
|
||||||
throw e;
|
|
||||||
}
|
|
||||||
return new Driver(proc, base);
|
|
||||||
}
|
|
||||||
|
|
||||||
module.exports = {
|
|
||||||
ConsoleErrors,
|
|
||||||
Driver,
|
|
||||||
EXTENSION_ID,
|
|
||||||
EXTENSION_ORIGIN,
|
|
||||||
EXTENSION_UUID,
|
|
||||||
start,
|
|
||||||
sleep,
|
|
||||||
};
|
|
||||||
@@ -1,288 +0,0 @@
|
|||||||
// Firefox end-to-end suite: drives the real popup in a real Firefox with
|
|
||||||
// the unpacked MV2 build installed as a temporary add-on, and fails the run
|
|
||||||
// on any uncaught error coming from an extension source.
|
|
||||||
//
|
|
||||||
// Run via script/test-e2e-firefox, which builds dist/firefox/ and the pinned
|
|
||||||
// container. The extension directory is the one argument.
|
|
||||||
//
|
|
||||||
// node tests/e2e/firefox/run.js [dist/firefox]
|
|
||||||
//
|
|
||||||
// Deliberately not part of script/check, and deliberately not named
|
|
||||||
// *.test.js: REPO_POLICIES.md caps make test at 20 seconds and a browser
|
|
||||||
// suite does not fit.
|
|
||||||
//
|
|
||||||
// This shares no driver layer with the Chrome suite in tests/e2e/, and the
|
|
||||||
// UI steps below are written twice on purpose. Chrome runs on Playwright,
|
|
||||||
// which cannot see extension-page errors in Firefox at all (see the BiDi
|
|
||||||
// note in driver.js), so the two backends have no common substrate to
|
|
||||||
// abstract over. Three duplicated steps do not pay for a shim; revisit if
|
|
||||||
// this suite grows to where they do.
|
|
||||||
//
|
|
||||||
// LIMITATION, and the difference from the Chrome suite worth knowing: error
|
|
||||||
// capture here is POLL-BASED, not event-streamed. The console service is
|
|
||||||
// drained at each step boundary, so an error is attributed to the step it
|
|
||||||
// was drained after, never to a moment within that step. What is drained
|
|
||||||
// covers the whole run from add-on install to the last drain below, which
|
|
||||||
// lands ~1.5s after the last step returns (500ms settle + 1000ms sleep +
|
|
||||||
// two drain round trips). That cut-off jitters run to run: three runs of
|
|
||||||
// throws at fixed offsets reported everything to +1.5s and one of them
|
|
||||||
// also +1.6s, and past it the browser is torn down first. Inside the
|
|
||||||
// window there is no race — the drain reads and clears in one chrome
|
|
||||||
// round trip — but there is a capacity limit: nsIConsoleService keeps
|
|
||||||
// only the newest 250 messages, so 400 throws in one step report as
|
|
||||||
// exactly 250. A clean run peaks at 4 of 250, so that is headroom today
|
|
||||||
// and not a guarantee for a step that logs heavily. The Chrome harness
|
|
||||||
// receives pageerror events as they happen and can say more. Do not read
|
|
||||||
// a green Firefox run as the same claim.
|
|
||||||
|
|
||||||
"use strict";
|
|
||||||
|
|
||||||
const fs = require("fs");
|
|
||||||
const path = require("path");
|
|
||||||
|
|
||||||
const { ConsoleErrors, EXTENSION_ORIGIN, start, sleep } = require("./driver");
|
|
||||||
|
|
||||||
const REPO_ROOT = path.resolve(__dirname, "..", "..", "..");
|
|
||||||
const POPUP_URL = EXTENSION_ORIGIN + "/src/popup/index.html";
|
|
||||||
const PASSWORD = "e2e-harness-password";
|
|
||||||
|
|
||||||
// Firefox installs the add-on and starts its background page asynchronously
|
|
||||||
// after the install call returns. Nothing observable marks the end of that,
|
|
||||||
// so the popup's own first render is the signal we wait on instead.
|
|
||||||
const STEP_TIMEOUT_MS = 120000;
|
|
||||||
|
|
||||||
const steps = [];
|
|
||||||
|
|
||||||
function step(name, fn) {
|
|
||||||
steps.push({ name, fn });
|
|
||||||
}
|
|
||||||
|
|
||||||
function assert(cond, message) {
|
|
||||||
if (!cond) throw new Error(message);
|
|
||||||
}
|
|
||||||
|
|
||||||
function withTimeout(promise, name) {
|
|
||||||
let timer;
|
|
||||||
const timeout = new Promise((_, reject) => {
|
|
||||||
timer = setTimeout(
|
|
||||||
() =>
|
|
||||||
reject(
|
|
||||||
new Error(
|
|
||||||
name + " timed out after " + STEP_TIMEOUT_MS + "ms",
|
|
||||||
),
|
|
||||||
),
|
|
||||||
STEP_TIMEOUT_MS,
|
|
||||||
);
|
|
||||||
});
|
|
||||||
return Promise.race([promise, timeout]).finally(() => clearTimeout(timer));
|
|
||||||
}
|
|
||||||
|
|
||||||
// ------------------------------------------------------------- steps
|
|
||||||
|
|
||||||
step("popup loads and reaches the welcome view", async (env) => {
|
|
||||||
const d = env.driver;
|
|
||||||
await d.navigate(POPUP_URL);
|
|
||||||
await d.waitVisible("#view-welcome", STEP_TIMEOUT_MS);
|
|
||||||
const title = await d.title();
|
|
||||||
assert(title === "AutistMask", "unexpected popup title: " + title);
|
|
||||||
});
|
|
||||||
|
|
||||||
step("wallet creation through the UI reaches the main view", async (env) => {
|
|
||||||
const d = env.driver;
|
|
||||||
await d.click("#btn-welcome-add");
|
|
||||||
await d.waitVisible("#view-add-wallet");
|
|
||||||
await d.click("#btn-generate-phrase");
|
|
||||||
await d.waitFor(
|
|
||||||
"a generated recovery phrase of at least 12 words",
|
|
||||||
`const el = document.getElementById("wallet-mnemonic");
|
|
||||||
return !!el && el.value.trim().split(/\\s+/).length >= 12;`,
|
|
||||||
);
|
|
||||||
env.phrase = (await d.value("#wallet-mnemonic")).trim();
|
|
||||||
|
|
||||||
await d.fill("#add-wallet-password", PASSWORD);
|
|
||||||
await d.fill("#add-wallet-password-confirm", PASSWORD);
|
|
||||||
await d.click("#btn-add-wallet-confirm");
|
|
||||||
// Argon2id under libsodium, for real, so this is the slow one.
|
|
||||||
await d.waitVisible("#view-main", STEP_TIMEOUT_MS);
|
|
||||||
|
|
||||||
assert(
|
|
||||||
env.phrase.split(/\s+/).length >= 12,
|
|
||||||
"wallet creation did not yield a recovery phrase",
|
|
||||||
);
|
|
||||||
const addrs = await d.count("#wallet-list .btn-addr-info");
|
|
||||||
assert(addrs > 0, "no addresses rendered in the wallet list");
|
|
||||||
});
|
|
||||||
|
|
||||||
step("add token screen opens from address detail", async (env) => {
|
|
||||||
const d = env.driver;
|
|
||||||
if (!(await d.isVisible("#view-address"))) {
|
|
||||||
await d.waitVisible("#view-main");
|
|
||||||
await d.click("#wallet-list .btn-addr-info");
|
|
||||||
}
|
|
||||||
await d.waitVisible("#view-address");
|
|
||||||
|
|
||||||
await d.click("#btn-add-token");
|
|
||||||
// Reported with the view it actually stayed on: a screen that does
|
|
||||||
// not change is the symptom a missing import produces, and naming
|
|
||||||
// the screen is what makes that diagnosable.
|
|
||||||
try {
|
|
||||||
await d.waitVisible("#view-add-token");
|
|
||||||
} catch (e) {
|
|
||||||
throw new Error(
|
|
||||||
e.message + "; current view is " + (await d.currentView()),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
const picks = await d.count("#common-token-list .common-token");
|
|
||||||
assert(picks > 0, "no common-token quick-pick buttons rendered");
|
|
||||||
});
|
|
||||||
|
|
||||||
// ------------------------------------------------------------- runner
|
|
||||||
|
|
||||||
function formatError(e) {
|
|
||||||
return (
|
|
||||||
e.msg + " (" + e.src + ":" + e.line + (e.cat ? ", " + e.cat : "") + ")"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async function main() {
|
|
||||||
// A suite that runs nothing must never report success.
|
|
||||||
if (steps.length === 0) {
|
|
||||||
console.log("1..0");
|
|
||||||
console.log("# FAILED: the Firefox e2e suite registered no steps");
|
|
||||||
process.exitCode = 1;
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const extDir = path.resolve(REPO_ROOT, process.argv[2] || "dist/firefox");
|
|
||||||
if (!fs.existsSync(path.join(extDir, "manifest.json"))) {
|
|
||||||
console.error(
|
|
||||||
"e2e-firefox: no unpacked build at " +
|
|
||||||
extDir +
|
|
||||||
" — run make build first",
|
|
||||||
);
|
|
||||||
process.exitCode = 1;
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
let driver;
|
|
||||||
try {
|
|
||||||
driver = await start();
|
|
||||||
await driver.newSession();
|
|
||||||
await driver.installAddon(extDir);
|
|
||||||
} catch (e) {
|
|
||||||
// A browser we cannot start is a failure of the suite, not an
|
|
||||||
// absent suite. Never skip and report success.
|
|
||||||
console.error("e2e-firefox: cannot run the suite: " + e.message);
|
|
||||||
if (driver) await driver.quit().catch(() => {});
|
|
||||||
process.exitCode = 1;
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const errors = new ConsoleErrors(driver, EXTENSION_ORIGIN);
|
|
||||||
const env = { driver, phrase: null };
|
|
||||||
|
|
||||||
console.log("# extension origin: " + EXTENSION_ORIGIN);
|
|
||||||
console.log("1.." + steps.length);
|
|
||||||
|
|
||||||
let failed = 0;
|
|
||||||
let n = 0;
|
|
||||||
try {
|
|
||||||
// Drain, never reset: anything the add-on logged while installing
|
|
||||||
// and starting its background page has no earlier step to belong
|
|
||||||
// to, so it is folded into step 1 below. Services.console.reset()
|
|
||||||
// here would DELETE it instead, and a background page that throws
|
|
||||||
// at the top of the file — a dead background page — would then
|
|
||||||
// produce a fully green run.
|
|
||||||
let installErrors = [];
|
|
||||||
let installFailure = null;
|
|
||||||
try {
|
|
||||||
installErrors = await errors.take();
|
|
||||||
} catch (e) {
|
|
||||||
installFailure =
|
|
||||||
"could not read the console after install: " + e.message;
|
|
||||||
}
|
|
||||||
|
|
||||||
for (const s of steps) {
|
|
||||||
n += 1;
|
|
||||||
let failure = null;
|
|
||||||
try {
|
|
||||||
await withTimeout(s.fn(env), s.name);
|
|
||||||
} catch (e) {
|
|
||||||
failure = e.message;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Let anything the step provoked reach the console service
|
|
||||||
// before draining it. Without this a failure logged on the
|
|
||||||
// way out of the step lands in the next step's drain, which
|
|
||||||
// still fails the run but blames the wrong step.
|
|
||||||
await sleep(500);
|
|
||||||
|
|
||||||
let found = [];
|
|
||||||
try {
|
|
||||||
found = await errors.take();
|
|
||||||
} catch (e) {
|
|
||||||
failure = failure || "could not read the console: " + e.message;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (n === 1) {
|
|
||||||
found = installErrors.concat(found);
|
|
||||||
installErrors = [];
|
|
||||||
failure = failure || installFailure;
|
|
||||||
installFailure = null;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Any uncaught error from an extension source fails the step
|
|
||||||
// that provoked it, whether or not its assertions passed.
|
|
||||||
if (!failure && found.length > 0) {
|
|
||||||
failure =
|
|
||||||
n === 1
|
|
||||||
? "uncaught extension errors during add-on install, " +
|
|
||||||
"background startup or this step"
|
|
||||||
: "uncaught extension errors during this step";
|
|
||||||
}
|
|
||||||
|
|
||||||
if (failure) {
|
|
||||||
failed += 1;
|
|
||||||
console.log("not ok " + n + " - " + s.name);
|
|
||||||
console.log(" " + failure);
|
|
||||||
for (const e of found) console.log(" " + formatError(e));
|
|
||||||
} else {
|
|
||||||
console.log("ok " + n + " - " + s.name);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// The tail: errors logged after the last step returned cannot be
|
|
||||||
// blamed on any one step, but they are still reported and they
|
|
||||||
// still fail the run.
|
|
||||||
await sleep(1000);
|
|
||||||
const trailing = await errors.take();
|
|
||||||
console.log(
|
|
||||||
"# " +
|
|
||||||
(steps.length - failed) +
|
|
||||||
"/" +
|
|
||||||
steps.length +
|
|
||||||
" steps passed",
|
|
||||||
);
|
|
||||||
if (trailing.length > 0) {
|
|
||||||
console.log(
|
|
||||||
"# " +
|
|
||||||
trailing.length +
|
|
||||||
" extension error(s) recorded after the last step, not " +
|
|
||||||
"attributable to any single step:",
|
|
||||||
);
|
|
||||||
for (const e of trailing) console.log("# " + formatError(e));
|
|
||||||
}
|
|
||||||
if (failed > 0 || trailing.length > 0) {
|
|
||||||
console.log("# FAILED");
|
|
||||||
process.exitCode = 1;
|
|
||||||
}
|
|
||||||
} finally {
|
|
||||||
await driver.quit().catch(() => {});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
main().catch((e) => {
|
|
||||||
console.error("e2e-firefox: " + (e && e.stack ? e.stack : e));
|
|
||||||
process.exitCode = 1;
|
|
||||||
});
|
|
||||||
@@ -23,8 +23,6 @@
|
|||||||
|
|
||||||
"use strict";
|
"use strict";
|
||||||
|
|
||||||
const { Transaction } = require("ethers");
|
|
||||||
|
|
||||||
// Fictional ERC-20 used to seed the transaction-detail test. The symbol
|
// Fictional ERC-20 used to seed the transaction-detail test. The symbol
|
||||||
// must not collide with any entry in src/shared/tokenList.js, or
|
// must not collide with any entry in src/shared/tokenList.js, or
|
||||||
// isSpoofedSymbol() in src/shared/transactions.js drops the transfer as a
|
// isSpoofedSymbol() in src/shared/transactions.js drops the transfer as a
|
||||||
@@ -64,87 +62,6 @@ function word(value) {
|
|||||||
return "0x" + BigInt(value).toString(16).padStart(64, "0");
|
return "0x" + BigInt(value).toString(16).padStart(64, "0");
|
||||||
}
|
}
|
||||||
|
|
||||||
// -------------------------------------------------------- dApp fixture
|
|
||||||
//
|
|
||||||
// The origin the EIP-1193 test page is served from, and the page itself.
|
|
||||||
//
|
|
||||||
// It is a fixture like every other one in this file: the route handler
|
|
||||||
// fulfils the navigation from the string below, so the page never comes
|
|
||||||
// from a remote origin and nothing about the dApp round trips leaves the
|
|
||||||
// container. `.test` is reserved by RFC 6761 and has no owner to reach in
|
|
||||||
// the first place; the launch arguments map every host to NOTFOUND anyway.
|
|
||||||
//
|
|
||||||
// What the page deliberately does NOT do is load a provider. window.ethereum
|
|
||||||
// is put there by the shipped manifest's MAIN-world content script, exactly
|
|
||||||
// as it is on any http(s) page a user visits, so what these tests speak to
|
|
||||||
// is the real inpage provider and not a copy the harness wired up.
|
|
||||||
const DAPP_ORIGIN = "https://dapp.e2e.test";
|
|
||||||
const DAPP_URL = DAPP_ORIGIN + "/";
|
|
||||||
|
|
||||||
// Requests are parked rather than awaited. An approval prompt only exists
|
|
||||||
// while its call is in flight, so a test that awaited the promise could
|
|
||||||
// never drive the popup that has to settle it; start() files the promise
|
|
||||||
// under a key and settle() collects it once the prompt has been dealt with.
|
|
||||||
//
|
|
||||||
// The rejection branch records the whole observable shape of the error as it
|
|
||||||
// arrives — name, message, and whether a `code` is present at all as distinct
|
|
||||||
// from its value. EIP-1193 says a user rejection is a ProviderRpcError
|
|
||||||
// carrying code 4001; what the page can actually see is recorded here rather
|
|
||||||
// than assumed, and asserted in run.js.
|
|
||||||
//
|
|
||||||
// The message log is the page's half of the boundary observation: every
|
|
||||||
// AUTISTMASK_* message that crosses between this page and the content
|
|
||||||
// script, in both directions, verbatim.
|
|
||||||
const DAPP_HTML = [
|
|
||||||
"<!doctype html>",
|
|
||||||
'<html lang="en">',
|
|
||||||
"<head>",
|
|
||||||
'<meta charset="utf-8">',
|
|
||||||
"<title>AutistMask e2e dApp</title>",
|
|
||||||
// Inline and empty: without it Chromium asks for /favicon.ico, which
|
|
||||||
// the unstubbed-request guard would report as escaping traffic.
|
|
||||||
'<link rel="icon" href="data:,">',
|
|
||||||
"</head>",
|
|
||||||
"<body>",
|
|
||||||
"<h1>AutistMask e2e dApp</h1>",
|
|
||||||
"<script>",
|
|
||||||
"window.__dapp = {",
|
|
||||||
" messages: [],",
|
|
||||||
" calls: {},",
|
|
||||||
" start: function (key, method, params) {",
|
|
||||||
" window.__dapp.calls[key] = window.ethereum",
|
|
||||||
" .request({ method: method, params: params })",
|
|
||||||
" .then(",
|
|
||||||
" function (result) {",
|
|
||||||
" return { settled: 'resolved', result: result };",
|
|
||||||
" },",
|
|
||||||
" function (error) {",
|
|
||||||
" return {",
|
|
||||||
" settled: 'rejected',",
|
|
||||||
" message: String((error && error.message) || error),",
|
|
||||||
" name: error ? error.name : undefined,",
|
|
||||||
" hasCode: !!error && 'code' in Object(error),",
|
|
||||||
" code: error ? error.code : undefined,",
|
|
||||||
" };",
|
|
||||||
" },",
|
|
||||||
" );",
|
|
||||||
" },",
|
|
||||||
" settle: function (key) {",
|
|
||||||
" return window.__dapp.calls[key];",
|
|
||||||
" },",
|
|
||||||
"};",
|
|
||||||
"window.addEventListener('message', function (event) {",
|
|
||||||
" if (event.source !== window) return;",
|
|
||||||
" var d = event.data;",
|
|
||||||
" if (!d || typeof d.type !== 'string') return;",
|
|
||||||
" if (d.type.indexOf('AUTISTMASK') !== 0) return;",
|
|
||||||
" window.__dapp.messages.push(d);",
|
|
||||||
"});",
|
|
||||||
"</script>",
|
|
||||||
"</body>",
|
|
||||||
"</html>",
|
|
||||||
].join("\n");
|
|
||||||
|
|
||||||
// ------------------------------------------------------------ fee fixture
|
// ------------------------------------------------------------ fee fixture
|
||||||
//
|
//
|
||||||
// The confirmation screen carries two different numbers for the same
|
// The confirmation screen carries two different numbers for the same
|
||||||
@@ -184,11 +101,6 @@ const RPC_RESULTS = {
|
|||||||
eth_estimateGas: hex(GAS_LIMIT),
|
eth_estimateGas: hex(GAS_LIMIT),
|
||||||
eth_getTransactionCount: "0x0",
|
eth_getTransactionCount: "0x0",
|
||||||
eth_maxPriorityFeePerGas: hex(PRIORITY_FEE_WEI),
|
eth_maxPriorityFeePerGas: hex(PRIORITY_FEE_WEI),
|
||||||
// "not mined yet", which is what a node answers for a transaction it has
|
|
||||||
// only just accepted. The wait screen the dApp transaction approval hands
|
|
||||||
// off to polls this every 10 seconds; leaving it unstubbed would report
|
|
||||||
// the poll as escaping traffic the moment a test outlived one tick.
|
|
||||||
eth_getTransactionReceipt: null,
|
|
||||||
};
|
};
|
||||||
|
|
||||||
// The "latest" block, which ethers' getFeeData() reads baseFeePerGas from
|
// The "latest" block, which ethers' getFeeData() reads baseFeePerGas from
|
||||||
@@ -352,31 +264,6 @@ function rpcReply(req, opts, report) {
|
|||||||
if (req.method === "eth_getBlockByNumber") {
|
if (req.method === "eth_getBlockByNumber") {
|
||||||
return Object.assign(envelope, { result: latestBlock() });
|
return Object.assign(envelope, { result: latestBlock() });
|
||||||
}
|
}
|
||||||
// The end of the dApp transaction round trip: the raw signed transaction
|
|
||||||
// the background hands to the node. It is recorded verbatim so a test can
|
|
||||||
// recover the signer from the exact bytes that were broadcast, rather than
|
|
||||||
// from anything the extension reported about them.
|
|
||||||
//
|
|
||||||
// The reply must be the transaction's real hash. ethers compares the hash
|
|
||||||
// the node returns against the one it computes itself and throws on a
|
|
||||||
// mismatch, so a constant here would fail the broadcast for a reason that
|
|
||||||
// has nothing to do with what is being tested.
|
|
||||||
if (req.method === "eth_sendRawTransaction") {
|
|
||||||
const raw = Array.isArray(req.params) ? req.params[0] : null;
|
|
||||||
let parsed;
|
|
||||||
try {
|
|
||||||
parsed = Transaction.from(raw);
|
|
||||||
} catch {
|
|
||||||
report("eth_sendRawTransaction with an undecodable transaction");
|
|
||||||
return Object.assign(envelope, {
|
|
||||||
error: { code: -32000, message: "undecodable transaction" },
|
|
||||||
});
|
|
||||||
}
|
|
||||||
if (Array.isArray(opts.broadcastTransactions)) {
|
|
||||||
opts.broadcastTransactions.push(raw);
|
|
||||||
}
|
|
||||||
return Object.assign(envelope, { result: parsed.hash });
|
|
||||||
}
|
|
||||||
if (req.method === "eth_estimateGas" && opts.failGasEstimate) {
|
if (req.method === "eth_estimateGas" && opts.failGasEstimate) {
|
||||||
// A refusal the node itself would produce, not a transport error:
|
// A refusal the node itself would produce, not a transport error:
|
||||||
// this is the shape the confirmation screen has to turn into
|
// this is the shape the confirmation screen has to turn into
|
||||||
@@ -488,8 +375,6 @@ function traceEnabled(raw) {
|
|||||||
* node-side refusal.
|
* node-side refusal.
|
||||||
* @param {boolean} [opts.holdGasEstimate] hold every batch containing an
|
* @param {boolean} [opts.holdGasEstimate] hold every batch containing an
|
||||||
* eth_estimateGas until this is cleared again.
|
* eth_estimateGas until this is cleared again.
|
||||||
* @param {string[]} [opts.broadcastTransactions] every raw signed
|
|
||||||
* transaction handed to eth_sendRawTransaction, appended in order.
|
|
||||||
* @returns {Promise<{waitForServiceWorkerTraffic: (ms: number) =>
|
* @returns {Promise<{waitForServiceWorkerTraffic: (ms: number) =>
|
||||||
* Promise<string|null>}>}
|
* Promise<string|null>}>}
|
||||||
*/
|
*/
|
||||||
@@ -535,18 +420,6 @@ async function installNetworkStubs(ctx, opts) {
|
|||||||
return handleRpc(route, req.postData(), opts, report);
|
return handleRpc(route, req.postData(), opts, report);
|
||||||
}
|
}
|
||||||
|
|
||||||
// The local EIP-1193 test page. Served from here so the dApp round
|
|
||||||
// trips run against a real http(s) origin — which is what makes the
|
|
||||||
// shipped content scripts inject at all — without any remote origin
|
|
||||||
// being involved.
|
|
||||||
if (url.origin === DAPP_ORIGIN && p === "/") {
|
|
||||||
return route.fulfill({
|
|
||||||
status: 200,
|
|
||||||
contentType: "text/html; charset=utf-8",
|
|
||||||
body: DAPP_HTML,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
// Blockscout v2
|
// Blockscout v2
|
||||||
if (p.includes("/api/v2/")) {
|
if (p.includes("/api/v2/")) {
|
||||||
if (/\/addresses\/0x[0-9a-fA-F]{40}\/transactions$/.test(p)) {
|
if (/\/addresses\/0x[0-9a-fA-F]{40}\/transactions$/.test(p)) {
|
||||||
@@ -635,8 +508,6 @@ async function installNetworkStubs(ctx, opts) {
|
|||||||
|
|
||||||
module.exports = {
|
module.exports = {
|
||||||
installNetworkStubs,
|
installNetworkStubs,
|
||||||
DAPP_ORIGIN,
|
|
||||||
DAPP_URL,
|
|
||||||
FEE_ESTIMATE_WEI,
|
FEE_ESTIMATE_WEI,
|
||||||
FEE_RESERVE_WEI,
|
FEE_RESERVE_WEI,
|
||||||
STUB_COUNTERPARTY,
|
STUB_COUNTERPARTY,
|
||||||
|
|||||||
1002
tests/e2e/run.js
1002
tests/e2e/run.js
File diff suppressed because it is too large
Load Diff
@@ -1,310 +0,0 @@
|
|||||||
// The EIP-1193 error the page actually catches (src/content/inpage.js).
|
|
||||||
//
|
|
||||||
// The bug this pins down (issue #274): the provider rebuilt every failure as
|
|
||||||
// `new Error(error.message)`, so the `code` the background produced and the
|
|
||||||
// content script relayed intact was thrown away in the last hop. A dApp
|
|
||||||
// checking `err.code === 4001` — the standard way to tell "the user said no"
|
|
||||||
// from "the wallet broke" — saw undefined, and well-behaved sites showed an
|
|
||||||
// error or retried instead of accepting the refusal.
|
|
||||||
//
|
|
||||||
// inpage.js is a bare IIFE injected into the page's JS context, not a module:
|
|
||||||
// it takes no import and exports nothing, and reaches for `window` at load.
|
|
||||||
// So it is evaluated here the way the browser evaluates it, against a stub
|
|
||||||
// window, and the provider is collected from `window.ethereum`. The globals it
|
|
||||||
// touches are passed in as function parameters rather than assigned to
|
|
||||||
// globalThis: nothing leaks between tests, and the source is compiled in this
|
|
||||||
// realm, so the errors it constructs are comparable against this file's own
|
|
||||||
// `Error` — which a second realm's intrinsics would silently defeat.
|
|
||||||
//
|
|
||||||
// There is no jsdom in this repo; see tests/txStatus.test.js.
|
|
||||||
|
|
||||||
const fs = require("fs");
|
|
||||||
const path = require("path");
|
|
||||||
const { webcrypto } = require("crypto");
|
|
||||||
|
|
||||||
const SOURCE = fs.readFileSync(
|
|
||||||
path.join(__dirname, "..", "src", "content", "inpage.js"),
|
|
||||||
"utf8",
|
|
||||||
);
|
|
||||||
|
|
||||||
const loadInto = new Function(
|
|
||||||
"window",
|
|
||||||
"self",
|
|
||||||
"crypto",
|
|
||||||
"Event",
|
|
||||||
"CustomEvent",
|
|
||||||
SOURCE,
|
|
||||||
);
|
|
||||||
|
|
||||||
class StubEvent {
|
|
||||||
constructor(type) {
|
|
||||||
this.type = type;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
class StubCustomEvent extends StubEvent {
|
|
||||||
constructor(type, init) {
|
|
||||||
super(type);
|
|
||||||
this.detail = init && init.detail;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Every code the background emits on the RPC path today, read out of
|
|
||||||
// src/background/index.js. The provider must not know this list — it passes
|
|
||||||
// through whatever arrived — but the cases below are the real ones.
|
|
||||||
const REJECTED = 4001; // user rejected the request
|
|
||||||
const UNAUTHORIZED = 4100; // site not connected / wrong address
|
|
||||||
const UNRECOGNIZED_CHAIN = 4902; // switch/add to an unsupported chain
|
|
||||||
|
|
||||||
// A stub window with the four things inpage.js touches: message listeners,
|
|
||||||
// postMessage out to the content script, window.ethereum, and dispatchEvent
|
|
||||||
// for the EIP-6963 announcement.
|
|
||||||
function loadProvider() {
|
|
||||||
const messageListeners = [];
|
|
||||||
const posted = [];
|
|
||||||
|
|
||||||
const win = {
|
|
||||||
addEventListener(type, fn) {
|
|
||||||
if (type === "message") messageListeners.push(fn);
|
|
||||||
},
|
|
||||||
removeEventListener(type, fn) {
|
|
||||||
const i = messageListeners.indexOf(fn);
|
|
||||||
if (type === "message" && i !== -1) messageListeners.splice(i, 1);
|
|
||||||
},
|
|
||||||
postMessage(data) {
|
|
||||||
posted.push(data);
|
|
||||||
},
|
|
||||||
dispatchEvent() {
|
|
||||||
return true;
|
|
||||||
},
|
|
||||||
};
|
|
||||||
win.window = win;
|
|
||||||
|
|
||||||
loadInto(win, win, webcrypto, StubEvent, StubCustomEvent);
|
|
||||||
|
|
||||||
// Deliver the content script's answer to an outstanding request. The id is
|
|
||||||
// read back off the wire rather than assumed: inpage.js issues its own
|
|
||||||
// eth_chainId at load, so the first id a test sees is not 1.
|
|
||||||
function respond(response) {
|
|
||||||
const request = posted
|
|
||||||
.filter((m) => m.type === "AUTISTMASK_REQUEST")
|
|
||||||
.pop();
|
|
||||||
expect(request).toBeDefined();
|
|
||||||
const event = {
|
|
||||||
source: win,
|
|
||||||
data: { type: "AUTISTMASK_RESPONSE", id: request.id, ...response },
|
|
||||||
};
|
|
||||||
for (const fn of messageListeners.slice()) fn(event);
|
|
||||||
}
|
|
||||||
|
|
||||||
return { provider: win.ethereum, posted, respond };
|
|
||||||
}
|
|
||||||
|
|
||||||
// Start a request, answer it with `response`, and hand back the rejection.
|
|
||||||
// Fails the test if the call resolves instead.
|
|
||||||
async function rejectionFrom(start, response) {
|
|
||||||
const { provider, respond } = loadProvider();
|
|
||||||
const settled = start(provider).then(
|
|
||||||
(result) => ({ resolved: result }),
|
|
||||||
(error) => ({ error }),
|
|
||||||
);
|
|
||||||
// The provider posts synchronously, so the request is already on the wire.
|
|
||||||
respond(response);
|
|
||||||
const outcome = await settled;
|
|
||||||
expect(outcome).not.toHaveProperty("resolved");
|
|
||||||
return outcome.error;
|
|
||||||
}
|
|
||||||
|
|
||||||
describe("an EIP-1193 code reaches the page", () => {
|
|
||||||
test("a user rejection arrives as code 4001", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_requestAccounts" }),
|
|
||||||
{
|
|
||||||
error: {
|
|
||||||
code: REJECTED,
|
|
||||||
message: "User rejected the request.",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(REJECTED);
|
|
||||||
expect(err.message).toBe("User rejected the request.");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("it is a ProviderRpcError, and an Error", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_requestAccounts" }),
|
|
||||||
{
|
|
||||||
error: {
|
|
||||||
code: REJECTED,
|
|
||||||
message: "User rejected the request.",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
);
|
|
||||||
expect(err).toBeInstanceOf(Error);
|
|
||||||
expect(err.name).toBe("ProviderRpcError");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("4100 unauthorized arrives intact", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "personal_sign", params: ["0x00"] }),
|
|
||||||
{ error: { code: UNAUTHORIZED, message: "Unauthorized" } },
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(UNAUTHORIZED);
|
|
||||||
expect(err.message).toBe("Unauthorized");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("4902 unrecognized chain arrives intact", async () => {
|
|
||||||
const message =
|
|
||||||
"AutistMask supports Ethereum Mainnet and Sepolia Testnet only.";
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "wallet_switchEthereumChain" }),
|
|
||||||
{ error: { code: UNRECOGNIZED_CHAIN, message } },
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(UNRECOGNIZED_CHAIN);
|
|
||||||
expect(err.message).toBe(message);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The provider is not allowed to know the list above: a code added to the
|
|
||||||
// background later must reach the page without this file being edited.
|
|
||||||
test("a code the provider has never heard of is passed through", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_accounts" }),
|
|
||||||
{ error: { code: 4900, message: "Disconnected" } },
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(4900);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("data is carried when the boundary sent it", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_call" }),
|
|
||||||
{
|
|
||||||
error: {
|
|
||||||
code: -32000,
|
|
||||||
message: "execution reverted",
|
|
||||||
data: "0x08c379a0",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(-32000);
|
|
||||||
expect(err.data).toBe("0x08c379a0");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("no data property is invented when the boundary sent none", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_requestAccounts" }),
|
|
||||||
{
|
|
||||||
error: {
|
|
||||||
code: REJECTED,
|
|
||||||
message: "User rejected the request.",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
);
|
|
||||||
expect("data" in err).toBe(false);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("the message is untouched", () => {
|
|
||||||
test("a coded error keeps the message byte for byte", async () => {
|
|
||||||
const message =
|
|
||||||
"This site asked to sign as an address that is not " +
|
|
||||||
"the active one.";
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "personal_sign" }),
|
|
||||||
{ error: { code: UNAUTHORIZED, message } },
|
|
||||||
);
|
|
||||||
expect(err.message).toBe(message);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("an error the background sent with no code keeps its message", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_sendTransaction" }),
|
|
||||||
{ error: { message: "No accounts available" } },
|
|
||||||
);
|
|
||||||
expect(err.message).toBe("No accounts available");
|
|
||||||
});
|
|
||||||
|
|
||||||
// A ProviderRpcError whose code is undefined would claim a conformance it
|
|
||||||
// does not have, and `'code' in err` is exactly what a careful dApp asks.
|
|
||||||
test("an error with no code gets no code property at all", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_sendTransaction" }),
|
|
||||||
{ error: { message: "No accounts available" } },
|
|
||||||
);
|
|
||||||
expect(err).toBeInstanceOf(Error);
|
|
||||||
expect("code" in err).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("an error with no message keeps the generic fallback", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_sendTransaction" }),
|
|
||||||
{ error: { code: REJECTED } },
|
|
||||||
);
|
|
||||||
expect(err.message).toBe("Request failed");
|
|
||||||
expect(err.code).toBe(REJECTED);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
// Every entry point the provider exposes, not just eth_requestAccounts. They
|
|
||||||
// all funnel through the same response listener, and this is what says so.
|
|
||||||
describe("every request path carries the code", () => {
|
|
||||||
const rejection = {
|
|
||||||
error: { code: REJECTED, message: "User rejected the request." },
|
|
||||||
};
|
|
||||||
|
|
||||||
test("request()", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.request({ method: "eth_requestAccounts" }),
|
|
||||||
rejection,
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(REJECTED);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("enable()", async () => {
|
|
||||||
const err = await rejectionFrom((p) => p.enable(), rejection);
|
|
||||||
expect(err.code).toBe(REJECTED);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("send(method, params)", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.send("eth_requestAccounts", []),
|
|
||||||
rejection,
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(REJECTED);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("send({ method, params })", async () => {
|
|
||||||
const err = await rejectionFrom(
|
|
||||||
(p) => p.send({ method: "personal_sign", params: ["0x00"] }),
|
|
||||||
rejection,
|
|
||||||
);
|
|
||||||
expect(err.code).toBe(REJECTED);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("sendAsync() hands the code to its callback", async () => {
|
|
||||||
const { provider, respond } = loadProvider();
|
|
||||||
const called = new Promise((resolve) => {
|
|
||||||
provider.sendAsync({ id: 1, method: "eth_requestAccounts" }, (e) =>
|
|
||||||
resolve(e),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
respond(rejection);
|
|
||||||
const err = await called;
|
|
||||||
expect(err.name).toBe("ProviderRpcError");
|
|
||||||
expect(err.code).toBe(REJECTED);
|
|
||||||
expect(err.message).toBe("User rejected the request.");
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("the success path is unchanged", () => {
|
|
||||||
test("a result still resolves", async () => {
|
|
||||||
const { provider, respond } = loadProvider();
|
|
||||||
const settled = provider.request({ method: "eth_requestAccounts" });
|
|
||||||
respond({ result: ["0xb61264DEFB0c4B8afb3D73724be15310036743a5"] });
|
|
||||||
await expect(settled).resolves.toEqual([
|
|
||||||
"0xb61264DEFB0c4B8afb3D73724be15310036743a5",
|
|
||||||
]);
|
|
||||||
expect(provider.selectedAddress).toBe(
|
|
||||||
"0xb61264DEFB0c4B8afb3D73724be15310036743a5",
|
|
||||||
);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@@ -56,7 +56,7 @@ global.chrome = {
|
|||||||
};
|
};
|
||||||
|
|
||||||
const { isSpoofedSymbol } = require("../src/shared/symbolSpoof");
|
const { isSpoofedSymbol } = require("../src/shared/symbolSpoof");
|
||||||
const { TOKENS, KNOWN_SYMBOLS } = require("../src/shared/tokenList");
|
const { KNOWN_SYMBOLS } = require("../src/shared/tokenList");
|
||||||
const { filterTransactions } = require("../src/shared/transactions");
|
const { filterTransactions } = require("../src/shared/transactions");
|
||||||
const {
|
const {
|
||||||
fetchTokenBalances,
|
fetchTokenBalances,
|
||||||
@@ -124,301 +124,6 @@ describe("the shared rule", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
// Issue #260: the symbol is whatever the ERC-20 contract returns, and HTML
|
|
||||||
// collapses leading and trailing whitespace, so a token calling itself
|
|
||||||
// `" ETH "` reaches the user's eye as `ETH` while missing a raw
|
|
||||||
// KNOWN_SYMBOLS lookup. Normalizing inside the shared rule fixes all three
|
|
||||||
// surfaces at once, which is what consolidating the rule bought.
|
|
||||||
//
|
|
||||||
// Every character under test here is built from its code point rather than
|
|
||||||
// pasted in: most of them are invisible, and an invisible character in a
|
|
||||||
// test file is unreviewable.
|
|
||||||
const cp = (...codes) => String.fromCodePoint(...codes);
|
|
||||||
const NBSP = cp(0x00a0); // no-break space
|
|
||||||
const FIGURE_SPACE = cp(0x2007);
|
|
||||||
const IDEOGRAPHIC_SPACE = cp(0x3000);
|
|
||||||
const ZWSP = cp(0x200b); // zero-width space
|
|
||||||
const BOM = cp(0xfeff); // zero-width no-break space
|
|
||||||
const WORD_JOINER = cp(0x2060);
|
|
||||||
const SOFT_HYPHEN = cp(0x00ad);
|
|
||||||
const LRM = cp(0x200e); // left-to-right mark
|
|
||||||
const RLO = cp(0x202e); // right-to-left override
|
|
||||||
const HANGUL_FILLER = cp(0x3164);
|
|
||||||
const CHOSEONG_FILLER = cp(0x115f);
|
|
||||||
const VS16 = cp(0xfe0f); // variation selector-16
|
|
||||||
const VS1 = cp(0xfe00); // variation selector-1
|
|
||||||
const NEL = cp(0x0085); // next line, a C1 control
|
|
||||||
const DEL = cp(0x007f);
|
|
||||||
const FULLWIDTH_ETH = cp(0xff25, 0xff34, 0xff28);
|
|
||||||
const FULLWIDTH_USDC = cp(0xff55, 0xff53, 0xff44, 0xff43); // lowercase
|
|
||||||
const CYRILLIC_CAPITAL_IE = cp(0x0415);
|
|
||||||
|
|
||||||
describe("the shared rule: symbols that render as a known symbol", () => {
|
|
||||||
test("ASCII padding does not buy a pass", () => {
|
|
||||||
expect(isSpoofedSymbol(" ETH ", FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
expect(isSpoofedSymbol("\tETH\n", FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
expect(isSpoofedSymbol(" usdc ", FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("non-breaking and other Unicode spaces do not either", () => {
|
|
||||||
expect(isSpoofedSymbol(NBSP + "ETH" + NBSP, FAKE_ETH_CONTRACT)).toBe(
|
|
||||||
true,
|
|
||||||
);
|
|
||||||
expect(
|
|
||||||
isSpoofedSymbol(
|
|
||||||
FIGURE_SPACE + "ETH" + IDEOGRAPHIC_SPACE,
|
|
||||||
FAKE_ETH_CONTRACT,
|
|
||||||
),
|
|
||||||
).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
// These render as nothing at all, in any position, so they are removed
|
|
||||||
// wherever they sit rather than only at the ends.
|
|
||||||
test("zero-width characters are stripped wherever they sit", () => {
|
|
||||||
expect(isSpoofedSymbol("E" + ZWSP + "TH", FAKE_ETH_CONTRACT)).toBe(
|
|
||||||
true,
|
|
||||||
);
|
|
||||||
expect(isSpoofedSymbol(BOM + "ETH", FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
expect(
|
|
||||||
isSpoofedSymbol("ET" + WORD_JOINER + "H", FAKE_ETH_CONTRACT),
|
|
||||||
).toBe(true);
|
|
||||||
expect(
|
|
||||||
isSpoofedSymbol("E" + SOFT_HYPHEN + "TH", FAKE_ETH_CONTRACT),
|
|
||||||
).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
// An LRM is invisible and, in all-Latin text, moves nothing: dropping it
|
|
||||||
// leaves exactly the string the user saw.
|
|
||||||
test("an invisible bidi mark does not hide a known symbol", () => {
|
|
||||||
expect(isSpoofedSymbol(LRM + "ETH", FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
// Invisibility is not confined to \p{Cf}. A Hangul filler is Lo and a
|
|
||||||
// variation selector is Mn, yet each of these four measures 32.00px in
|
|
||||||
// the repo's pinned e2e Chromium at 16px sans-serif — exactly the width
|
|
||||||
// of a plain `ETH` — so each reaches the user's eye as `ETH`. They are
|
|
||||||
// caught by \p{Default_Ignorable_Code_Point}, not by \p{Cf}.
|
|
||||||
test("invisible non-format characters are stripped too", () => {
|
|
||||||
expect(isSpoofedSymbol(HANGUL_FILLER + "ETH", FAKE_ETH_CONTRACT)).toBe(
|
|
||||||
true,
|
|
||||||
);
|
|
||||||
expect(
|
|
||||||
isSpoofedSymbol(CHOSEONG_FILLER + "ETH", FAKE_ETH_CONTRACT),
|
|
||||||
).toBe(true);
|
|
||||||
expect(isSpoofedSymbol("ETH" + VS16, FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
expect(isSpoofedSymbol("E" + VS1 + "TH", FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
// Nor is it confined to the Unicode classes. U+007F is a control (Cc)
|
|
||||||
// and is not default-ignorable, so neither class reaches it, but it
|
|
||||||
// measures 32.00px in the same browser — it paints nothing, so a
|
|
||||||
// symbol carrying it reaches the eye as `ETH`. It is named on its own
|
|
||||||
// in the strip for exactly that reason.
|
|
||||||
test("U+007F paints nothing and is stripped", () => {
|
|
||||||
expect(isSpoofedSymbol(DEL + "ETH", FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The other side of the boundary, which is not the class boundary but
|
|
||||||
// the visibility one: the remaining C0 and C1 controls render as a
|
|
||||||
// visible 48.00px box in the same browser, so a symbol carrying one
|
|
||||||
// does not look like `ETH` and must not be judged a spoof. Widening
|
|
||||||
// the strip to \p{Cc} — the obvious over-correction once U+007F is in
|
|
||||||
// it — fails this test.
|
|
||||||
test("visible control characters do not make a symbol a spoof", () => {
|
|
||||||
expect(isSpoofedSymbol(NEL + "ETH", FAKE_ETH_CONTRACT)).toBe(false);
|
|
||||||
expect(isSpoofedSymbol(cp(0x0001) + "ETH", FAKE_ETH_CONTRACT)).toBe(
|
|
||||||
false,
|
|
||||||
);
|
|
||||||
expect(isSpoofedSymbol(cp(0x0090) + "ETH", FAKE_ETH_CONTRACT)).toBe(
|
|
||||||
false,
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("compatibility forms fold onto the symbol they imitate", () => {
|
|
||||||
expect(isSpoofedSymbol(FULLWIDTH_ETH, FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
expect(isSpoofedSymbol(FULLWIDTH_USDC, FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The two knowingly open classes, asserted here so that the boundary is
|
|
||||||
// a fact in the suite and not a claim in a PR body. A Cyrillic capital
|
|
||||||
// Ie is a distinct letter rather than a compatibility variant, so NFKC
|
|
||||||
// leaves it alone; and a right-to-left override reverses the rendering
|
|
||||||
// of what follows it, which dropping the control character does not
|
|
||||||
// undo. Closing either needs a confusables table or a bidi resolver,
|
|
||||||
// and both are a separate change from this one.
|
|
||||||
test("a Cyrillic homoglyph is knowingly still not caught", () => {
|
|
||||||
expect(
|
|
||||||
isSpoofedSymbol(CYRILLIC_CAPITAL_IE + "TH", FAKE_ETH_CONTRACT),
|
|
||||||
).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a bidi-reordered symbol is knowingly still not caught", () => {
|
|
||||||
expect(isSpoofedSymbol(RLO + "HTE", FAKE_ETH_CONTRACT)).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
// Normalization does not reach the native-asset exemption, which turns
|
|
||||||
// on the absence of a contract address and never on the symbol.
|
|
||||||
test("a padded symbol with no contract is still not a spoof", () => {
|
|
||||||
expect(isSpoofedSymbol(" ETH ", null)).toBe(false);
|
|
||||||
expect(isSpoofedSymbol(NBSP + "ETH", "")).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a genuine contract still bears its own padded symbol", () => {
|
|
||||||
expect(isSpoofedSymbol(" USDC ", USDC_CONTRACT)).toBe(false);
|
|
||||||
expect(isSpoofedSymbol(ZWSP + "WETH", WETH_CONTRACT)).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
// Normalization must not invent a match. Interior ASCII whitespace is
|
|
||||||
// left alone: `E T H` renders as `E T H`, not as `ETH`, so folding it
|
|
||||||
// would filter a token no user could confuse with the native asset.
|
|
||||||
test("a symbol that renders differently is not judged a spoof", () => {
|
|
||||||
expect(isSpoofedSymbol("E T H", FAKE_ETH_CONTRACT)).toBe(false);
|
|
||||||
expect(isSpoofedSymbol("ETH2", FAKE_ETH_CONTRACT)).toBe(false);
|
|
||||||
expect(isSpoofedSymbol("MY ETH", FAKE_ETH_CONTRACT)).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The false-positive question, answered against the shipped data rather
|
|
||||||
// than by assertion: no bundled symbol carries whitespace or a
|
|
||||||
// non-ASCII character, so the normalization cannot newly filter one.
|
|
||||||
// The character class starts at `!` rather than at the space so that it
|
|
||||||
// asserts the claim it stands for — `[ -~]` would admit an interior
|
|
||||||
// space and let a whitespace-bearing entry through the guard.
|
|
||||||
test("no bundled symbol is touched by the normalization", () => {
|
|
||||||
for (const [symbol, addresses] of KNOWN_SYMBOLS) {
|
|
||||||
expect(symbol).toBe(symbol.trim());
|
|
||||||
expect(symbol).toMatch(/^[!-~]+$/);
|
|
||||||
if (addresses === null) continue;
|
|
||||||
for (const address of addresses) {
|
|
||||||
expect(isSpoofedSymbol(symbol, address)).toBe(false);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
// Issue #276: the guard that was missing. The suite walked KNOWN_SYMBOLS,
|
|
||||||
// which is built from TOKENS, so it could only ever assert that the table
|
|
||||||
// agrees with itself. Seven symbols appear twice in the bundled list at two
|
|
||||||
// different real contracts, and the table kept whichever came first, so the
|
|
||||||
// other seven contracts — tokens in our own shipped list, at their own
|
|
||||||
// addresses — were judged spoofs and hidden from the balance list, the
|
|
||||||
// history and the send selector. That is the over-filtering direction: it
|
|
||||||
// hides a holding the user cannot then spend.
|
|
||||||
//
|
|
||||||
// This walk is over TOKENS, the data the wallet actually ships, so it fails
|
|
||||||
// whenever a bundled token would be filtered at its own address no matter
|
|
||||||
// which side of the table the mistake is on.
|
|
||||||
describe("the shipped token list", () => {
|
|
||||||
test("no bundled token is filtered at its own address", () => {
|
|
||||||
const filtered = TOKENS.filter((t) =>
|
|
||||||
isSpoofedSymbol(t.symbol, t.address),
|
|
||||||
).map((t) => t.symbol + " @ " + t.address);
|
|
||||||
expect(filtered).toEqual([]);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The third failure mode the issue asks about: a symbol whose table entry
|
|
||||||
// names an address that is in neither the table nor the list would be a
|
|
||||||
// contract we vouch for and do not ship. There is none, and the table is
|
|
||||||
// built from the list, so this asserts the derivation has not acquired a
|
|
||||||
// hand-written entry.
|
|
||||||
test("every address the table vouches for is a bundled token", () => {
|
|
||||||
const bundled = new Set(TOKENS.map((t) => t.address.toLowerCase()));
|
|
||||||
for (const [symbol, addresses] of KNOWN_SYMBOLS) {
|
|
||||||
if (addresses === null) continue;
|
|
||||||
expect(addresses.size).toBeGreaterThan(0);
|
|
||||||
for (const address of addresses) {
|
|
||||||
expect(address).toBe(address.toLowerCase());
|
|
||||||
expect(bundled.has(address)).toBe(true);
|
|
||||||
// And it is the token that actually reports that symbol.
|
|
||||||
const token = TOKENS.find(
|
|
||||||
(t) => t.address.toLowerCase() === address,
|
|
||||||
);
|
|
||||||
expect(token.symbol.toUpperCase()).toBe(symbol);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
// Both contracts behind a shared ticker must pass, from either side: a
|
|
||||||
// rule that admits only the one the table happens to visit first is the
|
|
||||||
// bug, not the fix.
|
|
||||||
test("both contracts behind a shared ticker are admitted", () => {
|
|
||||||
const bySymbol = new Map();
|
|
||||||
for (const t of TOKENS) {
|
|
||||||
const upper = t.symbol.toUpperCase();
|
|
||||||
if (!bySymbol.has(upper)) bySymbol.set(upper, []);
|
|
||||||
bySymbol.get(upper).push(t);
|
|
||||||
}
|
|
||||||
const shared = [...bySymbol].filter(([, list]) => list.length > 1);
|
|
||||||
// The shared tickers are a fact about the shipped data; if a future
|
|
||||||
// list has none, this test would silently assert nothing.
|
|
||||||
expect(shared.length).toBeGreaterThan(0);
|
|
||||||
for (const [, list] of shared) {
|
|
||||||
for (const t of list) {
|
|
||||||
expect(isSpoofedSymbol(t.symbol, t.address)).toBe(false);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
// The seven from issue #276, named so that the reconciliation is a fact
|
|
||||||
// in the suite: each is two real contracts from the same source fetch,
|
|
||||||
// and the table now holds both rather than the one that came first.
|
|
||||||
test("the seven shared tickers each name both bundled contracts", () => {
|
|
||||||
const expected = {
|
|
||||||
TON: [
|
|
||||||
"0x582d872a1b094fc48f5de31d3b73f2d9be47def1", // Toncoin
|
|
||||||
"0x2be5e8c109e2197d077d13a82daead6a9b3433c5", // Tokamak Network
|
|
||||||
],
|
|
||||||
FRAX: [
|
|
||||||
"0x853d955acef822db058eb8505911ed77f175b99e", // Legacy Frax Dollar
|
|
||||||
"0x3432b6a60d23ca0dfca7761b7ab56459d9c964d0", // Frax (prev. FXS)
|
|
||||||
],
|
|
||||||
REUSD: [
|
|
||||||
"0x5086bf358635b81d8c47c66d1c8b9e567db70c72", // Re Protocol reUSD
|
|
||||||
"0x57ab1e0003f623289cd798b1824be09a793e4bec", // Resupply USD
|
|
||||||
],
|
|
||||||
EURE: [
|
|
||||||
"0x39b8b6385416f4ca36a20319f70d28621895279d", // Monerium EUR emoney
|
|
||||||
"0x3231cb76718cdef2155fc47b5286d82e6eda273f", // Monerium EUR emoney [OLD]
|
|
||||||
],
|
|
||||||
MSUSD: [
|
|
||||||
"0x4ba01f22827018b4772cd326c7627fb4956a7c00", // Main Street USD
|
|
||||||
"0xab5eb14c09d416f0ac63661e57edb7aecdb9befa", // Metronome Synth USD
|
|
||||||
],
|
|
||||||
MUSD: [
|
|
||||||
"0xaca92e438df0b2401ff60da7e4337b687a2435da", // MetaMask USD
|
|
||||||
"0xdd468a1ddc392dcdbef6db6e34e89aa338f9f186", // Mezo USD
|
|
||||||
],
|
|
||||||
JPYC: [
|
|
||||||
"0x431d5dff03120afa4bdf332c61a6e1766ef37bdb", // JPY Coin
|
|
||||||
"0x2370f9d504c7a6e775bf6e14b3f12846b594cd53", // JPY Coin v1
|
|
||||||
],
|
|
||||||
};
|
|
||||||
for (const [symbol, addresses] of Object.entries(expected)) {
|
|
||||||
expect([...KNOWN_SYMBOLS.get(symbol)].sort()).toEqual(
|
|
||||||
[...addresses].sort(),
|
|
||||||
);
|
|
||||||
for (const address of addresses) {
|
|
||||||
expect(isSpoofedSymbol(symbol, address)).toBe(false);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
// The other direction, on the same symbols: widening the table to hold
|
|
||||||
// every bundled address for a ticker must not turn it into a pass for
|
|
||||||
// any other contract.
|
|
||||||
test("a shared ticker from a third contract is still a spoof", () => {
|
|
||||||
const bySymbol = new Map();
|
|
||||||
for (const t of TOKENS) {
|
|
||||||
const upper = t.symbol.toUpperCase();
|
|
||||||
if (!bySymbol.has(upper)) bySymbol.set(upper, []);
|
|
||||||
bySymbol.get(upper).push(t);
|
|
||||||
}
|
|
||||||
for (const [symbol, list] of bySymbol) {
|
|
||||||
if (list.length < 2) continue;
|
|
||||||
expect(isSpoofedSymbol(symbol, FAKE_ETH_CONTRACT)).toBe(true);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("surface 1: the transaction history", () => {
|
describe("surface 1: the transaction history", () => {
|
||||||
function fakeEthTransfer() {
|
function fakeEthTransfer() {
|
||||||
return {
|
return {
|
||||||
@@ -442,22 +147,6 @@ describe("surface 1: the transaction history", () => {
|
|||||||
expect(result.transactions).toEqual([]);
|
expect(result.transactions).toEqual([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Issue #260 on this surface: the same transfer with a padded symbol.
|
|
||||||
test("a padded fake ETH token transfer is filtered too", () => {
|
|
||||||
const padded = { ...fakeEthTransfer(), symbol: " ETH " };
|
|
||||||
const result = filterTransactions([padded], {
|
|
||||||
hideSpoofedSymbols: true,
|
|
||||||
hideFraudContracts: true,
|
|
||||||
hideLowHolderTokens: true,
|
|
||||||
hideDustTransactions: true,
|
|
||||||
dustThresholdGwei: 100000,
|
|
||||||
});
|
|
||||||
expect(result.transactions).toEqual([]);
|
|
||||||
// The contract is learned as fraudulent, exactly as for the
|
|
||||||
// unpadded symbol: the padding must not cost the blocklist entry.
|
|
||||||
expect(result.newFraudContracts).toEqual([FAKE_ETH_CONTRACT]);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a real native ETH transfer survives", () => {
|
test("a real native ETH transfer survives", () => {
|
||||||
const native = {
|
const native = {
|
||||||
hash: "0x" + "2".repeat(64),
|
hash: "0x" + "2".repeat(64),
|
||||||
@@ -512,36 +201,6 @@ describe("surface 2: the Send token selector", () => {
|
|||||||
expect(select.children).toEqual([]);
|
expect(select.children).toEqual([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Issue #260 on this surface: the option text is rendered into HTML,
|
|
||||||
// which collapses the padding, so an unfiltered padded token would sit
|
|
||||||
// in the selector reading exactly `ETH`.
|
|
||||||
test("a padded fake ETH token is not selectable either", () => {
|
|
||||||
render([
|
|
||||||
{
|
|
||||||
address: FAKE_ETH_CONTRACT,
|
|
||||||
symbol: " ETH ",
|
|
||||||
decimals: 18,
|
|
||||||
balance: "0.005",
|
|
||||||
holders: 900000,
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
expect(select.children).toEqual([]);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a genuine token with a padded symbol stays selectable", () => {
|
|
||||||
render([
|
|
||||||
{
|
|
||||||
address: USDC_CONTRACT,
|
|
||||||
symbol: " USDC ",
|
|
||||||
decimals: 6,
|
|
||||||
balance: "12.5",
|
|
||||||
holders: 900000,
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
expect(select.children).toHaveLength(1);
|
|
||||||
expect(select.children[0].value).toBe(USDC_CONTRACT);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("native ETH remains the always-present option", () => {
|
test("native ETH remains the always-present option", () => {
|
||||||
render([]);
|
render([]);
|
||||||
expect(select.innerHTML).toBe('<option value="ETH">ETH</option>');
|
expect(select.innerHTML).toBe('<option value="ETH">ETH</option>');
|
||||||
@@ -592,35 +251,6 @@ describe("surface 3: the balance list", () => {
|
|||||||
expect(balances).toEqual([]);
|
expect(balances).toEqual([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Issue #260 on this surface: the balance list is where the user forms
|
|
||||||
// their belief about what they own, and it renders the symbol into HTML.
|
|
||||||
test("a padded fake ETH token is filtered too", async () => {
|
|
||||||
respondWith([fakeEthItem({ symbol: " ETH " })]);
|
|
||||||
expect(await fetchTokenBalances(HOLDER, BLOCKSCOUT, [])).toEqual([]);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a fake ETH token padded with a no-break space is filtered", async () => {
|
|
||||||
respondWith([fakeEthItem({ symbol: NBSP + "ETH" + NBSP })]);
|
|
||||||
expect(await fetchTokenBalances(HOLDER, BLOCKSCOUT, [])).toEqual([]);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The false-positive direction on the surface that matters most: a real
|
|
||||||
// holding whose symbol happens to carry padding is still listed, and the
|
|
||||||
// list still shows the symbol the token actually reports.
|
|
||||||
test("a genuine token with a padded symbol is not newly filtered", async () => {
|
|
||||||
respondWith([
|
|
||||||
fakeEthItem({
|
|
||||||
address_hash: USDC_CONTRACT,
|
|
||||||
symbol: " USDC ",
|
|
||||||
name: "USD Coin",
|
|
||||||
decimals: "6",
|
|
||||||
}),
|
|
||||||
]);
|
|
||||||
const balances = await fetchTokenBalances(HOLDER, BLOCKSCOUT, []);
|
|
||||||
expect(balances).toHaveLength(1);
|
|
||||||
expect(balances[0].symbol).toBe(" USDC ");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a genuine token keeps its place in the list", async () => {
|
test("a genuine token keeps its place in the list", async () => {
|
||||||
respondWith([
|
respondWith([
|
||||||
fakeEthItem({
|
fakeEthItem({
|
||||||
@@ -644,33 +274,6 @@ describe("surface 3: the balance list", () => {
|
|||||||
expect(await fetchTokenBalances(HOLDER, BLOCKSCOUT, [])).toEqual([]);
|
expect(await fetchTokenBalances(HOLDER, BLOCKSCOUT, [])).toEqual([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// The adjacent finding from the same review as issue #260: the type gate
|
|
||||||
// compared exactly, so an explorer that ever varied the casing would
|
|
||||||
// silently drop a real holding before any filter ran. The comparison is
|
|
||||||
// now case-insensitive, which changes nothing about which types are
|
|
||||||
// admitted.
|
|
||||||
test("a differently-cased ERC-20 type still lists a real holding", async () => {
|
|
||||||
respondWith([
|
|
||||||
fakeEthItem({
|
|
||||||
type: "erc-20",
|
|
||||||
address_hash: USDC_CONTRACT,
|
|
||||||
symbol: "USDC",
|
|
||||||
name: "USD Coin",
|
|
||||||
decimals: "6",
|
|
||||||
}),
|
|
||||||
]);
|
|
||||||
const balances = await fetchTokenBalances(HOLDER, BLOCKSCOUT, []);
|
|
||||||
expect(balances).toHaveLength(1);
|
|
||||||
expect(balances[0].symbol).toBe("USDC");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("case insensitivity does not admit another token type", async () => {
|
|
||||||
respondWith([fakeEthItem({ type: "erc-721" })]);
|
|
||||||
expect(await fetchTokenBalances(HOLDER, BLOCKSCOUT, [])).toEqual([]);
|
|
||||||
respondWith([fakeEthItem({ type: "ERC-20-EXTRA" })]);
|
|
||||||
expect(await fetchTokenBalances(HOLDER, BLOCKSCOUT, [])).toEqual([]);
|
|
||||||
});
|
|
||||||
|
|
||||||
// The money test: the user holds real ETH and has been airdropped a fake
|
// The money test: the user holds real ETH and has been airdropped a fake
|
||||||
// ETH ERC-20. The fake is gone from the list of tokens; the real balance
|
// ETH ERC-20. The fake is gone from the list of tokens; the real balance
|
||||||
// is exactly what the node reported.
|
// is exactly what the node reported.
|
||||||
|
|||||||
@@ -207,8 +207,8 @@ describe("token list assumptions the fixtures rely on", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
test("USDC and WETH map to their genuine lowercased contracts", () => {
|
test("USDC and WETH map to their genuine lowercased contracts", () => {
|
||||||
expect([...KNOWN_SYMBOLS.get("USDC")]).toEqual([USDC_CONTRACT]);
|
expect(KNOWN_SYMBOLS.get("USDC")).toBe(USDC_CONTRACT);
|
||||||
expect([...KNOWN_SYMBOLS.get("WETH")]).toEqual([WETH_CONTRACT]);
|
expect(KNOWN_SYMBOLS.get("WETH")).toBe(WETH_CONTRACT);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("the spam fixture symbol is not in the known token list", () => {
|
test("the spam fixture symbol is not in the known token list", () => {
|
||||||
|
|||||||
Reference in New Issue
Block a user