feat: show red warning on confirm-tx for addresses with zero transaction history

When sending to an address that has never sent or received funds (zero nonce and zero balance), display a prominent red warning on the transaction confirmation screen advising the user to double-check the address. Closes #82
2026-02-28 14:33:40 -08:00
9 changed files with 50 additions and 87 deletions
--- a/src/popup/styles/main.css
+++ b/src/popup/styles/main.css
@@ -15,21 +15,6 @@
    --color-section: #dddddd;
 }

-@keyframes copy-flash {
-    0% {
-        background-color: var(--color-fg);
-        color: var(--color-bg);
-    }
-    100% {
-        background-color: transparent;
-        color: inherit;
-    }
-}
-
-.copy-flash {
-    animation: copy-flash 500ms ease-out;
-}
-
 body {
    width: 396px;
    overflow-x: hidden;
--- a/src/popup/views/addressDetail.js
+++ b/src/popup/views/addressDetail.js
@@ -2,7 +2,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    balanceLinesForAddress,
    addressDotHtml,
    addressTitle,
@@ -238,11 +237,9 @@ function renderTransactions(txs) {
 function init(_ctx) {
    ctx = _ctx;
    $("address-full").addEventListener("click", () => {
-        const el = $("address-full");
-        const addr = el.dataset.full;
+        const addr = $("address-full").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });
@@ -357,21 +354,17 @@ function init(_ctx) {
    });

    $("export-privkey-value").addEventListener("click", () => {
-        const el = $("export-privkey-value");
-        const key = el.textContent;
+        const key = $("export-privkey-value").textContent;
        if (key) {
            navigator.clipboard.writeText(key);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });

    $("export-privkey-address").addEventListener("click", () => {
-        const el = $("export-privkey-address");
-        const full = el.dataset.full;
+        const full = $("export-privkey-address").dataset.full;
        if (full) {
            navigator.clipboard.writeText(full);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });
--- a/src/popup/views/addressToken.js
+++ b/src/popup/views/addressToken.js
@@ -5,7 +5,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    addressDotHtml,
    addressTitle,
    escapeHtml,
@@ -314,11 +313,9 @@ function renderTransactions(txs) {
 function init(_ctx) {
    ctx = _ctx;
    $("address-token-full").addEventListener("click", () => {
-        const el = $("address-token-full");
-        const addr = el.dataset.full;
+        const addr = $("address-token-full").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });
@@ -327,7 +324,6 @@ function init(_ctx) {
        const copyEl = e.target.closest("[data-copy]");
        if (copyEl) {
            navigator.clipboard.writeText(copyEl.dataset.copy);
-            flashCopyElement(copyEl);
            showFlash("Copied!");
        }
    });
@@ -376,7 +372,6 @@ function init(_ctx) {
        if (copyEl) {
            copyEl.addEventListener("click", () => {
                navigator.clipboard.writeText(copyEl.dataset.copy);
-                flashCopyElement(copyEl);
                showFlash("Copied!");
            });
        }
--- a/src/popup/views/confirmTx.js
+++ b/src/popup/views/confirmTx.js
@@ -15,7 +15,6 @@ const {
    hideError,
    showView,
    showFlash,
-    flashCopyElement,
    addressTitle,
    addressDotHtml,
    escapeHtml,
@@ -87,6 +86,42 @@ function valueWithUsd(text, usdAmount) {
    return text;
 }

+function renderWarnings(warnings) {
+    const warningsEl = $("confirm-warnings");
+    if (warnings.length > 0) {
+        warningsEl.innerHTML = warnings
+            .map(
+                (w) =>
+                    `<div class="border border-border border-dashed p-2 mb-1 text-xs font-bold" style="color:#c00">WARNING: ${w}</div>`,
+            )
+            .join("");
+        warningsEl.classList.remove("hidden");
+    } else {
+        warningsEl.classList.add("hidden");
+    }
+}
+
+async function checkAddressHistory(address, existingWarnings) {
+    try {
+        const provider = getProvider(state.rpcUrl);
+        const [balance, txCount] = await Promise.all([
+            provider.getBalance(address),
+            provider.getTransactionCount(address),
+        ]);
+        if (balance === 0n && txCount === 0) {
+            const warnings = existingWarnings.slice();
+            warnings.push(
+                "This address has ZERO transaction history. " +
+                    "It has never sent or received funds. " +
+                    "Double-check that the address is correct before sending.",
+            );
+            renderWarnings(warnings);
+        }
+    } catch (e) {
+        log.errorf("address history check failed:", e.message);
+    }
+}
+
 function show(txInfo) {
    pendingTx = txInfo;

@@ -117,7 +152,6 @@ function show(txInfo) {
        if (copyEl) {
            copyEl.onclick = () => {
                navigator.clipboard.writeText(copyEl.dataset.copy);
-                flashCopyElement(copyEl);
                showFlash("Copied!");
            };
        }
@@ -178,18 +212,10 @@ function show(txInfo) {
        warnings.push("You are sending to your own address.");
    }

-    const warningsEl = $("confirm-warnings");
-    if (warnings.length > 0) {
-        warningsEl.innerHTML = warnings
-            .map(
-                (w) =>
-                    `<div class="border border-border border-dashed p-2 mb-1 text-xs font-bold">WARNING: ${w}</div>`,
-            )
-            .join("");
-        warningsEl.classList.remove("hidden");
-    } else {
-        warningsEl.classList.add("hidden");
-    }
+    renderWarnings(warnings);
+
+    // Async check: warn if destination address has zero transaction history
+    checkAddressHistory(txInfo.to, warnings);

    // Check for errors
    const errors = [];
--- a/src/popup/views/helpers.js
+++ b/src/popup/views/helpers.js
@@ -76,18 +76,6 @@ function clearFlash() {
    $("flash-msg").textContent = "";
 }

-function flashCopyElement(el) {
-    el.classList.remove("copy-flash");
-    // Force reflow so re-adding the class restarts the animation.
-    void el.offsetWidth;
-    el.classList.add("copy-flash");
-    el.addEventListener(
-        "animationend",
-        () => el.classList.remove("copy-flash"),
-        { once: true },
-    );
-}
-
 function showFlash(msg, duration = 2000) {
    clearFlash();
    $("flash-msg").textContent = msg;
@@ -277,7 +265,6 @@ module.exports = {
    hideError,
    showView,
    showFlash,
-    flashCopyElement,
    balanceLine,
    balanceLinesForAddress,
    addressColor,
--- a/src/popup/views/home.js
+++ b/src/popup/views/home.js
@@ -2,7 +2,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    balanceLinesForAddress,
    isoDate,
    timeAgo,
@@ -86,9 +85,8 @@ function renderActiveAddress() {
        el.innerHTML =
            `<span class="underline decoration-dashed cursor-pointer" id="active-addr-copy">${dot}${escapeHtml(addr)}</span>` +
            `<a href="${link}" target="_blank" rel="noopener" class="inline-flex items-center">${EXT_ICON}</a>`;
-        $("active-addr-copy").addEventListener("click", (e) => {
+        $("active-addr-copy").addEventListener("click", () => {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(e.currentTarget);
            showFlash("Copied!");
        });
    } else {
--- a/src/popup/views/receive.js
+++ b/src/popup/views/receive.js
@@ -2,7 +2,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    formatAddressHtml,
    addressTitle,
 } = require("./helpers");
@@ -62,21 +61,17 @@ function show() {

 function init(ctx) {
    $("receive-address-block").addEventListener("click", () => {
-        const el = $("receive-address-block");
-        const addr = el.dataset.full;
+        const addr = $("receive-address-block").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(el);
            showFlash("Copied!");
        }
    });

    $("btn-receive-copy").addEventListener("click", () => {
-        const block = $("receive-address-block");
-        const addr = block.dataset.full;
+        const addr = $("receive-address-block").dataset.full;
        if (addr) {
            navigator.clipboard.writeText(addr);
-            flashCopyElement(block);
            showFlash("Copied!");
        }
    });
--- a/src/popup/views/transactionDetail.js
+++ b/src/popup/views/transactionDetail.js
@@ -5,7 +5,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    addressDotHtml,
    addressTitle,
    escapeHtml,
@@ -159,9 +158,8 @@ function render() {
        loadCalldata(tx.hash, tx.to);
    }

-    const isoStr = isoDate(tx.timestamp);
-    $("tx-detail-time").innerHTML =
-        copyableHtml(isoStr) + " (" + escapeHtml(timeAgo(tx.timestamp)) + ")";
+    $("tx-detail-time").textContent =
+        isoDate(tx.timestamp) + " (" + timeAgo(tx.timestamp) + ")";
    $("tx-detail-status").textContent = tx.isError ? "Failed" : "Success";
    showView("transaction");

@@ -171,7 +169,6 @@ function render() {
        .forEach((el) => {
            el.onclick = () => {
                navigator.clipboard.writeText(el.dataset.copy);
-                flashCopyElement(el);
                showFlash("Copied!");
            };
        });
@@ -249,7 +246,6 @@ async function loadCalldata(txHash, toAddress) {
            container.querySelectorAll("[data-copy]").forEach((el) => {
                el.onclick = () => {
                    navigator.clipboard.writeText(el.dataset.copy);
-                    flashCopyElement(el);
                    showFlash("Copied!");
                };
            });
--- a/src/popup/views/txStatus.js
+++ b/src/popup/views/txStatus.js
@@ -4,7 +4,6 @@ const {
    $,
    showView,
    showFlash,
-    flashCopyElement,
    addressDotHtml,
    addressTitle,
    escapeHtml,
@@ -60,16 +59,6 @@ function txHashHtml(hash) {
    );
 }

-function blockNumberHtml(blockNumber) {
-    const num = String(blockNumber);
-    const link = `https://etherscan.io/block/${num}`;
-    const extLink = `<a href="${link}" target="_blank" rel="noopener" class="inline-flex items-center">${EXT_ICON}</a>`;
-    return (
-        `<span class="underline decoration-dashed cursor-pointer" data-copy="${escapeHtml(num)}">${escapeHtml(num)}</span>` +
-        extLink
-    );
-}
-
 function attachCopyHandlers(viewId) {
    document
        .getElementById(viewId)
@@ -77,7 +66,6 @@ function attachCopyHandlers(viewId) {
        .forEach((el) => {
            el.onclick = () => {
                navigator.clipboard.writeText(el.dataset.copy);
-                flashCopyElement(el);
                showFlash("Copied!");
            };
        });
@@ -201,7 +189,7 @@ function renderSuccess() {
        $("success-tx-to").innerHTML = toAddressHtml(d.to);
    }

-    $("success-tx-block").innerHTML = blockNumberHtml(d.blockNumber);
+    $("success-tx-block").textContent = String(d.blockNumber);
    $("success-tx-hash").innerHTML = txHashHtml(d.hash);

    // Show decoded calldata details if present