fix: floor the persisted fields a restore dereferences, and make each field's floor an executable claim (closes #362)

A persisted container was checked while its ENTRIES were dereferenced
unchecked. A stored `{"0x…": "notalist"}` in allowedSites passes the state
gate, renders a working popup, and then throws inside saveState()'s per-
hostname merge, so every save from that moment on fails while the UI looks
entirely healthy. deniedSites has the identical shape; fraudContracts is the
same class with a milder consequence.

The sweep for that class found four more:

- selectedToken, dereferenced as text behind a truthiness-only restore gate.
- rpcUrl, handed whole to `new JsonRpcProvider()` by getProvider(), which
  throws SYNCHRONOUSLY for a non-string — from txStatus.js and addWallet.js,
  neither inside a try, and the first reachable from a stored
  `currentView: "wait-tx"` through the unguarded restoreView().
- The ENTRIES of viewData. Four restore branches gate on one truthy field and
  hand the rest to a renderer that calls address.toLowerCase(): a stored
  `{"currentView":"success-tx","viewData":{"hash":"0x1"}}` throws out of
  restoreView(), skipping the rest of popup init.
- selectedWallet / selectedAddress. `wallets` is a real Array, so a stored
  "map", "length", "constructor" or "__proto__" is TRUTHY: hasValidAddress()'s
  `&&` does not short-circuit and `.addresses[…]` throws. A stale INTEGER index
  is the safe case.

Floors, in src/shared/persistedState.js: allowedSites/deniedSites through
siteMap(), fraudContracts and each hostname list through textList(),
selectedToken and activeAddress as text-or-null, rpcUrl and blockscoutUrl as
non-empty text, selectedWallet and selectedAddress as a non-negative integer
or null, and each networkEndpoints pair's two URL fields — which
applyChainSwitchFields() assigns straight onto s.rpcUrl on the next switch.

Guards, in src/popup/viewRouter.js: the four restore branches that gate on one
truthy field now check the entries their renderer dereferences, as
txStatus.restoreWait() has always done for wait-tx. "confirm-tx" joins
ADDRESS_VIEWS, because its Sign button dereferences
state.wallets[state.selectedWallet] behind no guard of its own.

A stored own "__proto__" key is dropped by siteMap(): it can never be a wallet
address, so it grants nothing, and keeping it only keeps a value the next save
would hand to the prototype setter. networkEndpoints keeps unknown keys by
design, so mergeMapByKey() in src/shared/state.js now writes with
defineProperty as well — the guard in the floor was being undone one layer
downstream.

A save that fails is also told, not merely repaired: onSaveFailure() reports
every failed save, awaited or not (the save queue's own rejection handler is
what made a failure vanish), and the popup raises a persistent "NOT SAVED"
banner naming the reason. doRefreshAndRender() no longer rejects, since every
one of its call sites fires it and walks away.

The per-field justification in the header of src/shared/stateSchema.js is
replaced by tests/persistedFieldContract.test.js. That comment shipped a false
claim in three consecutive changes; the artifact was the problem. The test is
one row per persisted field, declaring the property that field's floor is
claimed to have and PROVING it by driving the real code with hostile values —
the gate for a field the gate refuses, normalizePersisted() for a field it
floors, the real JsonRpcProvider constructor for rpcUrl, and — for every field
whose only defence is that nothing dereferences it structurally — a boot of the
real popup entry point over that value onto EVERY view the popup can reopen
onto.

That last part is what makes the claim falsifiable, and it is why this defect
class is worth a harness at all: it lives on the RESTORE path and not on Home.
The claim is NARROW, and every artifact now states it that way rather than as
a universal: what those boots prove is no structural dereference on the code
paths a WHOLLY-CORRUPTED PROFILE takes. That is not every path a stored record
takes. Undriven, and said so plainly: any pairing of values the four slots do
not produce; a view only forward navigation opens; anything behind a click; and
everything a healthy profile reaches, which is most of the popup. Proving no
field is dereferenced on any reachable render path would be exhaustive
verification of the popup, which is not what this issue is.

Within that boundary the verdict is unconditional. If one of these boots leaves
the popup unhealthy or off the view it stored, the suite goes red — including
when it takes TWO corrupted fields at once, because the assertion is on the
combined boot itself and the per-field re-boot that names a culprit can only
decorate the message. An earlier version asserted on the per-field list
instead, so a dead popup no single field reproduced was observed and then
reported green. The suite also goes red on a field that gains a floor while its
row still claims it has none, and on a field added to PERSISTED_FIELDS with no
row.

Each swept field is driven at both polarities, or proven unable to be falsy
after the floor: a value nothing in src/ writes is a wrong-typed one and
therefore truthy, so without a falsy slot a dereference behind `if (!state.x)`
is never reached on the very boot that corrupts x, and for three of these
fields the falsy answer is the DEFAULT_STATE default — the branch every
ordinary install takes.

The boots are cheap enough to keep by construction rather than by sampling.
Every field the router itself reads is driven onto each view individually,
since a hostile value in one of those legitimately changes which view renders;
every other unfloored field is corrupted on the SAME boot, and that boot has to
land on the view it stored — so a field that does move the routing cannot hide
in the crowd. That is forty-four boots instead of several hundred; the suite
runs in 12.8s against a 30s cap.

The DOM stub in tests/support/popupBoot.js gained one thing to make any of that
possible: an element's parentElement. Without it success-tx and transaction
threw on the first line that hides a field's wrapper, so neither renderer could
be booted onto at all — every boot aimed at them fell back to Home instead, and
the base profile the sweep starts from is now asserted to render each view
rather than fall back, so that cannot go unnoticed again.

README.md

@@ -1052,24 +1052,20 @@ driving the real code with hostile values — and, for every field whose only
 defence is that nothing dereferences it, by booting the real popup entry point
 over that value onto every view the popup can reopen onto. That last part is
 what makes the claim falsifiable, because this defect class lives on the restore
-path rather than on the home screen: whenever one of those boots reaches a
+path rather than on the home screen. Read the claim narrowly, as that file
-structural dereference on the view it restored onto, `make check` fails —
+states it: what those boots prove is no structural dereference on the code paths
-including a dereference that takes two corrupted fields at once, because the
+a WHOLLY-CORRUPTED PROFILE takes, which is not every path a stored record takes.
-verdict is the combined boot and the per-field re-boot that names a culprit can
+Not driven: any pairing of values the four slots do not produce, a view only
-only decorate the message. Each swept field is driven at both polarities, or
+forward navigation opens, anything behind a click, and everything a healthy
-proven unable to be falsy after the floor, since a value nothing writes is
+profile reaches. Within that boundary the verdict is unconditional — if one of
-wrong-typed and therefore truthy and would otherwise leave every `if (!state.x)`
+those boots leaves the popup unhealthy or off the view it stored, `make check`
-branch unentered. So does a field that gains a floor while its row still claims
+fails, including when it takes two corrupted fields at once, because the verdict
-it has none, and so does a field added to `PERSISTED_FIELDS` with no row at all.
+is the combined boot and the per-field re-boot that names a culprit can only
-What the boots do not drive is every combination: four value combinations per
+decorate the message. So does a field that gains a floor while its row still
-view, not the product of the twelve swept fields. The last of the four is itself
+claims it has none, and so does a field added to `PERSISTED_FIELDS` with no row
-a mix — every falsy-capable field falsy against the ones that cannot be falsy —
+at all. The per-field justification that used to live in the header of
-so many two-field interactions are driven; one needing a pairing none of the
+`src/shared/stateSchema.js` shipped a false claim in three consecutive changes,
-four produces is not. Nor is anything no stored record reaches by itself — a
+each caught only by a reviewer re-deriving thirty fields by hand.
-view only forward navigation opens, and anything behind a click. The per-field
-justification that used to live in the header of `src/shared/stateSchema.js`
-shipped a false claim in three consecutive changes, each caught only by a
-reviewer re-deriving thirty fields by hand.
 
 The `allowedSites` case is why the entry check is not optional. A stored
 `{"0x…": "notalist"}` is a well-formed object holding a malformed entry: it

TODO.md

@@ -85,15 +85,15 @@ but the review is broader than any of them.
   the path this whole class of defect lives on. Each such field is driven at
   both polarities — a value nothing writes is wrong-typed and so truthy, so a
   falsy slot is driven too, or the field is proven unable to be falsy after the
-  floor. A field with no row, a field that gains a floor while its row still
+  floor. The claim is narrow and stated as such: no structural dereference on
-  claims it has none, and any structural dereference one of those boots reaches
+  the code paths a wholly-corrupted profile takes, which is not every path a
-  on the view it restored onto now all fail `make check` — including a
+  stored record takes — a pairing of values the four slots do not produce, a
-  dereference that takes two corrupted fields at once, because the verdict is
+  view only forward navigation opens, anything behind a click, and everything a
-  the combined boot and the per-field re-boot that names a culprit can only
+  healthy profile reaches are all undriven. Within that boundary the verdict is
-  decorate the message. What is not driven is every combination: four value
+  unconditional, including a dereference that takes two corrupted fields at
-  combinations per view rather than the product of the twelve swept fields, so
+  once, since the assertion is on the combined boot and the per-field re-boot
-  an interaction needing a pairing none of the four produces goes unseen, as
+  can only decorate the message. A field with no row and a field that gains a
-  does anything no stored record reaches by itself.
+  floor while its row still claims it has none also fail `make check`.
 - 2026-08-23: A swap amount and the token it is counted in now always come from
   the same hop, on both sides of the approval screen
   ([#359](https://git.eeqj.de/sneak/AutistMask/issues/359) and

src/shared/stateSchema.js

@@ -38,24 +38,16 @@
 // real popup entry point onto EVERY view the popup can reopen onto.
 //
 // That last part is the whole point, because this defect class lives on the
-// RESTORE path and not on Home: whenever one of those boots reaches a
+// RESTORE path and not on Home. Take the claim NARROWLY, exactly as that file
-// structural dereference on the view it restored onto, that suite goes red —
+// states it: what those boots prove is no structural dereference on the code
-// including a dereference that takes two corrupted fields at once, since the
+// paths a WHOLLY-CORRUPTED PROFILE takes — which is not every path a stored
-// verdict is the combined boot and the per-field re-boot that names a culprit
+// record takes. Not driven: any pairing of values the four slots do not
-// can only decorate the message. Each swept field is driven at both
+// produce, a view only forward navigation opens, anything behind a click, and
-// polarities, or proven unable to be falsy after the floor: a value nothing
+// everything a healthy profile reaches. Within that boundary the verdict is
-// writes is wrong-typed and so truthy, which would otherwise leave every
+// unconditional, including a dereference that takes two corrupted fields at
-// `if (!state.x)` branch unentered. So does a field that gains a floor while
+// once. That suite also goes red on a field that gains a floor while its row
-// its row still claims it has none, and a field added to PERSISTED_FIELDS with
+// still claims it has none, and on a field added to PERSISTED_FIELDS with no
-// no row at all.
+// row at all.
-//
-// What the boots do NOT drive is every combination: four value combinations
-// per view, not the product of the twelve swept fields. The last of the four
-// is itself a mix — every falsy-capable field falsy against the ones that
-// cannot be falsy — so many two-field interactions are driven; one needing a
-// pairing none of the four produces is not. Nor is anything no stored record
-// reaches by itself: a view only forward navigation opens, and anything behind
-// a click.
 //
 // That test exists because this comment did not work. It carried a
 // hand-written justification per field, and it shipped a false one in three

tests/persistedFieldContract.test.js

@@ -44,23 +44,32 @@
 // reason, and a field that cannot be falsy after the floor says so in its row
 // and is proven so.
 //
-// What that buys: whenever one of those boots reaches a structural
+// READ THE CLAIM NARROWLY. What this file proves is: NO STRUCTURAL
-// dereference on the view it restored onto, this file goes red — INCLUDING a
+// DEREFERENCE ON THE CODE PATHS A WHOLLY-CORRUPTED PROFILE TAKES. That is not
-// dereference that takes two corrupted fields at once, because the verdict is
+// every path a stored record takes, and the difference is the whole of what
-// the combined boot itself and the per-field re-boot below can only decorate
+// this file does not cover:
-// the message. That is the one thing an earlier version of this file got
-// wrong: it asserted on the per-field list, so an observed dead popup that no
-// single field reproduced was reported green.
 //
-// What it does NOT buy is every combination — four value combinations per
+//   - Only the values in the table, in the SLOT arrangement below: four value
-// view are driven, not the product of twelve fields. Note that the last slot
+//     combinations per view, not the product of twelve fields. A dereference
-// is itself a MIX rather than a uniform polarity: every falsy-capable field is
+//     reached only under a pairing no slot produces is not driven at all.
-// falsy on it while the neverFalsy ones stay hostile-truthy, so many two-field
+//   - Only what a stored record reaches by ITSELF. A view only forward
-// interactions are driven and fatal. One that needs a pairing none of the four
+//     navigation opens, and anything behind a click, is not driven.
-// slots produces is not driven at all. Nor is anything no stored record
+//   - Nothing about the paths a HEALTHY profile takes, which is most of the
-// reaches by itself: a view only forward navigation opens, and anything behind
+//     popup. This file is a floor under one defect class, not a proof about
-// a click. Booting every field separately at every value would be several
+//     the renderers.
-// hundred boots and most of the suite's budget; this is forty-four.
+//
+// Within that boundary it is unconditional: if one of these boots leaves the
+// popup unhealthy or off the view it stored, this file goes red — including
+// when it takes two corrupted fields at once, because the verdict is the
+// combined boot itself and the per-field re-boot below can only decorate the
+// message. That last part is the one thing an earlier version got wrong: it
+// asserted on the per-field list, so an observed dead popup that no single
+// field reproduced was reported green.
+//
+// Booting every field separately at every value would be several hundred boots
+// and most of the suite's budget; this is forty-four. Widening it further is
+// out of scope — proving no field is dereferenced on any reachable render path
+// is exhaustive verification of the popup, not a floor under a stored record.
 //
 // The three claims this replaced, all false, all caught here by construction:
 // rpcUrl reaching `new JsonRpcProvider()` (a synchronous throw, not a caught
@@ -111,19 +120,6 @@ const swept = (row) => row.kind === KIND.LOOSE || Boolean(row.alsoSweep);
 // `if (!state.x) { state.y.deref() }`, so the falsy slot is not optional.
 const sweptValues = (row) => [...row.hostile, ...(row.falsy || [])];
 
-// What may count toward a row's POLARITY: the swept values, plus only those
-// `hostileRestore` entries driven onto every restorable view. An entry that
-// carries `views: [...]` reaches only those renderers, so counting it would
-// let a future row claim a polarity that one view sees and the other ten do
-// not. No current row does that — the restricted entries are all viewData's,
-// and viewData is neverFalsy — and this is what keeps it so.
-const polarityValues = (row) => [
-    ...sweptValues(row),
-    ...(row.hostileRestore || [])
-        .filter((entry) => !entry.views)
-        .map((entry) => entry.value),
-];
-
 // ------------------------------------------------------------------ the table
 //
 // `hostile` is values a stored record can carry that nothing in src/ ever
@@ -610,9 +606,10 @@ describe("both polarities of every swept field are driven", () => {
         test(`${row.field}: truthy and falsy`, () => {
             // What the boots below actually drive, floored the way a renderer
             // sees it — not what the row says it drives.
-            const driven = polarityValues(row).map((value) =>
+            const driven = [
-                floored(row.field, value),
+                ...sweptValues(row),
-            );
+                ...(row.hostileRestore || []).map((entry) => entry.value),
+            ].map((value) => floored(row.field, value));
 
             expect({
                 truthy: driven.some((value) => Boolean(value)),