Compare commits
4 Commits
7cfb3404cf
...
fix/77-con
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d2f7284975 | ||
| 9444b06b52 | |||
| c2fdb3e0c1 | |||
|
|
4157732f4b |
@@ -496,11 +496,6 @@
|
|||||||
class="border border-border p-1 w-full font-mono text-sm bg-bg text-fg"
|
class="border border-border p-1 w-full font-mono text-sm bg-bg text-fg"
|
||||||
placeholder="Address (0x...) or ENS name"
|
placeholder="Address (0x...) or ENS name"
|
||||||
/>
|
/>
|
||||||
<div
|
|
||||||
id="send-to-error"
|
|
||||||
class="text-xs"
|
|
||||||
style="min-height: 1.25rem; color: #cc0000"
|
|
||||||
></div>
|
|
||||||
</div>
|
</div>
|
||||||
<div class="mb-2">
|
<div class="mb-2">
|
||||||
<div class="flex justify-between mb-1">
|
<div class="flex justify-between mb-1">
|
||||||
|
|||||||
@@ -75,6 +75,7 @@ const RESTORABLE_VIEWS = new Set([
|
|||||||
"settings",
|
"settings",
|
||||||
"settings-addtoken",
|
"settings-addtoken",
|
||||||
"transaction",
|
"transaction",
|
||||||
|
"confirm-tx",
|
||||||
"success-tx",
|
"success-tx",
|
||||||
"error-tx",
|
"error-tx",
|
||||||
]);
|
]);
|
||||||
@@ -134,6 +135,13 @@ function restoreView() {
|
|||||||
fallbackView();
|
fallbackView();
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
|
case "confirm-tx":
|
||||||
|
if (state.viewData && state.viewData.pendingTx) {
|
||||||
|
confirmTx.show(state.viewData.pendingTx);
|
||||||
|
} else {
|
||||||
|
fallbackView();
|
||||||
|
}
|
||||||
|
break;
|
||||||
case "success-tx":
|
case "success-tx":
|
||||||
if (state.viewData && state.viewData.hash) {
|
if (state.viewData && state.viewData.hash) {
|
||||||
txStatus.renderSuccess();
|
txStatus.renderSuccess();
|
||||||
|
|||||||
@@ -18,7 +18,7 @@ const {
|
|||||||
addressDotHtml,
|
addressDotHtml,
|
||||||
escapeHtml,
|
escapeHtml,
|
||||||
} = require("./helpers");
|
} = require("./helpers");
|
||||||
const { state } = require("../../shared/state");
|
const { state, saveState } = require("../../shared/state");
|
||||||
const { getSignerForAddress } = require("../../shared/wallet");
|
const { getSignerForAddress } = require("../../shared/wallet");
|
||||||
const { decryptWithPassword } = require("../../shared/vault");
|
const { decryptWithPassword } = require("../../shared/vault");
|
||||||
const { formatUsd, getPrice } = require("../../shared/prices");
|
const { formatUsd, getPrice } = require("../../shared/prices");
|
||||||
@@ -219,6 +219,10 @@ function show(txInfo) {
|
|||||||
$("confirm-fee-amount").textContent = "Estimating...";
|
$("confirm-fee-amount").textContent = "Estimating...";
|
||||||
showView("confirm-tx");
|
showView("confirm-tx");
|
||||||
|
|
||||||
|
// Persist txInfo so the view survives popup close/reopen
|
||||||
|
state.viewData = { pendingTx: txInfo };
|
||||||
|
saveState();
|
||||||
|
|
||||||
estimateGas(txInfo);
|
estimateGas(txInfo);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -11,107 +11,6 @@ const { state, currentAddress } = require("../../shared/state");
|
|||||||
let ctx;
|
let ctx;
|
||||||
const { getProvider } = require("../../shared/balances");
|
const { getProvider } = require("../../shared/balances");
|
||||||
const { KNOWN_SYMBOLS, resolveSymbol } = require("../../shared/tokenList");
|
const { KNOWN_SYMBOLS, resolveSymbol } = require("../../shared/tokenList");
|
||||||
const { getAddress } = require("ethers");
|
|
||||||
|
|
||||||
const ZERO_ADDRESS = "0x0000000000000000000000000000000000000000";
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Validate a destination address string.
|
|
||||||
* Returns { valid: true } or { valid: false, error: "..." }.
|
|
||||||
*/
|
|
||||||
function validateToAddress(value) {
|
|
||||||
const v = value.trim();
|
|
||||||
if (!v) return { valid: false, error: "" };
|
|
||||||
|
|
||||||
// ENS names: contains a dot and doesn't start with 0x
|
|
||||||
if (v.includes(".") && !v.startsWith("0x")) {
|
|
||||||
// Basic ENS format check: at least one label before and after dot
|
|
||||||
if (/^[a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)+$/.test(v)) {
|
|
||||||
return { valid: true };
|
|
||||||
}
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Please enter a valid ENS name.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// Must look like an Ethereum address
|
|
||||||
if (!/^0x[0-9a-fA-F]{40}$/.test(v)) {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Please enter a valid Ethereum address.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// Reject zero address
|
|
||||||
if (v.toLowerCase() === ZERO_ADDRESS) {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Sending to the zero address is not allowed.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// EIP-55 checksum validation: all-lowercase is ok, otherwise must match checksum
|
|
||||||
if (v !== v.toLowerCase()) {
|
|
||||||
try {
|
|
||||||
const checksummed = getAddress(v);
|
|
||||||
if (checksummed !== v) {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Address checksum is invalid. Please double-check the address.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
} catch {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Address checksum is invalid. Please double-check the address.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Warn if sending to own address
|
|
||||||
const addr = currentAddress();
|
|
||||||
if (addr && v.toLowerCase() === addr.address.toLowerCase()) {
|
|
||||||
// Allow but will warn — we return valid with a warning
|
|
||||||
return {
|
|
||||||
valid: true,
|
|
||||||
warning: "This is your own address. Are you sure?",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
return { valid: true };
|
|
||||||
}
|
|
||||||
|
|
||||||
function updateToValidation() {
|
|
||||||
const input = $("send-to");
|
|
||||||
const errorEl = $("send-to-error");
|
|
||||||
const btn = $("btn-send-review");
|
|
||||||
const value = input.value.trim();
|
|
||||||
|
|
||||||
if (!value) {
|
|
||||||
errorEl.textContent = "";
|
|
||||||
btn.disabled = true;
|
|
||||||
btn.classList.add("opacity-50");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const result = validateToAddress(value);
|
|
||||||
if (!result.valid) {
|
|
||||||
errorEl.textContent = result.error;
|
|
||||||
errorEl.style.color = "#cc0000";
|
|
||||||
btn.disabled = true;
|
|
||||||
btn.classList.add("opacity-50");
|
|
||||||
} else if (result.warning) {
|
|
||||||
errorEl.textContent = result.warning;
|
|
||||||
errorEl.style.color = "#b8860b";
|
|
||||||
btn.disabled = false;
|
|
||||||
btn.classList.remove("opacity-50");
|
|
||||||
} else {
|
|
||||||
errorEl.textContent = "";
|
|
||||||
btn.disabled = false;
|
|
||||||
btn.classList.remove("opacity-50");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const EXT_ICON =
|
const EXT_ICON =
|
||||||
`<span style="display:inline-block;width:10px;height:10px;margin-left:4px;vertical-align:middle">` +
|
`<span style="display:inline-block;width:10px;height:10px;margin-left:4px;vertical-align:middle">` +
|
||||||
@@ -189,13 +88,6 @@ function init(_ctx) {
|
|||||||
ctx = _ctx;
|
ctx = _ctx;
|
||||||
$("send-token").addEventListener("change", updateSendBalance);
|
$("send-token").addEventListener("change", updateSendBalance);
|
||||||
|
|
||||||
// Initial state: disable review button until address is entered
|
|
||||||
$("btn-send-review").disabled = true;
|
|
||||||
$("btn-send-review").classList.add("opacity-50");
|
|
||||||
|
|
||||||
// Validate address on input
|
|
||||||
$("send-to").addEventListener("input", updateToValidation);
|
|
||||||
|
|
||||||
$("btn-send-review").addEventListener("click", async () => {
|
$("btn-send-review").addEventListener("click", async () => {
|
||||||
const to = $("send-to").value.trim();
|
const to = $("send-to").value.trim();
|
||||||
const amount = $("send-amount").value.trim();
|
const amount = $("send-amount").value.trim();
|
||||||
@@ -203,15 +95,6 @@ function init(_ctx) {
|
|||||||
showFlash("Please enter a recipient address.");
|
showFlash("Please enter a recipient address.");
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Re-validate before proceeding
|
|
||||||
const validation = validateToAddress(to);
|
|
||||||
if (!validation.valid) {
|
|
||||||
showFlash(
|
|
||||||
validation.error || "Please enter a valid Ethereum address.",
|
|
||||||
);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
if (!amount || isNaN(parseFloat(amount)) || parseFloat(amount) <= 0) {
|
if (!amount || isNaN(parseFloat(amount)) || parseFloat(amount) <= 0) {
|
||||||
showFlash("Please enter a valid amount.");
|
showFlash("Please enter a valid amount.");
|
||||||
return;
|
return;
|
||||||
|
|||||||
@@ -153,9 +153,11 @@ async function fetchRecentTransactions(address, blockscoutUrl, count = 25) {
|
|||||||
|
|
||||||
// When a token transfer shares a hash with a normal tx, the normal tx
|
// When a token transfer shares a hash with a normal tx, the normal tx
|
||||||
// is the contract call (0 ETH) and the token transfer has the real
|
// is the contract call (0 ETH) and the token transfer has the real
|
||||||
// amount and symbol. Replace the normal tx with the token transfer,
|
// amount and symbol. A single transaction (e.g. a swap) can produce
|
||||||
// but preserve contract call metadata (direction, label, method) so
|
// multiple token transfers (one per token involved), so we key token
|
||||||
// swaps and other contract interactions display correctly.
|
// transfers by hash + contract address to keep all of them. We also
|
||||||
|
// preserve contract-call metadata (direction, label, method) from the
|
||||||
|
// matching normal tx so swaps display correctly.
|
||||||
for (const tt of ttJson.items || []) {
|
for (const tt of ttJson.items || []) {
|
||||||
const parsed = parseTokenTransfer(tt, addrLower);
|
const parsed = parseTokenTransfer(tt, addrLower);
|
||||||
const existing = txsByHash.get(parsed.hash);
|
const existing = txsByHash.get(parsed.hash);
|
||||||
@@ -164,8 +166,13 @@ async function fetchRecentTransactions(address, blockscoutUrl, count = 25) {
|
|||||||
parsed.directionLabel = existing.directionLabel;
|
parsed.directionLabel = existing.directionLabel;
|
||||||
parsed.isContractCall = true;
|
parsed.isContractCall = true;
|
||||||
parsed.method = existing.method;
|
parsed.method = existing.method;
|
||||||
|
// Remove the bare-hash normal tx so it doesn't appear as a
|
||||||
|
// duplicate with empty value; token transfers replace it.
|
||||||
|
txsByHash.delete(parsed.hash);
|
||||||
}
|
}
|
||||||
txsByHash.set(parsed.hash, parsed);
|
// Use composite key so multiple token transfers per tx are kept.
|
||||||
|
const ttKey = parsed.hash + ":" + (parsed.contractAddress || "");
|
||||||
|
txsByHash.set(ttKey, parsed);
|
||||||
}
|
}
|
||||||
|
|
||||||
const txs = [...txsByHash.values()];
|
const txs = [...txsByHash.values()];
|
||||||
|
|||||||
Reference in New Issue
Block a user