1 Commits
Author SHA1 Message Date
sneak eb8b7f6722 docs: README matches ConfirmTx's wrong-password message and fee-bound refusal (closes #610)
check / check (push) Canceled after 0s
e2e / e2e-chrome (push) Canceled after 0s
e2e / e2e-firefox (push) Canceled after 0s
ConfirmTx shows "That password is incorrect. Please try again." for a
wrong password, as every other screen that asks for one does. README
quoted "Wrong password." instead.

The fee-bound refusal said the RPC endpoint always fills in the gas
limit and fees at signing. An ETH amount that Max filled in is signed
with the gas limit and fees of the screen's own fee estimate instead.
README now says so, and lists what assertWithinCeilings() checks.

Model: opus-5-5
2026-10-27 22:58:01 +00:00
+3 -4
View File
@@ -2059,10 +2059,9 @@ view would leave a wallet one click from deletion.
sent. Please go back and try again." in its own box, no screen change. For sent. Please go back and try again." in its own box, no screen change. For
an ETH amount that Send's "Max" filled in, the gas limit and fees are an ETH amount that Send's "Max" filled in, the gas limit and fees are
those of this screen's own fee estimate (see Amount above). For any other those of this screen's own fee estimate (see Amount above). For any other
send, the RPC endpoint fills in the gas limit and fees at signing. send, the RPC endpoint fills in the gas limit and fees at signing. Just
`assertWithinCeilings()` (`src/shared/approvalVerify.js`) checks the before signing, `assertWithinCeilings()` (`src/shared/approvalVerify.js`)
transaction just before it is signed. The check refuses the send with the refuses the send when any of these is over its bound:
sentence above when any of these is over its bound:
- the gas limit - the gas limit
- each fee per gas the transaction sets - each fee per gas the transaction sets
- the total fee: the gas limit times `maxFeePerGas`, or times `gasPrice` - the total fee: the gas limit times `maxFeePerGas`, or times `gasPrice`