From 79fec8551f5ff5034eb7844d6197019da75bd4fc Mon Sep 17 00:00:00 2001 From: clawbot Date: Fri, 27 Feb 2026 14:26:04 -0800 Subject: [PATCH] fix: add reverse ENS lookups for all displayed addresses (closes #22) Previously, ENS reverse lookups were only performed for the single counterparty address (from or to depending on direction). This meant contract interaction targets and the non-counterparty side of transactions never got ENS names resolved. Now both from and to addresses are collected for ENS resolution, ensuring all displayed addresses show their ENS names when available. --- src/popup/views/addressDetail.js | 8 ++++---- src/popup/views/addressToken.js | 7 +++---- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/popup/views/addressDetail.js b/src/popup/views/addressDetail.js index 3f4f4f1..4eda88c 100644 --- a/src/popup/views/addressDetail.js +++ b/src/popup/views/addressDetail.js @@ -150,11 +150,11 @@ async function loadTransactions(address) { loadedTxs = txs; - // Collect unique counterparty addresses for ENS resolution. + // Collect ALL unique addresses (from + to) for ENS resolution so + // that reverse lookups work for every displayed address, not just + // the ones that were originally entered as ENS names. const counterparties = [ - ...new Set( - txs.map((tx) => (tx.direction === "sent" ? tx.to : tx.from)), - ), + ...new Set(txs.flatMap((tx) => [tx.from, tx.to].filter(Boolean))), ]; if (counterparties.length > 0) { try { diff --git a/src/popup/views/addressToken.js b/src/popup/views/addressToken.js index 1284029..f3b6ccb 100644 --- a/src/popup/views/addressToken.js +++ b/src/popup/views/addressToken.js @@ -213,11 +213,10 @@ async function loadTransactions(address, tokenId) { loadedTxs = txs; - // Collect unique counterparty addresses for ENS resolution + // Collect ALL unique addresses for ENS resolution so reverse + // lookups work for every displayed address. const counterparties = [ - ...new Set( - txs.map((tx) => (tx.direction === "sent" ? tx.to : tx.from)), - ), + ...new Set(txs.flatMap((tx) => [tx.from, tx.to].filter(Boolean))), ]; if (counterparties.length > 0) { try {