From d883ddadf2e55fa3f1db7dc0d6cfaa5f77ca45fd Mon Sep 17 00:00:00 2001 From: clawbot Date: Fri, 27 Feb 2026 12:07:47 -0800 Subject: [PATCH] fix: label swap methods as "Swap" in tx lists, remove unused variable - Map known DEX methods (execute, swap, multicall, etc.) to "Swap" label instead of raw method name like "Execute" - Remove unused displayData variable in transactionDetail.js Addresses review feedback on PR #10. --- src/popup/views/transactionDetail.js | 4 ---- src/shared/transactions.js | 11 ++++++++++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/popup/views/transactionDetail.js b/src/popup/views/transactionDetail.js index 53c2005..04c9859 100644 --- a/src/popup/views/transactionDetail.js +++ b/src/popup/views/transactionDetail.js @@ -188,10 +188,6 @@ async function loadCalldata(txHash, toAddress) { const method = txData.method || "Unknown method"; let html = `
Unknown contract call
`; html += `
${escapeHtml(method)}
`; - const displayData = - inputData.length > 202 - ? inputData.slice(0, 202) + "…" - : inputData; html += `
${copyableHtml(inputData, "break-all")}
`; container.innerHTML = html; } diff --git a/src/shared/transactions.js b/src/shared/transactions.js index d58fb86..d99227e 100644 --- a/src/shared/transactions.js +++ b/src/shared/transactions.js @@ -37,7 +37,16 @@ function parseTx(tx, addrLower) { if (token) { symbol = token.symbol; } - const label = method.charAt(0).toUpperCase() + method.slice(1); + // Map known DEX methods to "Swap" for cleaner display + const SWAP_METHODS = new Set([ + "execute", "swap", "swapExactTokensForTokens", + "swapTokensForExactTokens", "swapExactETHForTokens", + "swapTokensForExactETH", "swapExactTokensForETH", + "swapETHForExactTokens", "multicall", + ]); + const label = SWAP_METHODS.has(method) + ? "Swap" + : method.charAt(0).toUpperCase() + method.slice(1); direction = "contract"; directionLabel = label; value = "";