Type
diff --git a/src/popup/views/addWallet.js b/src/popup/views/addWallet.js
index 2e8e20e..eed7ac9 100644
--- a/src/popup/views/addWallet.js
+++ b/src/popup/views/addWallet.js
@@ -49,8 +49,8 @@ function init(ctx) {
showFlash("Please choose a password.");
return;
}
- if (pw.length < 8) {
- showFlash("Password must be at least 8 characters.");
+ if (pw.length < 12) {
+ showFlash("Password must be at least 12 characters.");
return;
}
if (pw !== pw2) {
diff --git a/src/popup/views/approval.js b/src/popup/views/approval.js
index 509557f..359b506 100644
--- a/src/popup/views/approval.js
+++ b/src/popup/views/approval.js
@@ -294,6 +294,18 @@ function showSignApproval(details) {
}
}
+ // Display danger warning for eth_sign (raw hash signing)
+ const warningEl = $("approve-sign-danger-warning");
+ if (warningEl) {
+ if (sp.dangerWarning) {
+ warningEl.textContent = sp.dangerWarning;
+ warningEl.classList.remove("hidden");
+ } else {
+ warningEl.textContent = "";
+ warningEl.classList.add("hidden");
+ }
+ }
+
$("approve-sign-password").value = "";
$("approve-sign-error").classList.add("hidden");
$("btn-approve-sign").disabled = false;
@@ -373,6 +385,7 @@ function init(ctx) {
type: "AUTISTMASK_TX_RESPONSE",
id: approvalId,
approved: true,
+ // TODO(security): Move decryption to popup to avoid sending password via runtime.sendMessage
password: password,
},
(response) => {
@@ -412,6 +425,7 @@ function init(ctx) {
type: "AUTISTMASK_SIGN_RESPONSE",
id: approvalId,
approved: true,
+ // TODO(security): Move decryption to popup to avoid sending password via runtime.sendMessage
password: password,
},
(response) => {
diff --git a/src/popup/views/confirmTx.js b/src/popup/views/confirmTx.js
index e7a4ca6..f11cf68 100644
--- a/src/popup/views/confirmTx.js
+++ b/src/popup/views/confirmTx.js
@@ -334,8 +334,13 @@ function init(ctx) {
tx = await contract.transfer(pendingTx.to, amount);
}
+ // Best-effort: clear decrypted secret after use.
+ // Note: JS strings are immutable; this nulls the reference but
+ // the original string may persist in memory until GC.
+ decryptedSecret = null;
txStatus.showWait(pendingTx, tx.hash);
} catch (e) {
+ decryptedSecret = null;
const hash = tx ? tx.hash : null;
txStatus.showError(pendingTx, hash, e.shortMessage || e.message);
}
diff --git a/src/popup/views/helpers.js b/src/popup/views/helpers.js
index de33fee..5d9daa8 100644
--- a/src/popup/views/helpers.js
+++ b/src/popup/views/helpers.js
@@ -85,7 +85,7 @@ function showFlash(msg, duration = 2000) {
function balanceLine(symbol, amount, price, tokenId) {
const qty = amount.toFixed(4);
- const usd = price ? formatUsd(amount * price) : "";
+ const usd = price ? formatUsd(amount * price) || " " : " ";
const tokenAttr = tokenId ? ` data-token="${tokenId}"` : "";
const clickClass = tokenId
? " cursor-pointer hover:bg-hover balance-row"
@@ -222,6 +222,41 @@ function formatAddressHtml(address, ensName, maxLen, title) {
return `
${dot}${escapeHtml(displayAddr)}
`;
}
+function isoDate(timestamp) {
+ const d = new Date(timestamp * 1000);
+ const pad = (n) => String(n).padStart(2, "0");
+ return (
+ d.getFullYear() +
+ "-" +
+ pad(d.getMonth() + 1) +
+ "-" +
+ pad(d.getDate()) +
+ " " +
+ pad(d.getHours()) +
+ ":" +
+ pad(d.getMinutes()) +
+ ":" +
+ pad(d.getSeconds())
+ );
+}
+
+function timeAgo(timestamp) {
+ const seconds = Math.floor(Date.now() / 1000 - timestamp);
+ if (seconds < 60) return seconds + " seconds ago";
+ const minutes = Math.floor(seconds / 60);
+ if (minutes < 60)
+ return minutes + " minute" + (minutes !== 1 ? "s" : "") + " ago";
+ const hours = Math.floor(minutes / 60);
+ if (hours < 24) return hours + " hour" + (hours !== 1 ? "s" : "") + " ago";
+ const days = Math.floor(hours / 24);
+ if (days < 30) return days + " day" + (days !== 1 ? "s" : "") + " ago";
+ const months = Math.floor(days / 30);
+ if (months < 12)
+ return months + " month" + (months !== 1 ? "s" : "") + " ago";
+ const years = Math.floor(days / 365);
+ return years + " year" + (years !== 1 ? "s" : "") + " ago";
+}
+
module.exports = {
$,
showError,
@@ -236,4 +271,6 @@ module.exports = {
addressTitle,
formatAddressHtml,
truncateMiddle,
+ isoDate,
+ timeAgo,
};
diff --git a/src/popup/views/home.js b/src/popup/views/home.js
index 7fd2262..62b352b 100644
--- a/src/popup/views/home.js
+++ b/src/popup/views/home.js
@@ -3,6 +3,8 @@ const {
showView,
showFlash,
balanceLinesForAddress,
+ isoDate,
+ timeAgo,
addressDotHtml,
escapeHtml,
truncateMiddle,
@@ -87,41 +89,6 @@ function renderActiveAddress() {
}
}
-function timeAgo(timestamp) {
- const seconds = Math.floor(Date.now() / 1000 - timestamp);
- if (seconds < 60) return seconds + " seconds ago";
- const minutes = Math.floor(seconds / 60);
- if (minutes < 60)
- return minutes + " minute" + (minutes !== 1 ? "s" : "") + " ago";
- const hours = Math.floor(minutes / 60);
- if (hours < 24) return hours + " hour" + (hours !== 1 ? "s" : "") + " ago";
- const days = Math.floor(hours / 24);
- if (days < 30) return days + " day" + (days !== 1 ? "s" : "") + " ago";
- const months = Math.floor(days / 30);
- if (months < 12)
- return months + " month" + (months !== 1 ? "s" : "") + " ago";
- const years = Math.floor(days / 365);
- return years + " year" + (years !== 1 ? "s" : "") + " ago";
-}
-
-function isoDate(timestamp) {
- const d = new Date(timestamp * 1000);
- const pad = (n) => String(n).padStart(2, "0");
- return (
- d.getFullYear() +
- "-" +
- pad(d.getMonth() + 1) +
- "-" +
- pad(d.getDate()) +
- " " +
- pad(d.getHours()) +
- ":" +
- pad(d.getMinutes()) +
- ":" +
- pad(d.getSeconds())
- );
-}
-
let homeTxs = [];
function renderHomeTxList(ctx) {
diff --git a/src/popup/views/importKey.js b/src/popup/views/importKey.js
index 874e6cf..a3324a3 100644
--- a/src/popup/views/importKey.js
+++ b/src/popup/views/importKey.js
@@ -30,8 +30,8 @@ function init(ctx) {
showFlash("Please choose a password.");
return;
}
- if (pw.length < 8) {
- showFlash("Password must be at least 8 characters.");
+ if (pw.length < 12) {
+ showFlash("Password must be at least 12 characters.");
return;
}
if (pw !== pw2) {
diff --git a/src/popup/views/transactionDetail.js b/src/popup/views/transactionDetail.js
index 0ec1dc3..8ecbfe3 100644
--- a/src/popup/views/transactionDetail.js
+++ b/src/popup/views/transactionDetail.js
@@ -8,6 +8,8 @@ const {
addressDotHtml,
addressTitle,
escapeHtml,
+ isoDate,
+ timeAgo,
} = require("./helpers");
const { state } = require("../../shared/state");
const makeBlockie = require("ethereum-blockies-base64");
@@ -21,41 +23,6 @@ const EXT_ICON =
let ctx;
-function isoDate(timestamp) {
- const d = new Date(timestamp * 1000);
- const pad = (n) => String(n).padStart(2, "0");
- return (
- d.getFullYear() +
- "-" +
- pad(d.getMonth() + 1) +
- "-" +
- pad(d.getDate()) +
- " " +
- pad(d.getHours()) +
- ":" +
- pad(d.getMinutes()) +
- ":" +
- pad(d.getSeconds())
- );
-}
-
-function timeAgo(timestamp) {
- const seconds = Math.floor(Date.now() / 1000 - timestamp);
- if (seconds < 60) return seconds + " seconds ago";
- const minutes = Math.floor(seconds / 60);
- if (minutes < 60)
- return minutes + " minute" + (minutes !== 1 ? "s" : "") + " ago";
- const hours = Math.floor(minutes / 60);
- if (hours < 24) return hours + " hour" + (hours !== 1 ? "s" : "") + " ago";
- const days = Math.floor(hours / 24);
- if (days < 30) return days + " day" + (days !== 1 ? "s" : "") + " ago";
- const months = Math.floor(days / 30);
- if (months < 12)
- return months + " month" + (months !== 1 ? "s" : "") + " ago";
- const years = Math.floor(days / 365);
- return years + " year" + (years !== 1 ? "s" : "") + " ago";
-}
-
function copyableHtml(text, extraClass) {
const cls =
"underline decoration-dashed cursor-pointer" +