fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)
Out of the box the wallet sent the user's addresses to Blockscout and each recipient's address to Etherscan. Two settings, "Use Blockscout" and "Check recipients on Etherscan", now gate every request that sends the user's data to those services. Both start off and are offered unticked on Welcome and in Settings. Each request reads its setting from storage before it asks. An answer that lands after the setting went off is dropped. While a setting is off, the screens that rely on it say so. ENS lookups ask only the RPC endpoint, so a name resolved off-chain does not resolve. RULES.md's External Communication item is now out of date. Its new wording will be proposed on #211 once this lands. Model: opus-5-5 (implementation, summary); fable-5-1 (prose)
This commit was merged in pull request #671.
This commit is contained in:
+10
-5
@@ -38,11 +38,16 @@ function markViewRendered(view) {
|
||||
if (view) renderedViews.add(view);
|
||||
}
|
||||
|
||||
// Begin a fresh page-load scope. The popup gets one by being loaded, and
|
||||
// asks for one after a network switch, because every screen then on the page
|
||||
// shows the previous network (showNewNetwork() in views/settings.js); the
|
||||
// unit tests, which simulate several page loads against one module
|
||||
// instance, ask for one too.
|
||||
// Begin a fresh page-load scope. The popup gets one by being loaded. It also
|
||||
// asks for one when every screen on the page is out of date:
|
||||
//
|
||||
// - after a network switch, since those screens show the previous network
|
||||
// (showNewSettings() in views/settings.js)
|
||||
// - after "Use Blockscout" or "Check recipients on Etherscan" changes, here
|
||||
// or on another page, since those screens were drawn under the old setting
|
||||
//
|
||||
// The unit tests ask for one too. They simulate several page loads against one
|
||||
// module instance.
|
||||
function resetRenderedViews() {
|
||||
renderedViews.clear();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user