fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)
Out of the box the wallet sent the user's addresses to Blockscout and each recipient's address to Etherscan. Two settings, "Use Blockscout" and "Check recipients on Etherscan", now gate every request that sends the user's data to those services. Both start off and are offered unticked on Welcome and in Settings. Each request reads its setting from storage before it asks. An answer that lands after the setting went off is dropped. While a setting is off, the screens that rely on it say so. ENS lookups ask only the RPC endpoint, so a name resolved off-chain does not resolve. RULES.md's External Communication item is now out of date. Its new wording will be proposed on #211 once this lands. Model: opus-5-5 (implementation, summary); fable-5-1 (prose)
This commit was merged in pull request #671.
This commit is contained in:
+117
-8
@@ -43,6 +43,38 @@
|
||||
<!-- ============ WELCOME / FIRST USE ============ -->
|
||||
<div id="view-welcome" class="view hidden">
|
||||
<p class="mb-3">Welcome! To get started, add a wallet.</p>
|
||||
<div class="bg-well p-3 mx-1 mb-3">
|
||||
<p class="text-xs mb-2">
|
||||
This wallet sends your data only to the Ethereum RPC
|
||||
endpoint, unless you turn on one of these. You can
|
||||
change them later in Settings.
|
||||
</p>
|
||||
<label
|
||||
class="text-xs flex items-center gap-1 cursor-pointer mb-1"
|
||||
>
|
||||
<input type="checkbox" id="welcome-use-blockscout" />
|
||||
Use Blockscout
|
||||
</label>
|
||||
<p class="text-xs text-muted mb-2">
|
||||
Shows transaction history, transaction details and the
|
||||
tokens you have not tracked. Sends your addresses, and
|
||||
the hash of each transaction you open, to the Blockscout
|
||||
API.
|
||||
</p>
|
||||
<label
|
||||
class="text-xs flex items-center gap-1 cursor-pointer mb-1"
|
||||
>
|
||||
<input
|
||||
type="checkbox"
|
||||
id="welcome-check-recipients-on-etherscan"
|
||||
/>
|
||||
Check recipients on Etherscan
|
||||
</label>
|
||||
<p class="text-xs text-muted">
|
||||
Sends each recipient's address to Etherscan to check it
|
||||
for a phishing or scam label.
|
||||
</p>
|
||||
</div>
|
||||
<button
|
||||
id="btn-welcome-add"
|
||||
class="border border-border px-2 py-1 hover:bg-fg hover:text-bg cursor-pointer"
|
||||
@@ -272,6 +304,10 @@
|
||||
|
||||
<!-- wallet list -->
|
||||
<div id="wallet-list"></div>
|
||||
<p id="home-tokens-note" class="text-xs text-muted py-1 hidden">
|
||||
Only tracked tokens are listed, because "Use Blockscout" is
|
||||
off in Settings.
|
||||
</p>
|
||||
|
||||
<!-- recent transactions across all addresses -->
|
||||
<div>
|
||||
@@ -336,6 +372,13 @@
|
||||
<div id="address-balances" class="min-h-[1.25rem]">
|
||||
|
||||
</div>
|
||||
<p
|
||||
id="address-tokens-note"
|
||||
class="text-xs text-muted hidden"
|
||||
>
|
||||
Only tracked tokens are listed, because "Use Blockscout"
|
||||
is off in Settings.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<!-- actions -->
|
||||
@@ -526,12 +569,23 @@
|
||||
</div>
|
||||
<div class="mb-2">
|
||||
<label class="block mb-1">What to send</label>
|
||||
<select
|
||||
id="send-token"
|
||||
class="border border-border p-1 w-full font-mono text-sm bg-bg text-fg"
|
||||
>
|
||||
<option value="ETH">ETH</option>
|
||||
</select>
|
||||
<!-- The token dropdown and the line under it. Both are
|
||||
hidden when AddressToken opens Send for its own token. -->
|
||||
<div id="send-token-dropdown">
|
||||
<select
|
||||
id="send-token"
|
||||
class="border border-border p-1 w-full font-mono text-sm bg-bg text-fg"
|
||||
>
|
||||
<option value="ETH">ETH</option>
|
||||
</select>
|
||||
<p
|
||||
id="send-tokens-note"
|
||||
class="text-xs text-muted hidden"
|
||||
>
|
||||
Only tracked tokens are listed, because "Use
|
||||
Blockscout" is off in Settings.
|
||||
</p>
|
||||
</div>
|
||||
<div id="send-token-static" class="text-sm hidden"></div>
|
||||
</div>
|
||||
<div class="mb-2">
|
||||
@@ -660,6 +714,13 @@
|
||||
phishing/scam. Do not send funds to this address.
|
||||
</div>
|
||||
</div>
|
||||
<p
|
||||
id="confirm-etherscan-note"
|
||||
class="mb-2 text-xs text-muted hidden"
|
||||
>
|
||||
This address was not checked on Etherscan, because "Check
|
||||
recipients on Etherscan" is off in Settings.
|
||||
</p>
|
||||
<div
|
||||
id="confirm-errors"
|
||||
class="mb-2 border border-border border-dashed p-2 invisible min-h-[1.25rem]"
|
||||
@@ -750,6 +811,7 @@
|
||||
<div class="mb-3">
|
||||
<div class="text-xs text-muted mb-1">Amount</div>
|
||||
<div id="wait-tx-summary" class="font-bold"></div>
|
||||
<div id="wait-tx-token-note"></div>
|
||||
</div>
|
||||
<div class="mb-3">
|
||||
<div class="text-xs text-muted mb-1">To</div>
|
||||
@@ -796,6 +858,7 @@
|
||||
<div class="mb-3">
|
||||
<div class="text-xs text-muted mb-1">Amount</div>
|
||||
<div id="error-tx-summary" class="font-bold"></div>
|
||||
<div id="error-tx-token-note"></div>
|
||||
</div>
|
||||
<div class="mb-3">
|
||||
<div class="text-xs text-muted mb-1">To</div>
|
||||
@@ -1002,9 +1065,21 @@
|
||||
|
||||
<div class="bg-well p-3 mx-1 mb-3">
|
||||
<h3 class="font-bold mb-1">Blockscout API</h3>
|
||||
<label
|
||||
class="text-xs flex items-center gap-1 cursor-pointer mb-1"
|
||||
>
|
||||
<input type="checkbox" id="settings-use-blockscout" />
|
||||
Use Blockscout
|
||||
</label>
|
||||
<p class="text-xs text-muted mb-2">
|
||||
Shows transaction history, transaction details and the
|
||||
tokens you have not tracked. Sends your addresses, and
|
||||
the hash of each transaction you open, to the Blockscout
|
||||
API below.
|
||||
</p>
|
||||
<p class="text-xs text-muted mb-1">
|
||||
Used to fetch token balances and transaction history.
|
||||
Change this if you run your own Blockscout instance.
|
||||
Change the URL below if you run your own Blockscout
|
||||
instance.
|
||||
</p>
|
||||
<input
|
||||
type="text"
|
||||
@@ -1019,6 +1094,23 @@
|
||||
</button>
|
||||
</div>
|
||||
|
||||
<div class="bg-well p-3 mx-1 mb-3">
|
||||
<h3 class="font-bold mb-1">Etherscan</h3>
|
||||
<label
|
||||
class="text-xs flex items-center gap-1 cursor-pointer mb-1"
|
||||
>
|
||||
<input
|
||||
type="checkbox"
|
||||
id="settings-check-recipients-on-etherscan"
|
||||
/>
|
||||
Check recipients on Etherscan
|
||||
</label>
|
||||
<p class="text-xs text-muted">
|
||||
Sends each recipient's address to Etherscan to check it
|
||||
for a phishing or scam label.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<div class="bg-well p-3 mx-1 mb-3">
|
||||
<h3 class="font-bold mb-1">Token Spam Protection</h3>
|
||||
<p class="text-xs text-muted mb-2">
|
||||
@@ -1291,6 +1383,13 @@
|
||||
>
|
||||
|
||||
</div>
|
||||
<p
|
||||
id="delete-address-tokens-note"
|
||||
class="text-xs text-muted mb-2 hidden"
|
||||
>
|
||||
Only tracked tokens are listed, because "Use Blockscout" is
|
||||
off in Settings.
|
||||
</p>
|
||||
<p class="text-xs text-muted mb-3">
|
||||
A wallet always keeps at least one address. To remove the
|
||||
last one, delete the whole wallet from Settings instead.
|
||||
@@ -1504,6 +1603,16 @@
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<!-- Shown in place of the block, decoded details, network
|
||||
details and raw data, which only Blockscout gives. -->
|
||||
<p
|
||||
id="tx-detail-blockscout-note"
|
||||
class="text-xs text-muted mx-1 mb-3 hidden"
|
||||
>
|
||||
This screen shows no block, decoded details, network details
|
||||
or raw data, because "Use Blockscout" is off in Settings.
|
||||
</p>
|
||||
|
||||
<!-- ── Decoded details ── -->
|
||||
<div id="tx-detail-calldata-section" class="hidden">
|
||||
<div class="bg-well p-3 mx-1 mb-3">
|
||||
|
||||
Reference in New Issue
Block a user