fix: one wording for an empty password field on every screen (closes #265)
All checks were successful
check / check (push) Successful in 28s
All checks were successful
check / check (push) Successful in 28s
The private key export screen answered an empty password field with "Password is required." where the other five screens that ask for the password say "Please enter your password." Same condition, two sentences, and a user hitting both had no reason to think they meant the same thing. The majority wording wins; the export screen now says it too. Strings only. Every screen still refuses to proceed on an empty field exactly as before. tests/passwordMessages.test.js already pinned the rejected-password sentence per decryptWithPassword call site; it now pins the empty-field sentence the same way, walking each decrypt's password variable back to the guard that rejects it blank and requiring the prose there to be the canonical sentence and nothing else. Anchoring on the decrypt keeps the wallet-creation screen out of the set, where an empty field means a password being chosen rather than entered -- a different condition with its own wording. Every error container measured at a 360px viewport in the pinned Playwright container against the built popup. The export screen's container holds at 20px with the section below it at the same offset for the empty reserved state, the old string and the new one.
This commit is contained in:
13
TODO.md
13
TODO.md
@@ -45,6 +45,19 @@ undefined identifiers, which is how
|
||||
|
||||
# Completed Steps
|
||||
|
||||
- 2026-08-17: One wording for an empty password field on every screen that asks
|
||||
for one. The private key export screen said "Password is required." where the
|
||||
other five say "Please enter your password.", the same one-condition-two-
|
||||
wordings split that [#172](https://git.eeqj.de/sneak/AutistMask/issues/172)
|
||||
closed for a rejected password. Strings only, no behaviour change.
|
||||
`tests/passwordMessages.test.js` now pins the empty-field guard per call site
|
||||
as well as the decrypt handler, anchored on the `decryptWithPassword` sites so
|
||||
the wallet-creation screen — where an empty field means a password being
|
||||
chosen, a different condition — stays out of the set. Every error container
|
||||
measured at a 360px viewport in the pinned Playwright container: the export
|
||||
screen's container holds at 20px with the following section at the same offset
|
||||
for the old string, the new string and the empty reserved state
|
||||
([#265](https://git.eeqj.de/sneak/AutistMask/issues/265)).
|
||||
- 2026-08-17: `README.md` no longer advertises a defect the wallet does not
|
||||
have. The End-to-End Tests section listed the EIP-1193 code being dropped in
|
||||
the last hop into the page as a standing limit of the dApp coverage; that
|
||||
|
||||
Reference in New Issue
Block a user