From 8439c2cb315568d0ec16ddf09ff396f550839d11 Mon Sep 17 00:00:00 2001 From: sneak Date: Mon, 17 Aug 2026 06:01:17 +0000 Subject: [PATCH] docs: drop the README limit the EIP-1193 code fix removed (closes #285) The End-to-End Tests section listed, as the third of three standing limits of the dApp coverage, the EIP-1193 error code not surviving the last hop into the page. That stopped being true when `9dcd875` landed (https://git.eeqj.de/sneak/AutistMask/issues/274): the provider now rejects with a `ProviderRpcError` carrying `code`, and the e2e suite asserts the code on the page as well as on the wire. The other two limits are still accurate against the current code and are left alone. --- README.md | 7 ++----- TODO.md | 9 +++++++++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index cb2733a..f88d33f 100644 --- a/README.md +++ b/README.md @@ -185,17 +185,14 @@ to the background — with the message that would carry it required to be presen so that check cannot pass by observing nothing. That last one is the standing floor under [#157](https://git.eeqj.de/sneak/AutistMask/issues/157). -Three limits of that coverage, none of them papered over. The RPC is stubbed +Two limits of that coverage, neither of them papered over. The RPC is stubbed throughout, so this is **not** a real dApp against a real network with real funds; that remains a human pass before 1.0.0. The site-connection prompt is raised through `chrome.action.openPopup()`, and headless Chromium's browser-action popup is not a page Playwright can see or click, so that one prompt is driven at the URL the extension itself puts on the action — the same page and the same approval id, but whether a real toolbar click shows it is not -observable here. And the EIP-1193 error code does not survive the last hop: the -rejection that crosses the boundary carries code 4001 and is asserted to, but -`src/content/inpage.js` rebuilds it as `new Error(message)`, so the calling page -catches an error with no `code` property. +observable here. Any test that drives a failure path on purpose declares the `console.error` it is about to provoke, via `errors.expect()`. That is not a mute: the declaration diff --git a/TODO.md b/TODO.md index 86fd8b7..ec7d000 100644 --- a/TODO.md +++ b/TODO.md @@ -45,6 +45,15 @@ undefined identifiers, which is how # Completed Steps +- 2026-08-17: `README.md` no longer advertises a defect the wallet does not + have. The End-to-End Tests section listed the EIP-1193 code being dropped in + the last hop into the page as a standing limit of the dApp coverage; that + stopped being true when + [#274](https://git.eeqj.de/sneak/AutistMask/issues/274) landed and did not + touch the README. The paragraph is deleted and the two remaining limits — the + stubbed RPC and the unobservable toolbar popup — were checked against the + current `src/content/inpage.js` and `tests/e2e/` and left as they are + ([#285](https://git.eeqj.de/sneak/AutistMask/issues/285)). - 2026-08-12: EIP-1193 error codes now reach the page. `src/content/inpage.js` rebuilt every failure as `new Error(error.message)`, so the code the background produced and the content script relayed intact was dropped in the