feat: show red warning on confirm-tx for addresses with zero tx history
All checks were successful
check / check (push) Successful in 9s
All checks were successful
check / check (push) Successful in 9s
Closes #82 Adds a Blockscout-backed check that warns users when sending to an address with no prior transaction history. The warning appears in red on the confirmation screen. The check is async and fail-open (errors are silently ignored to avoid blocking legitimate transactions).
This commit is contained in:
@@ -25,6 +25,7 @@ const { decryptWithPassword } = require("../../shared/vault");
|
|||||||
const { formatUsd, getPrice } = require("../../shared/prices");
|
const { formatUsd, getPrice } = require("../../shared/prices");
|
||||||
const { getProvider } = require("../../shared/balances");
|
const { getProvider } = require("../../shared/balances");
|
||||||
const { isScamAddress } = require("../../shared/scamlist");
|
const { isScamAddress } = require("../../shared/scamlist");
|
||||||
|
const { hasZeroTxHistory } = require("../../shared/transactions");
|
||||||
const { ERC20_ABI } = require("../../shared/constants");
|
const { ERC20_ABI } = require("../../shared/constants");
|
||||||
const { log } = require("../../shared/log");
|
const { log } = require("../../shared/log");
|
||||||
const makeBlockie = require("ethereum-blockies-base64");
|
const makeBlockie = require("ethereum-blockies-base64");
|
||||||
@@ -244,6 +245,7 @@ function show(txInfo) {
|
|||||||
showView("confirm-tx");
|
showView("confirm-tx");
|
||||||
|
|
||||||
estimateGas(txInfo);
|
estimateGas(txInfo);
|
||||||
|
checkNewAddress(txInfo);
|
||||||
}
|
}
|
||||||
|
|
||||||
async function estimateGas(txInfo) {
|
async function estimateGas(txInfo) {
|
||||||
@@ -286,6 +288,26 @@ async function estimateGas(txInfo) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function checkNewAddress(txInfo) {
|
||||||
|
try {
|
||||||
|
const isNew = await hasZeroTxHistory(txInfo.to, state.blockscoutUrl);
|
||||||
|
if (!isNew) return;
|
||||||
|
// Only append if we're still on the same pending tx
|
||||||
|
if (pendingTx !== txInfo) return;
|
||||||
|
const warningsEl = $("confirm-warnings");
|
||||||
|
const div = document.createElement("div");
|
||||||
|
div.className =
|
||||||
|
"border border-red-500 border-dashed p-2 mb-1 text-xs font-bold text-red-500";
|
||||||
|
div.textContent =
|
||||||
|
"WARNING: This address has ZERO transaction history. " +
|
||||||
|
"Double-check that you have the correct address before sending.";
|
||||||
|
warningsEl.appendChild(div);
|
||||||
|
warningsEl.classList.remove("hidden");
|
||||||
|
} catch (e) {
|
||||||
|
// Fail silently — don't block the transaction
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
function init(ctx) {
|
function init(ctx) {
|
||||||
$("btn-confirm-send").addEventListener("click", async () => {
|
$("btn-confirm-send").addEventListener("click", async () => {
|
||||||
const password = $("confirm-tx-password").value;
|
const password = $("confirm-tx-password").value;
|
||||||
|
|||||||
@@ -251,4 +251,28 @@ function filterTransactions(txs, filters = {}) {
|
|||||||
return { transactions: filtered, newFraudContracts: newFraud };
|
return { transactions: filtered, newFraudContracts: newFraud };
|
||||||
}
|
}
|
||||||
|
|
||||||
module.exports = { fetchRecentTransactions, filterTransactions };
|
// Check whether an address has zero transaction history via Blockscout
|
||||||
|
// counters endpoint. Returns true if the address has never appeared in
|
||||||
|
// any transaction (sent or received), false otherwise. On fetch errors
|
||||||
|
// returns false (fail-open: don't show a spurious warning).
|
||||||
|
async function hasZeroTxHistory(address, blockscoutUrl) {
|
||||||
|
try {
|
||||||
|
const resp = await fetch(
|
||||||
|
blockscoutUrl + "/addresses/" + address + "/counters",
|
||||||
|
);
|
||||||
|
if (!resp.ok) return false;
|
||||||
|
const data = await resp.json();
|
||||||
|
const txCount = parseInt(data.transactions_count || "0", 10);
|
||||||
|
const transferCount = parseInt(data.token_transfers_count || "0", 10);
|
||||||
|
return txCount === 0 && transferCount === 0;
|
||||||
|
} catch (e) {
|
||||||
|
log.errorf("hasZeroTxHistory check failed:", e.message);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
module.exports = {
|
||||||
|
fetchRecentTransactions,
|
||||||
|
filterTransactions,
|
||||||
|
hasZeroTxHistory,
|
||||||
|
};
|
||||||
|
|||||||
Reference in New Issue
Block a user