Merge pull request 'fix: preserve ENS names on lookup failure, add debug logging (closes #22)' (#24) from fix/ens-reverse-lookup into main
All checks were successful
check / check (push) Successful in 8s
All checks were successful
check / check (push) Successful in 8s
Reviewed-on: #24
This commit was merged in pull request #24.
This commit is contained in:
@@ -123,15 +123,27 @@ async function refreshBalances(wallets, rpcUrl, blockscoutUrl, trackedTokens) {
|
|||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
|
|
||||||
// ENS reverse lookup
|
// ENS reverse lookup — only overwrite on success so that
|
||||||
|
// transient RPC errors don't wipe a previously resolved name.
|
||||||
updates.push(
|
updates.push(
|
||||||
provider
|
provider
|
||||||
.lookupAddress(addr.address)
|
.lookupAddress(addr.address)
|
||||||
.then((name) => {
|
.then((name) => {
|
||||||
addr.ensName = name || null;
|
addr.ensName = name || null;
|
||||||
|
log.debugf(
|
||||||
|
"ENS reverse",
|
||||||
|
addr.address,
|
||||||
|
"->",
|
||||||
|
addr.ensName,
|
||||||
|
);
|
||||||
})
|
})
|
||||||
.catch(() => {
|
.catch((e) => {
|
||||||
addr.ensName = null;
|
log.errorf(
|
||||||
|
"ENS reverse failed",
|
||||||
|
addr.address,
|
||||||
|
e.message,
|
||||||
|
);
|
||||||
|
// Keep existing addr.ensName if we had one
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -39,7 +39,7 @@ async function resolveEnsName(address, rpcUrl) {
|
|||||||
return name;
|
return name;
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
log.errorf("ENS reverse lookup failed", address, e.message);
|
log.errorf("ENS reverse lookup failed", address, e.message);
|
||||||
setCache(address, null);
|
// Don't cache failures — let subsequent lookups retry
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user