fix: a tracked token reads quantity unknown at an address no refresh has read (closes #720)
A new address, a new wallet and a network switch each leave tracked tokens with no balance entry, so their lines read 0.0000 before any refresh had read them. Each of these now sets `balanceNotFetched` on the tracked tokens, and a refresh already clears it. Their lines read `quantity unknown` until then. Addresses that the wallet scan finds get the same. A refresh that did not read every address the page now holds leaves the field set. Model: opus-5-5
This commit was merged in pull request #735.
This commit is contained in:
@@ -1200,14 +1200,23 @@ The token's symbol comes from the same places. The bundled list answers for a
|
|||||||
token on Ethereum Mainnet only. When none of them answers, the amount reads
|
token on Ethereum Mainnet only. When none of them answers, the amount reads
|
||||||
`5000000000 base units (decimals unknown)`, and nothing is formatted with
|
`5000000000 base units (decimals unknown)`, and nothing is formatted with
|
||||||
guessed decimals. A holding whose decimals are unknown shows "quantity unknown"
|
guessed decimals. A holding whose decimals are unknown shows "quantity unknown"
|
||||||
in the balance lists. A token just added shows "quantity unknown" in place of a
|
in the balance lists.
|
||||||
zero, until a refresh has read its balance at every address. Only a whole number
|
|
||||||
from 0 to 80 counts as a token's decimals. A token's `decimals` is stored only
|
A tracked token with no stored balance at an address can show "quantity unknown"
|
||||||
as a source reported it, never guessed. A `null` balance means the decimals are
|
there in place of a zero. It does so after each of these:
|
||||||
unknown, never that the balance is zero. While "Use Blockscout" is off, the
|
|
||||||
bundled list and the tracked tokens may lack a token's symbol or decimals. The
|
- the token is added;
|
||||||
approval and status screens then add a line under that token saying that
|
- an address or a wallet is added;
|
||||||
Blockscout's report is not used.
|
- the network is switched.
|
||||||
|
|
||||||
|
This lasts until a refresh has read the token's balance at every address.
|
||||||
|
|
||||||
|
Only a whole number from 0 to 80 counts as a token's decimals. A token's
|
||||||
|
`decimals` is stored only as a source reported it, never guessed. A `null`
|
||||||
|
balance means the decimals are unknown, never that the balance is zero. While
|
||||||
|
"Use Blockscout" is off, the bundled list and the tracked tokens may lack a
|
||||||
|
token's symbol or decimals. The approval and status screens then add a line
|
||||||
|
under that token saying that Blockscout's report is not used.
|
||||||
|
|
||||||
The wallet's own ERC-20 send is encoded with the decimals the screen showed. At
|
The wallet's own ERC-20 send is encoded with the decimals the screen showed. At
|
||||||
signing time the contract's `decimals()` is read only to be compared with those.
|
signing time the contract's `decimals()` is read only to be compared with those.
|
||||||
|
|||||||
+8
-3
@@ -98,8 +98,10 @@ let refreshTimer = null;
|
|||||||
// not tracked if the stored setting is off by then.
|
// not tracked if the stored setting is off by then.
|
||||||
//
|
//
|
||||||
// The save also deletes `balanceNotFetched` from each tracked token whose
|
// The save also deletes `balanceNotFetched` from each tracked token whose
|
||||||
// balance this refresh read at every address. trackToken() in
|
// balance this refresh read at every address. A refresh that did not read every
|
||||||
// src/popup/views/helpers.js sets that field. The save takes the field off the
|
// address this page now holds deletes no `balanceNotFetched`. Adding a token
|
||||||
|
// sets that field (trackToken() in src/popup/views/helpers.js). So does adding
|
||||||
|
// an address, and so does a network switch. The save takes the field off the
|
||||||
// matching tokens of the stored record (clearBalanceNotFetched() in
|
// matching tokens of the stored record (clearBalanceNotFetched() in
|
||||||
// src/shared/state.js). The rest of the stored tracked token list stays as it
|
// src/shared/state.js). The rest of the stored tracked token list stays as it
|
||||||
// is.
|
// is.
|
||||||
@@ -149,7 +151,10 @@ async function doRefreshAndRender() {
|
|||||||
if (!stored.useBlockscout) {
|
if (!stored.useBlockscout) {
|
||||||
dropUntrackedTokens(state.wallets, stored.trackedTokens);
|
dropUntrackedTokens(state.wallets, stored.trackedTokens);
|
||||||
}
|
}
|
||||||
clearBalanceNotFetched(stored, readTokens);
|
const readEveryAddress = state.wallets.every((wallet) =>
|
||||||
|
wallet.addresses.every((addr) => refreshed.has(addr.address)),
|
||||||
|
);
|
||||||
|
if (readEveryAddress) clearBalanceNotFetched(stored, readTokens);
|
||||||
state.lastBalanceRefresh = Date.now();
|
state.lastBalanceRefresh = Date.now();
|
||||||
return true;
|
return true;
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ const {
|
|||||||
goBack,
|
goBack,
|
||||||
clearViewStack,
|
clearViewStack,
|
||||||
onViewLeave,
|
onViewLeave,
|
||||||
|
markTrackedTokensNotFetched,
|
||||||
} = require("./helpers");
|
} = require("./helpers");
|
||||||
const {
|
const {
|
||||||
generateMnemonic,
|
generateMnemonic,
|
||||||
@@ -195,6 +196,7 @@ async function importMnemonic(ctx) {
|
|||||||
],
|
],
|
||||||
};
|
};
|
||||||
state.wallets.push(wallet);
|
state.wallets.push(wallet);
|
||||||
|
markTrackedTokensNotFetched();
|
||||||
state.hasWallet = true;
|
state.hasWallet = true;
|
||||||
if (state.activeAddress === null) {
|
if (state.activeAddress === null) {
|
||||||
state.activeAddress = firstAddress;
|
state.activeAddress = firstAddress;
|
||||||
@@ -220,6 +222,7 @@ async function importMnemonic(ctx) {
|
|||||||
tokenBalances: [],
|
tokenBalances: [],
|
||||||
}));
|
}));
|
||||||
wallet.nextIndex = scan.nextIndex;
|
wallet.nextIndex = scan.nextIndex;
|
||||||
|
markTrackedTokensNotFetched();
|
||||||
// The new list leaves out the first address when the scan found it
|
// The new list leaves out the first address when the scan found it
|
||||||
// unused. If it was the active one, the new list's first takes over,
|
// unused. If it was the active one, the new list's first takes over,
|
||||||
// and the background is told as when the user picks one on Home.
|
// and the background is told as when the user picks one on Home.
|
||||||
@@ -266,6 +269,7 @@ async function importPrivateKey(ctx) {
|
|||||||
encryptedSecret: encrypted,
|
encryptedSecret: encrypted,
|
||||||
addresses: [{ address: addr, balance: "0.0000", tokenBalances: [] }],
|
addresses: [{ address: addr, balance: "0.0000", tokenBalances: [] }],
|
||||||
});
|
});
|
||||||
|
markTrackedTokensNotFetched();
|
||||||
state.hasWallet = true;
|
state.hasWallet = true;
|
||||||
if (state.activeAddress === null) {
|
if (state.activeAddress === null) {
|
||||||
state.activeAddress = addr;
|
state.activeAddress = addr;
|
||||||
@@ -330,6 +334,7 @@ async function importXprvKey(ctx) {
|
|||||||
],
|
],
|
||||||
};
|
};
|
||||||
state.wallets.push(wallet);
|
state.wallets.push(wallet);
|
||||||
|
markTrackedTokensNotFetched();
|
||||||
state.hasWallet = true;
|
state.hasWallet = true;
|
||||||
if (state.activeAddress === null) {
|
if (state.activeAddress === null) {
|
||||||
state.activeAddress = firstAddress;
|
state.activeAddress = firstAddress;
|
||||||
@@ -355,6 +360,7 @@ async function importXprvKey(ctx) {
|
|||||||
tokenBalances: [],
|
tokenBalances: [],
|
||||||
}));
|
}));
|
||||||
wallet.nextIndex = scan.nextIndex;
|
wallet.nextIndex = scan.nextIndex;
|
||||||
|
markTrackedTokensNotFetched();
|
||||||
// As for a recovery phrase: an active first address the scan left
|
// As for a recovery phrase: an active first address the scan left
|
||||||
// out gives way to the new list's first.
|
// out gives way to the new list's first.
|
||||||
const activeMoved =
|
const activeMoved =
|
||||||
|
|||||||
@@ -172,8 +172,8 @@ function renderBalance() {
|
|||||||
(t) => t.address.toLowerCase() === id,
|
(t) => t.address.toLowerCase() === id,
|
||||||
);
|
);
|
||||||
// null when the scale is unknown, or when no refresh has read the
|
// null when the scale is unknown, or when no refresh has read the
|
||||||
// balance of a token just added: no quantity to show, and none to
|
// token's balance: no quantity to show, and none to price.
|
||||||
// price. balanceLine() states that rather than printing 0.0000.
|
// balanceLine() states that rather than printing 0.0000.
|
||||||
if (tb) amount = unknownableAmount(tb.balance);
|
if (tb) amount = unknownableAmount(tb.balance);
|
||||||
else amount = tracked && tracked.balanceNotFetched ? null : 0;
|
else amount = tracked && tracked.balanceNotFetched ? null : 0;
|
||||||
price = getPrice(tokenId);
|
price = getPrice(tokenId);
|
||||||
|
|||||||
@@ -430,6 +430,13 @@ function trackToken(token) {
|
|||||||
state.trackedTokens.push({ ...token, balanceNotFetched: true });
|
state.trackedTokens.push({ ...token, balanceNotFetched: true });
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Gives every tracked token `balanceNotFetched: true`, as trackToken() gives a
|
||||||
|
// new one. Called when an address is added, before the save: no refresh has
|
||||||
|
// read any token's balance at that address.
|
||||||
|
function markTrackedTokensNotFetched() {
|
||||||
|
for (const token of state.trackedTokens) token.balanceNotFetched = true;
|
||||||
|
}
|
||||||
|
|
||||||
function balanceLinesForAddress(addr, trackedTokens, showZero) {
|
function balanceLinesForAddress(addr, trackedTokens, showZero) {
|
||||||
let html = balanceLine(
|
let html = balanceLine(
|
||||||
nativeCurrency(),
|
nativeCurrency(),
|
||||||
@@ -850,6 +857,7 @@ module.exports = {
|
|||||||
balanceLine,
|
balanceLine,
|
||||||
balanceLinesForAddress,
|
balanceLinesForAddress,
|
||||||
trackToken,
|
trackToken,
|
||||||
|
markTrackedTokensNotFetched,
|
||||||
addressHoldsFunds,
|
addressHoldsFunds,
|
||||||
keyMaterialName,
|
keyMaterialName,
|
||||||
unknownableAmount,
|
unknownableAmount,
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ const {
|
|||||||
showView,
|
showView,
|
||||||
showFlash,
|
showFlash,
|
||||||
balanceLinesForAddress,
|
balanceLinesForAddress,
|
||||||
|
markTrackedTokensNotFetched,
|
||||||
isoDate,
|
isoDate,
|
||||||
timeAgo,
|
timeAgo,
|
||||||
addressDotHtml,
|
addressDotHtml,
|
||||||
@@ -394,6 +395,7 @@ function render(ctx) {
|
|||||||
tokenBalances: [],
|
tokenBalances: [],
|
||||||
});
|
});
|
||||||
wallet.nextIndex++;
|
wallet.nextIndex++;
|
||||||
|
markTrackedTokensNotFetched();
|
||||||
await saveState();
|
await saveState();
|
||||||
render(ctx);
|
render(ctx);
|
||||||
ctx.doRefreshAndRender();
|
ctx.doRefreshAndRender();
|
||||||
|
|||||||
@@ -242,10 +242,11 @@ function updateSendBalance() {
|
|||||||
state.trackedTokens,
|
state.trackedTokens,
|
||||||
currentNetwork().chainId,
|
currentNetwork().chainId,
|
||||||
);
|
);
|
||||||
// A null balance is a holding whose scale is unknown. Saying a figure
|
// A null balance is a holding whose scale is unknown, or a tracked
|
||||||
// for it would be a claim about the amount, so it reads as the
|
// token whose balance no refresh has read. Saying a figure for it would
|
||||||
// confirmation screen's balance line reads it; the send itself is
|
// be a claim about the amount, so it reads as the confirmation screen's
|
||||||
// refused later by transferAmountUnits() for the same missing scale.
|
// balance line reads it. transferAmountUnits() later refuses a send at
|
||||||
|
// a missing scale.
|
||||||
const bal = tokenBalanceAndDecimals(addr, token).tokenBalance;
|
const bal = tokenBalanceAndDecimals(addr, token).tokenBalance;
|
||||||
$("send-balance").textContent =
|
$("send-balance").textContent =
|
||||||
bal == null
|
bal == null
|
||||||
|
|||||||
@@ -48,9 +48,14 @@ function applyChainSwitchFields(s, newNetworkId) {
|
|||||||
// It is a copy because a save writes a changed s.networkTrackedTokens whole,
|
// It is a copy because a save writes a changed s.networkTrackedTokens whole,
|
||||||
// over any list another page stored. An add or removal on the active network
|
// over any list another page stored. An add or removal on the active network
|
||||||
// must change only s.trackedTokens.
|
// must change only s.trackedTokens.
|
||||||
|
//
|
||||||
|
// Each token of the copy gets `balanceNotFetched`, because the balances are
|
||||||
|
// cleared below and no refresh has read this network's yet. Each reads
|
||||||
|
// `quantity unknown` until one has, not 0.0000.
|
||||||
if (!s.networkTrackedTokens) s.networkTrackedTokens = {};
|
if (!s.networkTrackedTokens) s.networkTrackedTokens = {};
|
||||||
s.networkTrackedTokens[s.networkId] = s.trackedTokens;
|
s.networkTrackedTokens[s.networkId] = s.trackedTokens;
|
||||||
s.trackedTokens = structuredClone(s.networkTrackedTokens[net.id] || []);
|
s.trackedTokens = structuredClone(s.networkTrackedTokens[net.id] || []);
|
||||||
|
for (const token of s.trackedTokens) token.balanceNotFetched = true;
|
||||||
|
|
||||||
s.networkId = net.id;
|
s.networkId = net.id;
|
||||||
s.rpcUrl = remembered.rpcUrl || net.defaultRpcUrl;
|
s.rpcUrl = remembered.rpcUrl || net.defaultRpcUrl;
|
||||||
|
|||||||
@@ -11,14 +11,44 @@
|
|||||||
// switch keeps each network's records apart. A refresh takes the field off the
|
// switch keeps each network's records apart. A refresh takes the field off the
|
||||||
// stored record's tokens and keeps another page's changes to the stored list.
|
// stored record's tokens and keeps another page's changes to the stored list.
|
||||||
//
|
//
|
||||||
|
// Every tracked token carries that field again once an address or a wallet is
|
||||||
|
// added, and after a network switch, so it reads the same until a refresh has
|
||||||
|
// read it (https://git.eeqj.de/sneak/AutistMask/issues/720).
|
||||||
|
//
|
||||||
// Driven through the real popup over a stored profile on Ethereum Mainnet,
|
// Driven through the real popup over a stored profile on Ethereum Mainnet,
|
||||||
// with "Show tracked tokens with zero balance" on, as it is by default.
|
// with "Show tracked tokens with zero balance" on, as it is by default.
|
||||||
|
|
||||||
|
const { HDNodeWallet, Mnemonic } = require("ethers");
|
||||||
|
|
||||||
const {
|
const {
|
||||||
bootPopup,
|
bootPopup,
|
||||||
cleanupPopup,
|
cleanupPopup,
|
||||||
unversionedValidProfile,
|
unversionedValidProfile,
|
||||||
} = require("./support/popupBoot");
|
} = require("./support/popupBoot");
|
||||||
|
const { hdWalletFromMnemonic } = require("../src/shared/wallet");
|
||||||
|
|
||||||
|
const PHRASE =
|
||||||
|
"abandon abandon abandon abandon abandon abandon " +
|
||||||
|
"abandon abandon abandon abandon abandon about";
|
||||||
|
const PASSWORD = "correct horse battery staple";
|
||||||
|
|
||||||
|
// What AddWallet's tabs take. The first and last scan for more addresses.
|
||||||
|
const FROM_PHRASE = {
|
||||||
|
tab: "tab-mnemonic",
|
||||||
|
field: "wallet-mnemonic",
|
||||||
|
secret: PHRASE,
|
||||||
|
};
|
||||||
|
const FROM_PRIVATE_KEY = {
|
||||||
|
tab: "tab-privkey",
|
||||||
|
field: "import-private-key",
|
||||||
|
secret: "0x" + "11".repeat(32),
|
||||||
|
};
|
||||||
|
const FROM_XPRV = {
|
||||||
|
tab: "tab-xprv",
|
||||||
|
field: "import-xprv-key",
|
||||||
|
secret: HDNodeWallet.fromSeed(Mnemonic.fromPhrase(PHRASE).computeSeed())
|
||||||
|
.extendedKey,
|
||||||
|
};
|
||||||
|
|
||||||
// Tracked by nobody until a test adds it.
|
// Tracked by nobody until a test adds it.
|
||||||
const NEW_TOKEN = "0xBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB";
|
const NEW_TOKEN = "0xBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB";
|
||||||
@@ -66,6 +96,34 @@ function bootOnAddress(extra) {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// The popup over one wallet that "+" can derive an address from. Its one
|
||||||
|
// address holds a million NEW_TOKEN, and NEW_TOKEN is tracked.
|
||||||
|
function bootOnDerivingWallet() {
|
||||||
|
const { xpub, firstAddress } = hdWalletFromMnemonic(PHRASE);
|
||||||
|
return bootPopup(
|
||||||
|
unversionedValidProfile({
|
||||||
|
wallets: [
|
||||||
|
{
|
||||||
|
type: "hd",
|
||||||
|
name: "Wallet 1",
|
||||||
|
xpub,
|
||||||
|
encryptedSecret: "encrypted-secret-1",
|
||||||
|
nextIndex: 1,
|
||||||
|
addresses: [
|
||||||
|
{
|
||||||
|
address: firstAddress,
|
||||||
|
balance: "1.5",
|
||||||
|
tokenBalances: [MILLION],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
activeAddress: firstAddress,
|
||||||
|
trackedTokens: [NEW_TRACKED],
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
// Holds the next balance refresh open. The returned function lets it finish
|
// Holds the next balance refresh open. The returned function lets it finish
|
||||||
// with the address's ETH balance at 2 and `tokenBalances` as its token
|
// with the address's ETH balance at 2 and `tokenBalances` as its token
|
||||||
// entries, having read the balance of every token tracked when it started.
|
// entries, having read the balance of every token tracked when it started.
|
||||||
@@ -175,6 +233,47 @@ function newTokenRow(page, id = "address-balances") {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Every address's row for NEW_TOKEN on Home, as markup, in the order Home lists
|
||||||
|
// the addresses.
|
||||||
|
function newTokenRowsOnHome(page) {
|
||||||
|
return page
|
||||||
|
.node("wallet-list")
|
||||||
|
.innerHTML.split("<div ")
|
||||||
|
.filter((row) =>
|
||||||
|
row.includes('data-token="' + NEW_TOKEN.toLowerCase() + '"'),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
// The "+" button Home draws for the first wallet. As in firstRemoveButton(),
|
||||||
|
// the list hands Home a stand-in for that button each time it is drawn, and
|
||||||
|
// `press()` presses the last one drawn. Call it before Home next draws its list.
|
||||||
|
function plusButton(page) {
|
||||||
|
const button = { press: null };
|
||||||
|
page.node("wallet-list").querySelectorAll = (selector) =>
|
||||||
|
selector !== ".btn-add-address"
|
||||||
|
? []
|
||||||
|
: [
|
||||||
|
{
|
||||||
|
dataset: { wallet: "0" },
|
||||||
|
addEventListener: (name, fn) => {
|
||||||
|
button.press = () =>
|
||||||
|
fn({ stopPropagation: () => {} });
|
||||||
|
},
|
||||||
|
},
|
||||||
|
];
|
||||||
|
return button;
|
||||||
|
}
|
||||||
|
|
||||||
|
// "Add wallet" on Home, filled in from `source`, and "Import".
|
||||||
|
async function addWallet(page, { tab, field, secret }) {
|
||||||
|
await page.click("btn-add-wallet-bottom");
|
||||||
|
await page.click(tab);
|
||||||
|
page.node(field).value = secret;
|
||||||
|
page.node("add-wallet-password").value = PASSWORD;
|
||||||
|
page.node("add-wallet-password-confirm").value = PASSWORD;
|
||||||
|
await page.click("btn-add-wallet-confirm");
|
||||||
|
}
|
||||||
|
|
||||||
// AddressDetail for the one address opened from Home, as its `[info]` button
|
// AddressDetail for the one address opened from Home, as its `[info]` button
|
||||||
// does.
|
// does.
|
||||||
async function openAddress(page) {
|
async function openAddress(page) {
|
||||||
@@ -456,3 +555,208 @@ test("a refresh does not bring back a token that another page removed after this
|
|||||||
NEW_TRACKED,
|
NEW_TRACKED,
|
||||||
]);
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("an address just added reads quantity unknown for a tracked token until a refresh has read it", async () => {
|
||||||
|
const page = await bootOnDerivingWallet();
|
||||||
|
const plus = plusButton(page);
|
||||||
|
await refreshOnce(page, [MILLION]);
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
|
||||||
|
await plus.press();
|
||||||
|
await page.settle();
|
||||||
|
|
||||||
|
const [held, added] = newTokenRowsOnHome(page);
|
||||||
|
expect(held).toContain("1000000.0000");
|
||||||
|
expect(added).toContain("quantity unknown");
|
||||||
|
expect(added).not.toContain("0.0000");
|
||||||
|
expect(
|
||||||
|
page.storage.read("autistmask").trackedTokens[0].balanceNotFetched,
|
||||||
|
).toBe(true);
|
||||||
|
|
||||||
|
// It reads the new address's balance, which is zero.
|
||||||
|
await finish([MILLION]);
|
||||||
|
|
||||||
|
expect(newTokenRowsOnHome(page)[1]).toContain("0.0000");
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an address "+" adds during a refresh reads quantity unknown when that refresh returns', async () => {
|
||||||
|
const page = await bootOnDerivingWallet();
|
||||||
|
const plus = plusButton(page);
|
||||||
|
await refreshOnce(page, [MILLION]);
|
||||||
|
const finishRunning = holdNextRefresh(page);
|
||||||
|
const ticking = page.tick();
|
||||||
|
await page.settle();
|
||||||
|
|
||||||
|
await plus.press();
|
||||||
|
await page.settle();
|
||||||
|
const finishNext = holdNextRefresh(page);
|
||||||
|
await finishRunning([MILLION]);
|
||||||
|
await ticking;
|
||||||
|
|
||||||
|
const added = newTokenRowsOnHome(page)[1];
|
||||||
|
expect(added).toContain("quantity unknown");
|
||||||
|
expect(added).not.toContain("0.0000");
|
||||||
|
|
||||||
|
// It reads the new address's balance, which is zero.
|
||||||
|
await finishNext([MILLION]);
|
||||||
|
|
||||||
|
expect(newTokenRowsOnHome(page)[1]).toContain("0.0000");
|
||||||
|
});
|
||||||
|
|
||||||
|
test.each([FROM_PHRASE, FROM_PRIVATE_KEY, FROM_XPRV])(
|
||||||
|
"a wallet just added from $tab reads quantity unknown for a tracked token until a refresh has read it",
|
||||||
|
async (source) => {
|
||||||
|
const page = await bootPopup(
|
||||||
|
unversionedValidProfile({ trackedTokens: [NEW_TRACKED] }),
|
||||||
|
);
|
||||||
|
const finish = holdNextRefresh(page);
|
||||||
|
|
||||||
|
await addWallet(page, source);
|
||||||
|
|
||||||
|
const added = newTokenRowsOnHome(page)[1];
|
||||||
|
expect(added).toContain("quantity unknown");
|
||||||
|
expect(added).not.toContain("0.0000");
|
||||||
|
|
||||||
|
// It reads the new address's balance, which is zero.
|
||||||
|
await finish([]);
|
||||||
|
|
||||||
|
expect(newTokenRowsOnHome(page)[1]).toContain("0.0000");
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
test("a wallet from a private key added during a refresh reads quantity unknown when that refresh returns", async () => {
|
||||||
|
const page = await bootPopup(
|
||||||
|
unversionedValidProfile({ trackedTokens: [NEW_TRACKED] }),
|
||||||
|
);
|
||||||
|
const finishRunning = holdNextRefresh(page);
|
||||||
|
const ticking = page.tick();
|
||||||
|
await page.settle();
|
||||||
|
|
||||||
|
await addWallet(page, FROM_PRIVATE_KEY);
|
||||||
|
const finishNext = holdNextRefresh(page);
|
||||||
|
await finishRunning([]);
|
||||||
|
await ticking;
|
||||||
|
|
||||||
|
const added = newTokenRowsOnHome(page)[1];
|
||||||
|
expect(added).toContain("quantity unknown");
|
||||||
|
expect(added).not.toContain("0.0000");
|
||||||
|
|
||||||
|
// It reads the new address's balance, which is zero.
|
||||||
|
await finishNext([]);
|
||||||
|
|
||||||
|
expect(newTokenRowsOnHome(page)[1]).toContain("0.0000");
|
||||||
|
});
|
||||||
|
|
||||||
|
test.each([FROM_PHRASE, FROM_XPRV])(
|
||||||
|
"addresses the scan finds for a wallet from $tab read quantity unknown, even after a refresh returned during the scan",
|
||||||
|
async (source) => {
|
||||||
|
const page = await bootPopup(
|
||||||
|
unversionedValidProfile({ trackedTokens: [NEW_TRACKED] }),
|
||||||
|
);
|
||||||
|
const { scanForAddresses } = require("../src/shared/balances");
|
||||||
|
let finish;
|
||||||
|
scanForAddresses.mockImplementationOnce(async () => {
|
||||||
|
await refreshOnce(page, []);
|
||||||
|
finish = holdNextRefresh(page);
|
||||||
|
return {
|
||||||
|
addresses: [
|
||||||
|
{ address: "0x" + "dd".repeat(20), index: 0 },
|
||||||
|
{ address: "0x" + "ee".repeat(20), index: 1 },
|
||||||
|
],
|
||||||
|
nextIndex: 2,
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
await addWallet(page, source);
|
||||||
|
|
||||||
|
const [, first, second] = newTokenRowsOnHome(page);
|
||||||
|
for (const found of [first, second]) {
|
||||||
|
expect(found).toContain("quantity unknown");
|
||||||
|
expect(found).not.toContain("0.0000");
|
||||||
|
}
|
||||||
|
|
||||||
|
await finish([]);
|
||||||
|
|
||||||
|
expect(newTokenRowsOnHome(page)[2]).toContain("0.0000");
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
test.each([FROM_PHRASE, FROM_XPRV])(
|
||||||
|
"addresses the scan finds for a wallet from $tab read quantity unknown when a refresh running as the scan ends returns",
|
||||||
|
async (source) => {
|
||||||
|
const page = await bootPopup(
|
||||||
|
unversionedValidProfile({ trackedTokens: [NEW_TRACKED] }),
|
||||||
|
);
|
||||||
|
const { scanForAddresses } = require("../src/shared/balances");
|
||||||
|
let finishRunning;
|
||||||
|
let ticking;
|
||||||
|
scanForAddresses.mockImplementationOnce(async () => {
|
||||||
|
finishRunning = holdNextRefresh(page);
|
||||||
|
ticking = page.tick();
|
||||||
|
await page.settle();
|
||||||
|
return {
|
||||||
|
addresses: [
|
||||||
|
{ address: "0x" + "dd".repeat(20), index: 0 },
|
||||||
|
{ address: "0x" + "ee".repeat(20), index: 1 },
|
||||||
|
],
|
||||||
|
nextIndex: 2,
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
await addWallet(page, source);
|
||||||
|
const finishNext = holdNextRefresh(page);
|
||||||
|
await finishRunning([]);
|
||||||
|
await ticking;
|
||||||
|
|
||||||
|
const [, first, second] = newTokenRowsOnHome(page);
|
||||||
|
for (const found of [first, second]) {
|
||||||
|
expect(found).toContain("quantity unknown");
|
||||||
|
expect(found).not.toContain("0.0000");
|
||||||
|
}
|
||||||
|
|
||||||
|
// It reads the new addresses' balances, which are zero.
|
||||||
|
await finishNext([]);
|
||||||
|
|
||||||
|
expect(newTokenRowsOnHome(page)[2]).toContain("0.0000");
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
test("after a network switch in Settings, a tracked token reads quantity unknown until a refresh has read it", async () => {
|
||||||
|
const page = await bootOnAddress({
|
||||||
|
trackedTokens: [OTHER_TOKEN],
|
||||||
|
networkTrackedTokens: { sepolia: [NEW_TRACKED] },
|
||||||
|
});
|
||||||
|
|
||||||
|
await page.click("btn-settings");
|
||||||
|
await chooseNetwork(page, "sepolia");
|
||||||
|
await page.click("btn-settings-back");
|
||||||
|
|
||||||
|
expect(page.visibleViews()).toEqual(["address"]);
|
||||||
|
const row = newTokenRow(page);
|
||||||
|
expect(row).toContain("quantity unknown");
|
||||||
|
expect(row).not.toContain("0.0000");
|
||||||
|
|
||||||
|
// It reads the balance, which is zero.
|
||||||
|
await refreshOnce(page, []);
|
||||||
|
|
||||||
|
expect(newTokenRow(page)).toContain("0.0000");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("after a switch saved by the background, a tracked token reads quantity unknown until a refresh has read it", async () => {
|
||||||
|
const page = await bootOnAddress({
|
||||||
|
networkTrackedTokens: { sepolia: [NEW_TRACKED] },
|
||||||
|
});
|
||||||
|
const {
|
||||||
|
applyChainSwitchFields,
|
||||||
|
} = require("../src/shared/chainSwitchFields");
|
||||||
|
const record = page.storage.read("autistmask");
|
||||||
|
applyChainSwitchFields(record, "sepolia");
|
||||||
|
page.storage.write("autistmask", record);
|
||||||
|
|
||||||
|
// The popup takes the switch, and this refresh reads no token's balance.
|
||||||
|
await page.tick();
|
||||||
|
|
||||||
|
const row = newTokenRow(page);
|
||||||
|
expect(row).toContain("quantity unknown");
|
||||||
|
expect(row).not.toContain("0.0000");
|
||||||
|
});
|
||||||
|
|||||||
@@ -44,6 +44,7 @@ jest.doMock("../src/popup/views/helpers", () => ({
|
|||||||
goBack: () => {},
|
goBack: () => {},
|
||||||
clearViewStack: () => {},
|
clearViewStack: () => {},
|
||||||
onViewLeave: () => {},
|
onViewLeave: () => {},
|
||||||
|
markTrackedTokensNotFetched: () => {},
|
||||||
}));
|
}));
|
||||||
|
|
||||||
// state.js reads chrome.storage.local at load, and saveState() writes it.
|
// state.js reads chrome.storage.local at load, and saveState() writes it.
|
||||||
|
|||||||
@@ -242,7 +242,12 @@ describe("a chain switch on a worker that never loaded state", () => {
|
|||||||
expect(bg.persisted().blockscoutUrl).toBe(CUSTOM_BLOCKSCOUT);
|
expect(bg.persisted().blockscoutUrl).toBe(CUSTOM_BLOCKSCOUT);
|
||||||
expect(bg.persisted().wallets).toEqual(walletFixture());
|
expect(bg.persisted().wallets).toEqual(walletFixture());
|
||||||
expect(bg.persisted().trackedTokens).toEqual([
|
expect(bg.persisted().trackedTokens).toEqual([
|
||||||
{ address: TOKEN, symbol: "DAI", decimals: 18 },
|
{
|
||||||
|
address: TOKEN,
|
||||||
|
symbol: "DAI",
|
||||||
|
decimals: 18,
|
||||||
|
balanceNotFetched: true,
|
||||||
|
},
|
||||||
]);
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -245,7 +245,9 @@ test("a switch back in Settings after a follow whose write failed is stored", as
|
|||||||
const stored = page.storage.read("autistmask");
|
const stored = page.storage.read("autistmask");
|
||||||
expect(stored.networkId).toBe("mainnet");
|
expect(stored.networkId).toBe("mainnet");
|
||||||
expect(stored.rpcUrl).toBe(NETWORKS.mainnet.defaultRpcUrl);
|
expect(stored.rpcUrl).toBe(NETWORKS.mainnet.defaultRpcUrl);
|
||||||
expect(stored.trackedTokens).toEqual([MAINNET_TOKEN]);
|
expect(stored.trackedTokens).toEqual([
|
||||||
|
{ ...MAINNET_TOKEN, balanceNotFetched: true },
|
||||||
|
]);
|
||||||
expect(page.text("flash-msg")).toBe("Switched to Ethereum Mainnet.");
|
expect(page.text("flash-msg")).toBe("Switched to Ethereum Mainnet.");
|
||||||
const told = globalThis.chrome.runtime.sendMessage.mock.calls
|
const told = globalThis.chrome.runtime.sendMessage.mock.calls
|
||||||
.map(([message]) => message)
|
.map(([message]) => message)
|
||||||
|
|||||||
@@ -180,7 +180,10 @@ test("a token added by contract address on Sepolia is tracked on Sepolia only",
|
|||||||
await boot.click("btn-settings");
|
await boot.click("btn-settings");
|
||||||
await chooseNetwork(boot, "mainnet");
|
await chooseNetwork(boot, "mainnet");
|
||||||
expect(stored().networkId).toBe("mainnet");
|
expect(stored().networkId).toBe("mainnet");
|
||||||
expect(stored().trackedTokens).toEqual([MAINNET_TOKEN]);
|
// No refresh has read a balance on this network since the switch.
|
||||||
|
expect(stored().trackedTokens).toEqual([
|
||||||
|
{ ...MAINNET_TOKEN, balanceNotFetched: true },
|
||||||
|
]);
|
||||||
const onMainnet = boot.node("settings-tracked-tokens").innerHTML;
|
const onMainnet = boot.node("settings-tracked-tokens").innerHTML;
|
||||||
expect(onMainnet).toContain("DAI");
|
expect(onMainnet).toContain("DAI");
|
||||||
expect(onMainnet).not.toContain("TST");
|
expect(onMainnet).not.toContain("TST");
|
||||||
@@ -276,7 +279,9 @@ test("a token tracked on Sepolia when another page switched there is not tracked
|
|||||||
|
|
||||||
const stored = boot.storage.read("autistmask");
|
const stored = boot.storage.read("autistmask");
|
||||||
expect(stored.networkId).toBe("sepolia");
|
expect(stored.networkId).toBe("sepolia");
|
||||||
expect(stored.trackedTokens).toEqual([SEPOLIA_TOKEN]);
|
expect(stored.trackedTokens).toEqual([
|
||||||
|
{ ...SEPOLIA_TOKEN, balanceNotFetched: true },
|
||||||
|
]);
|
||||||
expect(stored.networkTrackedTokens.mainnet).toEqual([]);
|
expect(stored.networkTrackedTokens.mainnet).toEqual([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -441,7 +446,10 @@ test("a token another page added on Ethereum Mainnet is tracked when this page s
|
|||||||
|
|
||||||
const stored = boot.storage.read("autistmask");
|
const stored = boot.storage.read("autistmask");
|
||||||
expect(stored.networkId).toBe("mainnet");
|
expect(stored.networkId).toBe("mainnet");
|
||||||
expect(stored.trackedTokens).toEqual([MAINNET_TOKEN, newToken]);
|
expect(stored.trackedTokens).toEqual([
|
||||||
|
{ ...MAINNET_TOKEN, balanceNotFetched: true },
|
||||||
|
{ ...newToken, balanceNotFetched: true },
|
||||||
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// This page tracks DAI on Ethereum Mainnet and switches to Sepolia. Another
|
// This page tracks DAI on Ethereum Mainnet and switches to Sepolia. Another
|
||||||
@@ -489,7 +497,10 @@ test("a token another page added on Ethereum Mainnet stays when this page adds a
|
|||||||
const stored = boot.storage.read("autistmask");
|
const stored = boot.storage.read("autistmask");
|
||||||
expect(stored.networkTrackedTokens.mainnet).toEqual([MAINNET_TOKEN]);
|
expect(stored.networkTrackedTokens.mainnet).toEqual([MAINNET_TOKEN]);
|
||||||
expect(stored.networkTrackedTokens.sepolia).toEqual([SEPOLIA_TOKEN]);
|
expect(stored.networkTrackedTokens.sepolia).toEqual([SEPOLIA_TOKEN]);
|
||||||
expect(stored.trackedTokens).toEqual([SEPOLIA_TOKEN, added]);
|
expect(stored.trackedTokens).toEqual([
|
||||||
|
{ ...SEPOLIA_TOKEN, balanceNotFetched: true },
|
||||||
|
added,
|
||||||
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// This page tracks DAI on Ethereum Mainnet and switches to Sepolia, where TST is
|
// This page tracks DAI on Ethereum Mainnet and switches to Sepolia, where TST is
|
||||||
@@ -513,7 +524,10 @@ test("a token another page removed on Ethereum Mainnet stays removed when this p
|
|||||||
const stored = boot.storage.read("autistmask");
|
const stored = boot.storage.read("autistmask");
|
||||||
expect(stored.networkTrackedTokens.mainnet).toEqual([]);
|
expect(stored.networkTrackedTokens.mainnet).toEqual([]);
|
||||||
expect(stored.networkTrackedTokens.sepolia).toEqual([SEPOLIA_TOKEN]);
|
expect(stored.networkTrackedTokens.sepolia).toEqual([SEPOLIA_TOKEN]);
|
||||||
expect(stored.trackedTokens).toEqual([SEPOLIA_TOKEN, added]);
|
expect(stored.trackedTokens).toEqual([
|
||||||
|
{ ...SEPOLIA_TOKEN, balanceNotFetched: true },
|
||||||
|
added,
|
||||||
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Another popup page records a fraud contract on Ethereum Mainnet after this
|
// Another popup page records a fraud contract on Ethereum Mainnet after this
|
||||||
@@ -1031,7 +1045,9 @@ describe("a contract lookup that answers after a switch adds nothing", () => {
|
|||||||
await addAcrossSwitch(boot, "btn-settings-addtoken-manual", "mainnet");
|
await addAcrossSwitch(boot, "btn-settings-addtoken-manual", "mainnet");
|
||||||
expect(boot.visibleViews()).toEqual(["settings"]);
|
expect(boot.visibleViews()).toEqual(["settings"]);
|
||||||
expect(boot.text("flash-msg")).toBe(NETWORK_CHANGED_FLASH);
|
expect(boot.text("flash-msg")).toBe(NETWORK_CHANGED_FLASH);
|
||||||
expect(stored().trackedTokens).toEqual([MAINNET_TOKEN]);
|
expect(stored().trackedTokens).toEqual([
|
||||||
|
{ ...MAINNET_TOKEN, balanceNotFetched: true },
|
||||||
|
]);
|
||||||
expect(stored().networkTrackedTokens.sepolia).toEqual([]);
|
expect(stored().networkTrackedTokens.sepolia).toEqual([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -1044,7 +1060,9 @@ describe("a contract lookup that answers after a switch adds nothing", () => {
|
|||||||
await addAcrossSwitch(boot, "btn-add-token-confirm", "sepolia");
|
await addAcrossSwitch(boot, "btn-add-token-confirm", "sepolia");
|
||||||
expect(boot.visibleViews()).toEqual(["settings"]);
|
expect(boot.visibleViews()).toEqual(["settings"]);
|
||||||
expect(boot.text("flash-msg")).toBe(NETWORK_CHANGED_FLASH);
|
expect(boot.text("flash-msg")).toBe(NETWORK_CHANGED_FLASH);
|
||||||
expect(stored().trackedTokens).toEqual([SEPOLIA_TOKEN]);
|
expect(stored().trackedTokens).toEqual([
|
||||||
|
{ ...SEPOLIA_TOKEN, balanceNotFetched: true },
|
||||||
|
]);
|
||||||
expect(stored().networkTrackedTokens.mainnet).toEqual([MAINNET_TOKEN]);
|
expect(stored().networkTrackedTokens.mainnet).toEqual([MAINNET_TOKEN]);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user