([^<]*)<\/span><\/span>/)[1];
+}
+
+// The popup on Home over one address holding `eth` ETH and `usdc` USDC.
+function bootHolding(eth, usdc) {
+ const profile = unversionedValidProfile({
+ trackedTokens: [{ address: USDC, symbol: "USDC", decimals: 6 }],
+ });
+ profile.wallets[0].addresses[0] = {
+ address: ADDRESS,
+ balance: eth,
+ tokenBalances: [
+ { address: USDC, symbol: "USDC", decimals: 6, balance: usdc },
+ ],
+ };
+ return bootPopup(profile);
+}
+
+// The balance row for `token` in Home's wallet list.
+function homeRow(page, token) {
+ return page
+ .node("wallet-list")
+ .innerHTML.split(" row.includes('data-token="' + token + '"'));
+}
+
+describe("balanceLine", () => {
+ test("cuts 0.99996 to 0.9999, never rounding it up to 1.0000", () => {
+ expect(quantity(balanceLine("ETH", "0.99996", null, "ETH"))).toBe(
+ "0.9999",
+ );
+ });
+
+ test("shows 0.00004 as 0.00004, not 0.0000", () => {
+ expect(quantity(balanceLine("USDC", "0.00004", null, USDC))).toBe(
+ "0.00004",
+ );
+ });
+});
+
+describe("Home", () => {
+ test("the ETH line and the balance list read 0.99996 ETH as 0.9999", async () => {
+ const page = await bootHolding("0.99996", "0.00004");
+
+ expect(page.visibleViews()).toEqual(["main"]);
+ expect(page.text("total-value")).toBe("0.9999 ETH");
+ expect(quantity(homeRow(page, "ETH"))).toBe("0.9999");
+ });
+
+ test("the balance list reads 0.00004 USDC as 0.00004", async () => {
+ const page = await bootHolding("0.99996", "0.00004");
+
+ expect(quantity(homeRow(page, USDC.toLowerCase()))).toBe("0.00004");
+ });
+});
diff --git a/tests/deleteAddress.test.js b/tests/deleteAddress.test.js
index 42b157a..a12675b 100644
--- a/tests/deleteAddress.test.js
+++ b/tests/deleteAddress.test.js
@@ -4,8 +4,8 @@
// the copy is the substance and is tested as such. Two things it must not
// get wrong: what it takes to get the address back — the app refuses both
// obvious routes — and what counts as holding something, which is any
-// ERC-20 as well as ETH, at any size, including a balance that rounds to
-// zero at the four decimals the balance lines render. The DOM behaviour
+// ERC-20 as well as ETH, at any size, including a balance below the four
+// decimals the balance lines render. The DOM behaviour
// around them is driven against the real popup by tests/e2e/run.js.
// helpers.js pulls in state.js, which reads chrome.storage.local at load.
@@ -102,7 +102,7 @@ describe("whether an address holds anything", () => {
expect(addressHoldsFunds(TOKEN_ONLY)).toBe(true);
});
- // 0.00001 ETH renders as "0.0000" at four decimals. It is still money.
+ // 0.00001 ETH is below four decimals. It is still money.
test("an ETH balance below the displayed precision counts", () => {
expect(addressHoldsFunds(DUST)).toBe(true);
});
@@ -141,13 +141,12 @@ describe("the balance warning on the removal confirmation", () => {
expect(html).toContain("2500.0000");
});
- // The rendered line says 0.0000 for this address — that is the display
- // format, shared with Home and AddressDetail — and the warning is shown
- // all the same, because the balance is not zero.
- test("an ETH balance that renders as 0.0000 is warned about", () => {
+ // The rendered line shows the balance to its first nonzero digit, as Home
+ // and AddressDetail do (README.md, Amounts).
+ test("an ETH balance below 0.0001 is warned about, and reads as itself", () => {
const html = balanceWarningHtml(DUST);
expect(html).toContain("This address holds a balance.");
- expect(html).toContain("0.0000");
+ expect(html).toContain("0.00001");
});
test("an ETH balance no refresh has read is warned about, and reads as unknown", () => {
diff --git a/tests/transactions.test.js b/tests/transactions.test.js
index 631aa70..4f550c3 100644
--- a/tests/transactions.test.js
+++ b/tests/transactions.test.js
@@ -1361,6 +1361,31 @@ describe("fetchRecentTransactions merge and dedup", () => {
expect(txs[0].holders).toBe(3500000);
});
+ // README.md, Amounts: a nonzero amount never reads as zero.
+ test("a token transfer below 0.0001 shows its first nonzero digit", async () => {
+ respondWith(
+ [],
+ [
+ {
+ transaction_hash: "0x" + "4".repeat(64),
+ block_number: 21000040,
+ timestamp: TS,
+ from: { hash: ORDINARY_PEER },
+ to: { hash: VICTIM },
+ total: { value: "40", decimals: "6" },
+ token: {
+ symbol: "USDC",
+ address_hash: USDC_CONTRACT,
+ holders_count: "3500000",
+ },
+ },
+ ],
+ );
+
+ const txs = await fetchRecentTransactions(VICTIM, BLOCKSCOUT, "0x1");
+ expect(txs[0].value).toBe("0.00004");
+ });
+
test("two transfers of the same token in one transaction collapse to one entry", async () => {
const hash = "0x" + "3".repeat(64);
const leg = (value) => ({
diff --git a/tests/unknownScaleDisplay.test.js b/tests/unknownScaleDisplay.test.js
index e83be6e..e054f0a 100644
--- a/tests/unknownScaleDisplay.test.js
+++ b/tests/unknownScaleDisplay.test.js
@@ -96,7 +96,7 @@ afterEach(() => {
describe("balanceLine", () => {
test("an unknown quantity and a zero one render differently", () => {
const unknown = balanceLine("NOVEL", null, null, NOVEL);
- const zero = balanceLine("NOVEL", 0, null, NOVEL);
+ const zero = balanceLine("NOVEL", "0", null, NOVEL);
expect(unknown).not.toBe(zero);
expect(quantities(unknown)).toEqual(["NOVEL", "quantity unknown"]);
expect(quantities(zero)).toEqual(["NOVEL", "0.0000"]);
@@ -105,7 +105,7 @@ describe("balanceLine", () => {
test("an unknown quantity produces no fiat figure, a zero one does", () => {
prices[NOVEL] = 3;
const unknown = balanceLine("NOVEL", null, 3, NOVEL);
- const zero = balanceLine("NOVEL", 0, 3, NOVEL);
+ const zero = balanceLine("NOVEL", "0", 3, NOVEL);
// A price times an unknown quantity is not $0.00: that is the same
// claim of "nothing here" the quantity cell just refused to make.
expect(unknown).toContain(