From 21ccecab4639544ed4baea76da974f0f4b889f85 Mon Sep 17 00:00:00 2001
From: sneak <sneak@sneak.berlin>
Date: Thu, 26 Feb 2026 03:51:51 +0700
Subject: [PATCH] Fix approval popup: init listeners before early return,
 rename view, space buttons

The Allow/Deny buttons did nothing because approval.init(ctx) was
called after the early return for approval mode, so listeners were
never attached. Move it before the check.

Rename view from "approve" to "approve-site" to avoid ambiguity with
future transaction approval. Space Allow and Deny buttons apart with
justify-between to prevent misclicks.
---
 src/popup/index.html       | 6 +++---
 src/popup/index.js         | 6 ++++--
 src/popup/views/helpers.js | 2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/popup/index.html b/src/popup/index.html
index 53bba29..9fe97b2 100644
--- a/src/popup/index.html
+++ b/src/popup/index.html
@@ -593,8 +593,8 @@
                 </div>
             </div>
 
-            <!-- ============ APPROVAL ============ -->
-            <div id="view-approve" class="view hidden">
+            <!-- ============ SITE APPROVAL ============ -->
+            <div id="view-approve-site" class="view hidden">
                 <h2 class="font-bold mb-2">Connection Request</h2>
                 <div class="mb-3">
                     <p class="mb-2">
@@ -617,7 +617,7 @@
                         Remember my choice for this site
                     </label>
                 </div>
-                <div class="flex gap-2">
+                <div class="flex justify-between">
                     <button
                         id="btn-approve"
                         class="border border-border px-2 py-1 hover:bg-fg hover:text-bg cursor-pointer"
diff --git a/src/popup/index.js b/src/popup/index.js
index 7efd9a3..8cdf505 100644
--- a/src/popup/index.js
+++ b/src/popup/index.js
@@ -73,12 +73,15 @@ async function init() {
         await saveState();
     }
 
+    // Always init approval — it may run in its own popup window
+    approval.init(ctx);
+
     // Check for approval mode
     const params = new URLSearchParams(window.location.search);
     const approvalId = params.get("approval");
     if (approvalId) {
         approval.show(parseInt(approvalId, 10));
-        showView("approve");
+        showView("approve-site");
         return;
     }
 
@@ -99,7 +102,6 @@ async function init() {
     receive.init(ctx);
     addToken.init(ctx);
     settings.init(ctx);
-    approval.init(ctx);
 
     if (!state.hasWallet) {
         showView("welcome");
diff --git a/src/popup/views/helpers.js b/src/popup/views/helpers.js
index f26a6bb..0e0b195 100644
--- a/src/popup/views/helpers.js
+++ b/src/popup/views/helpers.js
@@ -19,7 +19,7 @@ const VIEWS = [
     "add-token",
     "settings",
     "transaction",
-    "approve",
+    "approve-site",
 ];
 
 function $(id) {