fix: the approval screen names the address a swap's output is paid to (closes #594)
The swap decoder read no recipient, so a swap paying its output to another address still showed Min. received. It now reads the address that every swap step, SWEEP, WRAP_ETH, UNWRAP_WETH, V4 TAKE and TAKE_ALL pays. The minimum reads Min. received only when some step pays the sender, none pays another address, none that may pay one went unread, and the output is not left in the router: an output paid to the router needs a later SWEEP of that token, or UNWRAP_WETH of WETH, paying it out. A payment that the next V2 swap spends as already paid is a hop, not a payout. Otherwise it reads Min. paid out, with Paid to lines saying who is paid. Model: opus-5-5
This commit is contained in:
@@ -82,7 +82,8 @@ function walletsHolding(token, decimals) {
|
||||
// decodeCalldata() rather than uniswap.decode() directly, because the scale
|
||||
// sources the screen supplies are part of what is under test.
|
||||
function swapDetail(data, label) {
|
||||
const decoded = decodeCalldata(data, ROUTER, "0x1");
|
||||
// Sent by the address the swap pays, so the output is the user's.
|
||||
const decoded = decodeCalldata(data, ROUTER, "0x1", RECIPIENT);
|
||||
return decoded.details.find((d) => d.label === label);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user