fix: use visibility:hidden/visible instead of CSS transitions for zero-tx warning
All checks were successful
check / check (push) Successful in 22s

Remove all CSS transitions, max-height changes, and opacity animations.
The warning container always reserves its space with visibility:hidden
and switches to visibility:visible when needed. No layout shift ever.
This commit is contained in:
user
2026-02-28 15:46:58 -08:00
parent 576fe3ab15
commit 045328f3b9
2 changed files with 4 additions and 25 deletions

View File

@@ -580,14 +580,7 @@
<div
id="confirm-recipient-warning"
class="mb-2"
style="
overflow: hidden;
transition:
max-height 0.3s ease,
opacity 0.3s ease;
max-height: 60px;
opacity: 0;
"
style="visibility: hidden"
>
<div
class="border border-red-500 border-dashed p-2 text-xs font-bold text-red-500"

View File

@@ -243,11 +243,8 @@ function show(txInfo) {
state.viewData = { pendingTx: txInfo };
showView("confirm-tx");
// Reset recipient warning: reserve space (max-height) while the async
// check runs, then collapse smoothly if not needed.
const recipientWarning = $("confirm-recipient-warning");
recipientWarning.style.maxHeight = "60px";
recipientWarning.style.opacity = "0";
// Reset recipient warning to hidden (space always reserved, no layout shift)
$("confirm-recipient-warning").style.visibility = "hidden";
estimateGas(txInfo);
checkRecipientHistory(txInfo);
@@ -302,25 +299,14 @@ async function checkRecipientHistory(txInfo) {
// the nonce, i.e. sent-tx count only).
const code = await provider.getCode(txInfo.to);
if (code && code !== "0x") {
// Contract address — no warning needed, collapse smoothly
el.style.maxHeight = "0";
el.style.opacity = "0";
return;
}
const txCount = await provider.getTransactionCount(txInfo.to);
if (txCount === 0) {
// Show warning: fade in (space already reserved)
el.style.opacity = "1";
} else {
// Recipient has history — collapse the reserved space smoothly
el.style.maxHeight = "0";
el.style.opacity = "0";
el.style.visibility = "visible";
}
} catch (e) {
log.errorf("recipient history check failed:", e.message);
// On error, collapse space — no false warning
el.style.maxHeight = "0";
el.style.opacity = "0";
}
}