Commit Graph

655 Commits

Author SHA1 Message Date
Jan Vidar Krey 35d8088b44 Handle socket errors from connected clients.
If a TLS error occurs, it could end up in a situation where the network handler code did not want to
read or write because it only had the error flag set. However, this was not handled, which left the
socket triggering in the event loop - but nothing was done to handle it.

This can easily cause a 100% cpu situation - the hub is still functioning though while this is
happening.
2019-12-13 10:51:40 +01:00
Jan Vidar Krey cff10910ad Issue 72: Improve ghost user detection
uhub has the ability to disconnect a 'ghost' user, e.g. if a user
reconnects then uhub will kick the existing user if it is still there.
However, this could also be triggered abusively by having two "tabs" or windows
connect at the same time from the same client. The process of connecting a new
client is rather expensive because it triggers a lot of updates on all connections.

With this change, uhub will only attempt to disconnect the existing client if
it is marked with the "flag_choke" flag, which indicates that messages must be
dropped simply because the client is not accepting data fast enough. This will
cause the new connection to fail because the user is already logged in.

This can be further improved by adding a timestamp for when the connection
previously was provable working. Which is possibly a better and more reliable
way of detecting ghost users.
2019-12-01 13:16:28 +01:00
Jan Vidar Krey 78a7039240 Fix CPU spikes for TLS connections using incompatible TLS protocol versions. 2019-06-18 16:01:44 +02:00
Jan Vidar Krey 0ae96b0da8 Add statistics about OpenSSL events such as handshakes, closes and errors. 2019-06-18 15:59:22 +02:00
Jan Vidar Krey 022a9895ec fixup! Fix OpenSSL error, wrong initialization order. 2019-04-24 10:53:39 +02:00
Jan Vidar Krey 891adb84fb fixup! Fix OpenSSL error, wrong initialization order. 2019-04-24 10:50:31 +02:00
Jan Vidar Krey 9762b9389d fixup! Fix OpenSSL error, wrong initialization order. 2019-04-24 10:46:59 +02:00
Jan Vidar Krey 076e75897b Fix OpenSSL error, wrong initialization order. 2019-04-24 10:32:01 +02:00
Jan Vidar Krey bc8974b9a3 Add better TLS protocol negotiation for OpenSSL >1.0.1 2019-04-23 16:16:36 +02:00
Boris Pek cf3a6e06df Secure URLs: http --> https (part 2) 2019-04-23 15:59:03 +02:00
Jan Vidar Krey 212064c166 Fix alpn_server_select_protocol to be static. 2019-03-31 19:33:46 +02:00
Jan Vidar Krey 56426f7b2a Merge branch 'alpn_static' of git://github.com/direct-connect/uhub into direct-connect-alpn_static 2019-03-31 19:27:50 +02:00
Jan Vidar Krey 46906a9a9c Merge branch 'master' of github.com:janvidar/uhub 2019-03-15 11:31:29 +01:00
Denys Smirnov 566cd9a9db advertise ADC protocol with ALPN 2019-03-15 02:19:19 +02:00
Boris Pek d25fead3a8 Fix spelling errors 2019-02-25 19:46:24 +01:00
Boris Pek ef83b31cec Fix spelling errors 2019-02-25 19:46:24 +01:00
Jan Vidar Krey de01486c0f Fix plug-in API header files. 2018-11-27 13:20:41 +01:00
Jan Vidar Krey c383a53105 Fix crash if unable to load plugin. 2018-11-21 11:00:20 +01:00
Kcchouette f0b67ea4cd Update config.xml 2018-11-20 11:56:07 +01:00
Kcchouette ac96ace7df Finish adding bots to uhub-passwd
Related to https://github.com/janvidar/uhub/pull/28
2018-11-18 20:32:00 +01:00
Felix Brucker 99711a5c6e Allow many large messages 2018-10-11 23:29:32 +02:00
Felix Brucker e43aea35cc Use localtime instead of utc 2018-10-11 23:29:32 +02:00
makefu d54d723c59 add aarch64 to supported architectures
closes #46
2018-10-11 23:24:11 +02:00
Jan Vidar Krey f0e9b2ffd9 Add support for OpenSSL 1.1 2018-02-26 10:58:41 +00:00
Jan Vidar Krey 11538d6909 Mute debug log messages for net_send() that were incorrectly classified as error messages. 2018-01-15 17:00:56 +00:00
Yorhel 90d05c9a19 mod_logging: Fix inverted if statement in syslog config check 2016-07-11 09:26:34 +00:00
Jan Vidar Krey dc80644471 Merge pull request #28 from klondi/unrestricted_users
Allow unrestricted users on uhub
2014-12-15 09:36:49 +01:00
Jan Vidar Krey 889807da1b Merge pull request #31 from klondi/chat_history_sqlite_fixes
Chat history sqlite fixes
2014-11-26 13:56:07 +01:00
mimicmod 96cc46117f Fix previous commit (Added sqlite VACUUM to cleanup commands)
Conflicts:
	src/plugins/mod_chat_history_sqlite.c
2014-11-25 15:46:35 +01:00
Michal Micka 5e63ab2ccd Fix: Chat history sqlite truncating long messages 2014-11-25 15:42:40 +01:00
Francisco Blas (klondike) Izquierdo Riera 3f2641595b Remove invalid assertion as \n has length 0 2014-11-25 09:07:03 +01:00
Jan Vidar Krey 0e27e4219d Merge pull request #30 from klondi/mimicfixes
Mimicfixes
2014-11-25 07:55:56 +01:00
Michal Micka 6ad5efea6d Fix: Make config parser python 3 compatible 2014-11-24 16:08:47 +01:00
Francisco Blas (klondike) Izquierdo Riera 076daec846 Backport the HUBBOT constant defining a bot which is also an operator 2014-11-24 12:28:28 +01:00
Francisco Blas (klondike) Izquierdo Riera 223e01937e Fix boolean logic fuck up 2014-11-24 12:12:07 +01:00
klondike 19068de088 Make unrestricted... unrestricted 2014-11-24 12:11:54 +01:00
klondike c15f201d70 Add auth_cred_is_unrestricted 2014-11-24 12:11:41 +01:00
klondike 7bda215ad4 Add bots to uhub-passwd 2014-11-24 12:11:25 +01:00
klondike d86ef503b3 Add opbots and unrestricted bots 2014-11-24 12:11:11 +01:00
Francisco Blas (klondike) Izquierdo Riera 8a7e892aeb Add support for 4 byte UTF-8 characters and stricter character checking 2014-11-24 10:28:50 +01:00
Jan Vidar Krey 05edfa48b2 Merge pull request #25 from schreda/master
added broadcast message and getter for user count in plugin API
2014-10-17 00:09:56 +02:00
Jan Vidar Krey 204544298b Cleanup debug logging. 2014-10-16 23:14:12 +02:00
Jan Vidar Krey 418db22931 Merge branch 'master' of github.com:janvidar/uhub 2014-10-16 23:10:28 +02:00
Jan Vidar Krey 037ceff0a5 Disable SSLv3 explicitly also. 2014-10-16 23:09:50 +02:00
Jan Vidar Krey 44708e8433 Move some network, timer code. 2014-10-16 23:09:12 +02:00
Jan Vidar Krey 76ff2a1a13 Fix TLS protocol mismatch assert causing the hub to shutdown. 2014-10-16 23:08:17 +02:00
Tillmann Karras c0ee55325c Release all memory in tests and fix comment 2014-10-06 21:06:33 +02:00
Tillmann Karras 3d0b652ec9 Remove some unused variables 2014-10-06 21:02:08 +02:00
Andre Schreder 2d45a37536 added broadcast message and getter for user count in plugin API 2014-10-03 15:23:36 +02:00
Jan Vidar Krey 1da917e5b9 Fix crash due to negative max copy length. 2014-09-23 00:01:15 +02:00