external
/
secretive
mirror of https://github.com/maxgoedjen/secretive.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Enable additional concurrency warnings (#281) 

* Turn on warnings

* Turn on warnings

* Fix warnings
This commit is contained in:
Max Goedjen 2021-12-14 21:03:42 -08:00 committed by GitHub
parent 86719e893b
commit cda56ea14b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Secretive.xcodeproj/project.pbxproj
View File

@ -1250,6 +1250,7 @@
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES; MTL_FAST_MATH = YES;
ONLY_ACTIVE_ARCH = YES; ONLY_ACTIVE_ARCH = YES;
OTHER_SWIFT_FLAGS = "-Xfrontend -warn-concurrency -Xfrontend -enable-actor-data-race-checks";
SDKROOT = macosx; SDKROOT = macosx;
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OPTIMIZATION_LEVEL = "-Onone"; SWIFT_OPTIMIZATION_LEVEL = "-Onone";
@ -1305,6 +1306,7 @@
MACOSX_DEPLOYMENT_TARGET = 11.0; MACOSX_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = NO; MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES; MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "-Xfrontend -warn-concurrency -Xfrontend -enable-actor-data-race-checks";
SDKROOT = macosx; SDKROOT = macosx;
SWIFT_COMPILATION_MODE = wholemodule; SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O"; SWIFT_OPTIMIZATION_LEVEL = "-O";
@ -1648,6 +1650,7 @@
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES; MTL_FAST_MATH = YES;
ONLY_ACTIVE_ARCH = YES; ONLY_ACTIVE_ARCH = YES;
OTHER_SWIFT_FLAGS = "-Xfrontend -warn-concurrency -Xfrontend -enable-actor-data-race-checks";
SDKROOT = macosx; SDKROOT = macosx;
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OPTIMIZATION_LEVEL = "-Onone"; SWIFT_OPTIMIZATION_LEVEL = "-Onone";

2
Secretive/Controllers/ShellConfigurationController.swift
View File

@ -29,7 +29,7 @@ struct ShellConfigurationController {
} }
func addToShell(shellInstructions: ShellConfigInstruction) -> Bool { @MainActor func addToShell(shellInstructions: ShellConfigInstruction) -> Bool {
let openPanel = NSOpenPanel() let openPanel = NSOpenPanel()
// This is sync, so no need to strongly retain // This is sync, so no need to strongly retain
let delegate = Delegate(name: shellInstructions.shellConfigFilename) let delegate = Delegate(name: shellInstructions.shellConfigFilename)

2
Secretive/Views/CreateSecretView.swift
View File

@ -12,7 +12,7 @@ struct CreateSecretView<StoreType: SecretStoreModifiable>: View {
var body: some View { var body: some View {
VStack { VStack {
HStack { HStack {
Image(nsImage: NSApp.applicationIconImage) Image(nsImage: NSApplication.shared.applicationIconImage)
.resizable() .resizable()
.frame(width: 64, height: 64) .frame(width: 64, height: 64)
.padding() .padding()

2
Secretive/Views/DeleteSecretView.swift
View File

@ -12,7 +12,7 @@ struct DeleteSecretView<StoreType: SecretStoreModifiable>: View {
var body: some View { var body: some View {
VStack { VStack {
HStack { HStack {
Image(nsImage: NSApp.applicationIconImage) Image(nsImage: NSApplication.shared.applicationIconImage)
.resizable() .resizable()
.frame(width: 64, height: 64) .frame(width: 64, height: 64)
.padding() .padding()

2
Secretive/Views/RenameSecretView.swift
View File

@ -12,7 +12,7 @@ struct RenameSecretView<StoreType: SecretStoreModifiable>: View {
var body: some View { var body: some View {
VStack { VStack {
HStack { HStack {
Image(nsImage: NSApp.applicationIconImage) Image(nsImage: NSApplication.shared.applicationIconImage)
.resizable() .resizable()
.frame(width: 64, height: 64) .frame(width: 64, height: 64)
.padding() .padding()

2
Secretive/Views/SetupView.swift
View File

@ -146,7 +146,7 @@ struct SecretAgentSetupView: View {
var body: some View { var body: some View {
SetupStepView(title: "Setup Secret Agent", SetupStepView(title: "Setup Secret Agent",
image: Image(nsImage: NSApp.applicationIconImage), image: Image(nsImage: NSApplication.shared.applicationIconImage),
bodyText: "Secretive needs to set up a helper app to work properly. It will sign requests from SSH clients in the background, so you don't need to keep the main Secretive app open.", bodyText: "Secretive needs to set up a helper app to work properly. It will sign requests from SSH clients in the background, so you don't need to keep the main Secretive app open.",
buttonTitle: "Install", buttonTitle: "Install",
buttonAction: install) { buttonAction: install) {