external/secretive
1
0
Fork 0
mirror of https://github.com/maxgoedjen/secretive.git synced 2025-08-28 08:00:58 +00:00
Code Issues Projects Releases Wiki Activity

Remove logic to deal with sending/not sending distrib notifications (#641)

Browse Source
This commit is contained in:
Max Goedjen 2025-08-26 23:15:17 -07:00 committed by GitHub
parent 6ce0510f21
commit 8ad2d60082
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Sources/Packages/Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift
View File

@ -23,7 +23,11 @@ extension SecureEnclave {
@MainActor public init() { @MainActor public init() {
loadSecrets() loadSecrets()
Task { Task {
for await _ in DistributedNotificationCenter.default().notifications(named: .secretStoreUpdated) { for await note in DistributedNotificationCenter.default().notifications(named: .secretStoreUpdated) {
guard Constants.notificationToken != (note.object as? String) else {
// Don't reload if we're the ones triggering this by reloading.
return
}
reloadSecrets() reloadSecrets()
} }
} }
@ -93,7 +97,13 @@ extension SecureEnclave {
} }
@MainActor public func reloadSecrets() { @MainActor public func reloadSecrets() {
reloadSecretsInternal(notifyAgent: false) let before = secrets
secrets.removeAll()
loadSecrets()
if secrets != before {
NotificationCenter.default.post(name: .secretStoreReloaded, object: self)
DistributedNotificationCenter.default().postNotificationName(.secretStoreUpdated, object: Constants.notificationToken, deliverImmediately: true)
}
} }
// MARK: SecretStoreModifiable // MARK: SecretStoreModifiable
@ -194,18 +204,6 @@ extension SecureEnclave {
extension SecureEnclave.Store { extension SecureEnclave.Store {
@MainActor private func reloadSecretsInternal(notifyAgent: Bool = true) {
let before = secrets
secrets.removeAll()
loadSecrets()
if secrets != before {
NotificationCenter.default.post(name: .secretStoreReloaded, object: self)
if notifyAgent {
DistributedNotificationCenter.default().postNotificationName(.secretStoreUpdated, object: nil, deliverImmediately: true)
}
}
}
/// Loads all secrets from the store. /// Loads all secrets from the store.
@MainActor private func loadSecrets() { @MainActor private func loadSecrets() {
let queryAttributes = KeychainDictionary([ let queryAttributes = KeychainDictionary([
@ -286,6 +284,7 @@ extension SecureEnclave.Store {
enum Constants { enum Constants {
static let keyClass = kSecClassGenericPassword as String static let keyClass = kSecClassGenericPassword as String
static let keyTag = Data("com.maxgoedjen.secretive.secureenclave.key".utf8) static let keyTag = Data("com.maxgoedjen.secretive.secureenclave.key".utf8)
static let notificationToken = UUID().uuidString
} }
struct UnsupportedAlgorithmError: Error {} struct UnsupportedAlgorithmError: Error {}