From 656b61e1419ed00e85a65fb595a17bfe63149d07 Mon Sep 17 00:00:00 2001
From: Max Goedjen <max.goedjen@gmail.com>
Date: Tue, 19 Aug 2025 23:53:58 -0700
Subject: [PATCH] WIP

---
 Sources/Packages/Localizable.xcstrings        | 30 +++++++++++--------
 .../Secretive/Views/CreateSecretView.swift    |  6 +++-
 Sources/Secretive/Views/EditSecretView.swift  |  6 +++-
 .../Secretive/Views/SecretListItemView.swift  |  4 ++-
 4 files changed, 31 insertions(+), 15 deletions(-)

diff --git a/Sources/Packages/Localizable.xcstrings b/Sources/Packages/Localizable.xcstrings
index ec3ae69..3b8cdb4 100644
--- a/Sources/Packages/Localizable.xcstrings
+++ b/Sources/Packages/Localizable.xcstrings
@@ -3911,72 +3911,72 @@
         }
       }
     },
-    "secret_list_rename_button" : {
+    "secret_list_edit_button" : {
       "extractionState" : "manual",
       "localizations" : {
         "ca" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "Canvia el nom"
           }
         },
         "de" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "Umbenennen"
           }
         },
         "en" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Rename"
+            "value" : "Edit"
           }
         },
         "fr" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "Renommer"
           }
         },
         "it" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "Rinomina"
           }
         },
         "ja" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "名前を変更"
           }
         },
         "ko" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "이름 변경"
           }
         },
         "pl" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "Zmień nazwę"
           }
         },
         "pt-BR" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "Renomear"
           }
         },
         "ru" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "Переименовать"
           }
         },
         "zh-Hans" : {
           "stringUnit" : {
-            "state" : "translated",
+            "state" : "needs_review",
             "value" : "重命名"
           }
         }
@@ -5353,6 +5353,9 @@
     },
     "test@example.com" : {
 
+    },
+    "This shows at the end of your public key." : {
+
     },
     "unnamed_secret" : {
       "extractionState" : "manual",
@@ -6299,6 +6302,9 @@
           }
         }
       }
+    },
+    "Warning: ML-DSA keys are very new, and not supported by many servers yet. Please verify the server you'll be using this key for accepts ML-DSA keys." : {
+
     }
   },
   "version" : "1.0"
diff --git a/Sources/Secretive/Views/CreateSecretView.swift b/Sources/Secretive/Views/CreateSecretView.swift
index a3b0f07..66169b4 100644
--- a/Sources/Secretive/Views/CreateSecretView.swift
+++ b/Sources/Secretive/Views/CreateSecretView.swift
@@ -45,7 +45,11 @@ struct CreateSecretView<StoreType: SecretStoreModifiable>: View {
                                     .background(.red.opacity(0.5), in:  RoundedRectangle(cornerRadius: 5))
                             }
                         }
-                        TextField("Key Attribution", text: $keyAttribution, prompt: Text("test@example.com"))
+                        VStack(alignment: .leading) {
+                            TextField("Key Attribution", text: $keyAttribution, prompt: Text("test@example.com"))
+                            Text("This shows at the end of your public key.")
+                                .font(.caption)
+                        }
                     }
                 }
             }
diff --git a/Sources/Secretive/Views/EditSecretView.swift b/Sources/Secretive/Views/EditSecretView.swift
index f8436ad..737c666 100644
--- a/Sources/Secretive/Views/EditSecretView.swift
+++ b/Sources/Secretive/Views/EditSecretView.swift
@@ -23,7 +23,11 @@ struct EditSecretView<StoreType: SecretStoreModifiable>: View {
             Form {
                 Section {
                     TextField(String(localized: .createSecretNameLabel), text: $name, prompt: Text(.createSecretNamePlaceholder))
-                    TextField("Key Attribution", text: $publicKeyAttribution, prompt: Text("test@example.com"))
+                    VStack(alignment: .leading) {
+                        TextField("Key Attribution", text: $publicKeyAttribution, prompt: Text("test@example.com"))
+                        Text("This shows at the end of your public key.")
+                            .font(.caption)
+                    }
                 }
             }
             HStack {
diff --git a/Sources/Secretive/Views/SecretListItemView.swift b/Sources/Secretive/Views/SecretListItemView.swift
index 5ebdfa1..357dc25 100644
--- a/Sources/Secretive/Views/SecretListItemView.swift
+++ b/Sources/Secretive/Views/SecretListItemView.swift
@@ -39,9 +39,11 @@ struct SecretListItemView: View {
         .contextMenu {
             if store is AnySecretStoreModifiable {
                 Button(action: { isRenaming = true }) {
-                    Text(.secretListRenameButton)
+                    Image(systemName: "pencil")
+                    Text(.secretListEditButton)
                 }
                 Button(action: { isDeleting = true }) {
+                    Image(systemName: "trash")
                     Text(.secretListDeleteButton)
                 }
             }