From 59aca9327f3ac1bca131dd5eefde1c95a2d0b7d8 Mon Sep 17 00:00:00 2001 From: Max Goedjen Date: Mon, 7 Sep 2026 16:48:57 -0700 Subject: [PATCH] Fix keyType constants being Data instead of String, specify in update calls (#830) --- Sources/Packages/Sources/CertificateKit/CertificateStore.swift | 3 ++- .../Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Sources/Packages/Sources/CertificateKit/CertificateStore.swift b/Sources/Packages/Sources/CertificateKit/CertificateStore.swift index 27c873b..ee72668 100644 --- a/Sources/Packages/Sources/CertificateKit/CertificateStore.swift +++ b/Sources/Packages/Sources/CertificateKit/CertificateStore.swift @@ -67,6 +67,7 @@ import SecretKit public func update(certificate: Certificate) throws { let updateQuery = KeychainDictionary([ kSecClass: Constants.keyClass, + kSecAttrService: Constants.keyTag, kSecAttrAccount: certificate.id, ]) @@ -134,7 +135,7 @@ extension CertificateStore { enum Constants { static let keyClass = kSecClassGenericPassword as String - static let keyTag = Data("com.maxgoedjen.certificatestore.opensshcertificate".utf8) + static let keyTag = "com.maxgoedjen.certificatestore.opensshcertificate" static let notificationToken = UUID().uuidString } diff --git a/Sources/Packages/Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift b/Sources/Packages/Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift index 497967c..1906ab6 100644 --- a/Sources/Packages/Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift +++ b/Sources/Packages/Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift @@ -183,6 +183,7 @@ extension SecureEnclave { let attributes = try JSONEncoder().encode(attributes) let updatedAttributes = KeychainDictionary([ kSecAttrLabel: name, + kSecAttrService: Constants.keyTag, kSecAttrGeneric: attributes, ]) @@ -294,7 +295,7 @@ extension SecureEnclave.Store { enum Constants { static let keyClass = kSecClassGenericPassword as String - static let keyTag = Data("com.maxgoedjen.secretive.secureenclave.key".utf8) + static let keyTag = "com.maxgoedjen.secretive.secureenclave.key" static let notificationToken = UUID().uuidString }