From de4ec82a5afa753646f9468df23c27825444678c Mon Sep 17 00:00:00 2001 From: Tim in 't Veld <50753699+timveld@users.noreply.github.com> Date: Sun, 1 Feb 2026 16:29:39 +0100 Subject: [PATCH] Fix critical accessibility bug in control panel modals (#2551) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Removed `aria-hidden="true"` from the `global_modal` div. This attribute was set but not updated, causing screen readers to ignore the modal even when it was open. Bootstrap sets and modifies `aria-hidden` automatically, so the correct approach is not to set it manually. - The `global_modal` div has `role="dialog"` (correct) but lacked `aria-modal="true"`. The ARIA specification recommends setting this attribute to ensure screen readers know that focus is (and should be) trapped in the modal. I added it. - Removed `aria-hidden="true"` from the close button. This button can receive keyboard focus, so it should have an accessible name. If it is hidden, a screen reader user experiences focus on an unnamed element, which is confusing. - Added `aria-label="Close Dialog"` to the close button. The visible label `×` does not describe the button’s function, but the new ARIA label does. --- management/templates/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/management/templates/index.html b/management/templates/index.html index 42e7d636..ce1c15d3 100644 --- a/management/templates/index.html +++ b/management/templates/index.html @@ -215,11 +215,11 @@ -