From a24977a96ed3ac7db37a27e43630e48717e909ca Mon Sep 17 00:00:00 2001 From: Joshua Tauberer Date: Wed, 18 Jan 2017 07:51:59 -0500 Subject: [PATCH] normalize_ip for ipv6 still not correct, was broken if box has no IPv6 address --- management/status_checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 management/status_checks.py diff --git a/management/status_checks.py b/management/status_checks.py old mode 100644 new mode 100755 index 30b9a285..d29e89ef --- a/management/status_checks.py +++ b/management/status_checks.py @@ -393,7 +393,7 @@ def check_primary_hostname_dns(domain, env, output, dns_domains, dns_zonefiles): # Check that PRIMARY_HOSTNAME resolves to PUBLIC_IP[V6] in public DNS. ipv6 = query_dns(domain, "AAAA") if env.get("PUBLIC_IPV6") else None - if ip == env['PUBLIC_IP'] and normalize_ip(ipv6) in (None, normalize_ip(env['PUBLIC_IPV6'])): + if ip == env['PUBLIC_IP'] and not (ipv6 and env['PUBLIC_IPV6'] and normalize_ip(ipv6) != normalize_ip(env['PUBLIC_IPV6'])): output.print_ok("Domain resolves to box's IP address. [%s ↦ %s]" % (env['PRIMARY_HOSTNAME'], my_ips)) else: output.print_error("""This domain must resolve to your box's IP address (%s) in public DNS but it currently resolves