diff --git a/management/dns_update.py b/management/dns_update.py index 186e14a5..450933ca 100755 --- a/management/dns_update.py +++ b/management/dns_update.py @@ -291,7 +291,7 @@ def build_zone(domain, domain_properties, additional_records, env, is_zone=True) # Append the DKIM TXT record to the zone as generated by OpenDKIM. # Skip if the user has set a DKIM record already. - opendkim_record_file = os.path.join(env['STORAGE_ROOT'], 'mail/dkim/mail.txt') + opendkim_record_file = os.path.join(env['STORAGE_ROOT'], 'mail/dkim/' + env['DKIM_SELECTOR'] + '.txt') with open(opendkim_record_file, encoding="utf-8") as orf: m = re.match(r'(\S+)\s+IN\s+TXT\s+\( ((?:"[^"]+"\s+)+)\)', orf.read(), re.S) val = "".join(re.findall(r'"([^"]+)"', m.group(2))) @@ -752,12 +752,13 @@ def write_opendkim_tables(domains, env): # Append a record to OpenDKIM's KeyTable and SigningTable for each domain # that we send mail from (zones and all subdomains). - opendkim_key_file = os.path.join(env['STORAGE_ROOT'], 'mail/dkim/mail.private') + opendkim_key_file = os.path.join(env['STORAGE_ROOT'], 'mail/dkim/' + env['DKIM_SELECTOR'] + '.private') if not os.path.exists(opendkim_key_file): # Looks like OpenDKIM is not installed. return False + selector=env['DKIM_SELECTOR'] config = { # The SigningTable maps email addresses to a key in the KeyTable that # specifies signing information for matching email addresses. Here we @@ -777,7 +778,7 @@ def write_opendkim_tables(domains, env): # signing domain must match the sender's From: domain. "KeyTable": "".join( - f"{domain} {domain}:mail:{opendkim_key_file}\n" + f"{domain} {domain}:{selector}:{opendkim_key_file}\n" for domain in domains ), } diff --git a/setup/dkim.sh b/setup/dkim.sh index 77d996ab..cab6465c 100755 --- a/setup/dkim.sh +++ b/setup/dkim.sh @@ -6,7 +6,7 @@ # # The DNS configuration for DKIM is done in the management daemon. -source setup/functions.sh # load our functions +source setup/functions.sh # load our functions source /etc/mailinabox.conf # load global vars # Install DKIM... @@ -14,12 +14,12 @@ echo "Installing OpenDKIM/OpenDMARC..." apt_install opendkim opendkim-tools opendmarc # Make sure configuration directories exist. -mkdir -p /etc/opendkim; +mkdir -p /etc/opendkim mkdir -p "$STORAGE_ROOT/mail/dkim" # Used in InternalHosts and ExternalIgnoreList configuration directives. # Not quite sure why. -echo "127.0.0.1" > /etc/opendkim/TrustedHosts +echo "127.0.0.1" >/etc/opendkim/TrustedHosts # We need to at least create these files, since we reference them later. # Otherwise, opendkim startup will fail @@ -30,7 +30,7 @@ if grep -q "ExternalIgnoreList" /etc/opendkim.conf; then true # already done #NODOC else # Add various configuration options to the end of `opendkim.conf`. - cat >> /etc/opendkim.conf << EOF; + cat >>/etc/opendkim.conf < /dev/null; then - # Generate locale if not exists - hide_output locale-gen en_US.UTF-8 +if ! locale -a | grep en_US.utf8 >/dev/null; then + # Generate locale if not exists + hide_output locale-gen en_US.UTF-8 fi export LANGUAGE=en_US.UTF-8 @@ -35,16 +35,23 @@ if [ -f /etc/mailinabox.conf ]; then # Load the old .conf file to get existing configuration options loaded # into variables with a DEFAULT_ prefix. - cat /etc/mailinabox.conf | sed s/^/DEFAULT_/ > /tmp/mailinabox.prev.conf + cat /etc/mailinabox.conf | sed s/^/DEFAULT_/ >/tmp/mailinabox.prev.conf source /tmp/mailinabox.prev.conf rm -f /tmp/mailinabox.prev.conf + + # Since this is a second run, attempt to read overridden settings from $STORAGE_ROOT/mailinabox.conf + if [ -f $DEFAULT_STORAGE_ROOT/mailinabox.conf ]; then + cat $DEFAULT_STORAGE_ROOT/mailinabox.conf | sed s/^/DEFAULT_/ >/tmp/mailinabox.prev.conf + source /tmp/mailinabox.prev.conf + rm -f /tmp/mailinabox.prev.conf + fi else FIRST_TIME_SETUP=1 fi # Put a start script in a global location. We tell the user to run 'mailinabox' # in the first dialog prompt, so we should do this before that starts. -cat > /usr/local/bin/mailinabox << EOF; +cat >/usr/local/bin/mailinabox < "$STORAGE_ROOT/mailinabox.version" + setup/migrate.py --current >"$STORAGE_ROOT/mailinabox.version" chown "$STORAGE_USER:$STORAGE_USER" "$STORAGE_ROOT/mailinabox.version" fi @@ -92,7 +102,7 @@ fi # tools know where to look for data. The default MTA_STS_MODE setting # is blank unless set by an environment variable, but see web.sh for # how that is interpreted. -cat > /etc/mailinabox.conf << EOF; +cat >/etc/mailinabox.conf <