From 8f2e4d12477d1c61b19e7972069a1a003d13f3bb Mon Sep 17 00:00:00 2001
From: downtownallday <downtownallday@gmail.com>
Date: Tue, 9 Jun 2020 20:26:40 -0400
Subject: [PATCH] Set miab_ldap.conf variables only if they don't already exist
 so that the file may be pre-populated

---
 setup/ldap.sh | 54 +++++++++++++++++++++++++++------------------------
 1 file changed, 29 insertions(+), 25 deletions(-)

diff --git a/setup/ldap.sh b/setup/ldap.sh
index 0d52aded..78e2c4cb 100755
--- a/setup/ldap.sh
+++ b/setup/ldap.sh
@@ -71,42 +71,46 @@ wait_slapd_start() {
 	say_verbose "...ok"
 }
 
+_add_if_missing() {
+	local var="$1"
+	local val="$2"
+	local conf="$MIAB_INTERNAL_CONF_FILE"
+	if [ $(grep -c "^${var}=" "$conf") -eq 0 ]; then
+		echo "${var}=\"${val}\"" >> "$conf"
+	fi
+}
+
 create_miab_conf() {
 	# create (if non-existing) or load (existing) ldap/miab_ldap.conf
 	if [ ! -e "$MIAB_INTERNAL_CONF_FILE" ]; then
 		say_verbose "Generating a new $MIAB_INTERNAL_CONF_FILE"
 		mkdir -p "$(dirname $MIAB_INTERNAL_CONF_FILE)"
-		
-		# Use 64-character secret keys of safe characters
-		cat > "$MIAB_INTERNAL_CONF_FILE" <<EOF
-LDAP_SERVER=127.0.0.1
-LDAP_SERVER_PORT=389
-LDAP_SERVER_STARTTLS=no
-LDAP_SERVER_TLS=no
-LDAP_URL=ldap://127.0.0.1/
-LDAP_BASE="${LDAP_BASE}"
-LDAP_SERVICES_BASE="${LDAP_SERVICES_BASE}"
-LDAP_CONFIG_BASE="${LDAP_CONFIG_BASE}"
-LDAP_DOMAINS_BASE="${LDAP_DOMAINS_BASE}"
-LDAP_PERMITTED_SENDERS_BASE="${LDAP_PERMITTED_SENDERS_BASE}"
-LDAP_USERS_BASE="${LDAP_USERS_BASE}"
-LDAP_ALIASES_BASE="${LDAP_ALIASES_BASE}"
-LDAP_ADMIN_DN="${LDAP_ADMIN_DN}"
-LDAP_ADMIN_PASSWORD="$(generate_password 64)"
-EOF
+		touch "$MIAB_INTERNAL_CONF_FILE"
 	fi
 
+	# ensure all required values exist, and if not set to default values
+	_add_if_missing LDAP_SERVER 127.0.0.1
+	_add_if_missing LDAP_SERVER_PORT 389
+	_add_if_missing LDAP_SERVER_STARTTLS no
+	_add_if_missing LDAP_SERVER_TLS no
+	_add_if_missing LDAP_URL ldap://127.0.0.1/
+	_add_if_missing LDAP_BASE "${LDAP_BASE}"
+	_add_if_missing LDAP_SERVICES_BASE "${LDAP_SERVICES_BASE}"
+	_add_if_missing LDAP_CONFIG_BASE "${LDAP_CONFIG_BASE}"
+	_add_if_missing LDAP_DOMAINS_BASE "${LDAP_DOMAINS_BASE}"
+	_add_if_missing LDAP_PERMITTED_SENDERS_BASE "${LDAP_PERMITTED_SENDERS_BASE}"
+	_add_if_missing LDAP_USERS_BASE "${LDAP_USERS_BASE}"
+	_add_if_missing LDAP_ALIASES_BASE "${LDAP_ALIASES_BASE}"
+	_add_if_missing LDAP_ADMIN_DN "${LDAP_ADMIN_DN}"
+	_add_if_missing LDAP_ADMIN_PASSWORD "$(generate_password 64)"
+
 	# add service account credentials
 	local prefix
 	for prefix in ${SERVICE_ACCOUNTS[*]}
 	do
-		if [ $(grep -c "^$prefix" "$MIAB_INTERNAL_CONF_FILE") -eq 0 ]; then
-			local cn=$(awk -F_ '{print tolower($2)}' <<< $prefix)
-			cat >>"$MIAB_INTERNAL_CONF_FILE" <<EOF
-${prefix}_DN="cn=$cn,$LDAP_SERVICES_BASE"
-${prefix}_PASSWORD="$(generate_password 64)"
-EOF
-		fi
+		local cn=$(awk -F_ '{print tolower($2)}' <<< $prefix)
+		_add_if_missing "${prefix}_DN" "cn=$cn,$LDAP_SERVICES_BASE"
+		_add_if_missing "${prefix}_PASSWORD" "$(generate_password 64)"
 	done
 	
 	chmod 0640 "$MIAB_INTERNAL_CONF_FILE"