From aac878dce51832827613c60d6f0cfafd1a5fa61d Mon Sep 17 00:00:00 2001 From: steadfasterX Date: Tue, 23 Nov 2021 17:06:17 +0100 Subject: [PATCH 1/2] fix: key flag id for KSK, fix format (#2063) as mentioned (https://github.com/mail-in-a-box/mailinabox/pull/2033#issuecomment-976365087) KSK is 257, not 256 --- management/status_checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/management/status_checks.py b/management/status_checks.py index 1e7223a5..d3c642c6 100755 --- a/management/status_checks.py +++ b/management/status_checks.py @@ -646,7 +646,7 @@ def check_dnssec(domain, env, output, dns_zonefiles, is_checking_primary=False): output.print_line("Option " + str(i+1) + ":") output.print_line("----------") output.print_line("Key Tag: " + ds_suggestion['keytag']) - output.print_line("Key Flags: KSK (256)") + output.print_line("Key Flags: KSK / 257") output.print_line("Algorithm: %s / %s" % (ds_suggestion['alg'], ds_suggestion['alg_name'])) output.print_line("Digest Type: %s / %s" % (ds_suggestion['digalg'], ds_suggestion['digalg_name'])) output.print_line("Digest: " + ds_suggestion['digest']) From 50a5cb90bc63d3f492641bf39ed943886f9c4eab Mon Sep 17 00:00:00 2001 From: Ilnahro <36730161+Ilnahro@users.noreply.github.com> Date: Wed, 1 Dec 2021 00:50:01 +0000 Subject: [PATCH 2/2] Include rsync to the installed basic packages (#2067) Some VPS providers strip this package from their Ubuntu 18.04 VM images. This will help avoid errors. --- setup/management.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup/management.sh b/setup/management.sh index 7e31fe00..8dc64f3b 100755 --- a/setup/management.sh +++ b/setup/management.sh @@ -25,7 +25,7 @@ done # # certbot installs EFF's certbot which we use to # provision free TLS certificates. -apt_install duplicity python-pip virtualenv certbot +apt_install duplicity python-pip virtualenv certbot rsync # b2sdk is used for backblaze backups. # boto is used for amazon aws backups.