From 8ea2f5a766223fc2b12c7dfc394f578b3d88253e Mon Sep 17 00:00:00 2001
From: Michael Kroes <michael@kroes.email>
Date: Thu, 25 Feb 2016 21:56:27 +0100
Subject: [PATCH 1/3] Allow a server to be rebooted when a reboot is required

---
 management/daemon.py                    | 18 ++++++++++++-
 management/templates/system-status.html | 34 +++++++++++++++++++++++--
 2 files changed, 49 insertions(+), 3 deletions(-)

diff --git a/management/daemon.py b/management/daemon.py
index 6de0a59a..823bce5e 100755
--- a/management/daemon.py
+++ b/management/daemon.py
@@ -391,7 +391,6 @@ def ssl_provision_certs():
 def web_get_domains():
 	from web_update import get_web_domains_info
 	return json_response(get_web_domains_info(env))
-
 @app.route('/web/update', methods=['POST'])
 @authorized_personnel_only
 def web_update():
@@ -456,6 +455,23 @@ def do_updates():
 		"DEBIAN_FRONTEND": "noninteractive"
 	})
 
+@app.route('/system/reboot', methods=["GET"])
+@authorized_personnel_only
+def needs_reboot():
+	if os.path.isfile("/var/run/reboot-required"):
+		return json_response(True)
+	else:
+		return json_response(False)
+
+@app.route('/system/reboot', methods=["POST"])
+@authorized_personnel_only
+def do_reboot():
+	if os.path.isfile("/var/run/reboot-required"):
+		return utils.shell("check_output", ["/sbin/shutdown", "-r", "now"], capture_stderr=True)
+	else:
+		return "No reboot is required"
+
+
 @app.route('/system/backup/status')
 @authorized_personnel_only
 def backup_status():
diff --git a/management/templates/system-status.html b/management/templates/system-status.html
index 9fe9d08e..efc8ad90 100644
--- a/management/templates/system-status.html
+++ b/management/templates/system-status.html
@@ -1,5 +1,9 @@
 <h2>System Status Checks</h2>
 
+<div id="system-reboot-required" style="display: none">
+  <button type="button" class="btn btn-danger" onclick="confirm_reboot(); return false;">Reboot required</button>
+</div>
+
 <style>
 #system-checks .heading td {
   font-weight: bold;
@@ -34,7 +38,10 @@
   font-family: monospace;
   white-space: pre-wrap;
 }
-
+#system-reboot-required {
+  max-width: 20em;
+  margin-bottom: 1em;
+}
 #system-privacy-setting {
   float: right;
   max-width: 20em;
@@ -47,7 +54,6 @@
 	<p style="line-height: 125%"><small>(When enabled, status checks phone-home to check for a new release of Mail-in-a-Box.)</small></p>
 </div>
 
-
 <table id="system-checks" class="table" style="max-width: 60em">
   <thead>
   </thead>
@@ -70,6 +76,14 @@ function show_system_status() {
       $('#system-privacy-setting p').toggle(r);
     });
 
+  api(
+    "/system/reboot",
+    "GET",
+    { },
+    function(r) {
+      $('#system-reboot-required').toggle(r);
+    });
+
   api(
     "/system/status",
     "POST",
@@ -122,4 +136,20 @@ function enable_privacy(status) {
     });
   return false; // disable link
 }
+
+function confirm_reboot() {
+  show_modal_confirm(
+    "Reboot server",
+    $("<p>This will reboot your server, until the server is fully restarted your users will not be able to send and receive email. The reboot can't be cancelled</p>"),
+    "Reboot now",
+    function() {
+      api(
+        "/system/reboot",
+        "POST",
+        { },
+        function(r) {
+          show_modal_error("Reboot", "Please refresh the page after a minute or so." + r);
+        });
+    });
+}
 </script>

From b71ad85e9fd2e51ceb7dafbea872e0c846eff2dc Mon Sep 17 00:00:00 2001
From: Michael Kroes <michael@kroes.email>
Date: Fri, 26 Feb 2016 09:51:22 +0100
Subject: [PATCH 2/3] Restore an empty line

---
 management/daemon.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/management/daemon.py b/management/daemon.py
index 823bce5e..b416b3ee 100755
--- a/management/daemon.py
+++ b/management/daemon.py
@@ -391,6 +391,7 @@ def ssl_provision_certs():
 def web_get_domains():
 	from web_update import get_web_domains_info
 	return json_response(get_web_domains_info(env))
+
 @app.route('/web/update', methods=['POST'])
 @authorized_personnel_only
 def web_update():

From 67555679bd9fd7a1da29a1f05728720c7843a5ad Mon Sep 17 00:00:00 2001
From: Joshua Tauberer <jt@occams.info>
Date: Wed, 23 Mar 2016 16:37:15 -0400
Subject: [PATCH 3/3] move the reboot button, fix grammar, refactor check for
 DRY, add changelog entry

---
 CHANGELOG.md                            |  2 ++
 management/daemon.py                    | 10 ++++--
 management/status_checks.py             |  5 ++-
 management/templates/system-status.html | 41 ++++++++++++++-----------
 4 files changed, 36 insertions(+), 22 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6f8bdc9d..88b4840e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,8 @@
 CHANGELOG
 =========
 
+* When a reboot is required (due to Ubuntu security updates automatically installed), a Reboot Box button now appears.
+
 v0.17 (February 25, 2016)
 -------------------------
 
diff --git a/management/daemon.py b/management/daemon.py
index b416b3ee..ded40a41 100755
--- a/management/daemon.py
+++ b/management/daemon.py
@@ -456,10 +456,12 @@ def do_updates():
 		"DEBIAN_FRONTEND": "noninteractive"
 	})
 
+
 @app.route('/system/reboot', methods=["GET"])
 @authorized_personnel_only
 def needs_reboot():
-	if os.path.isfile("/var/run/reboot-required"):
+	from status_checks import is_reboot_needed_due_to_package_installation
+	if is_reboot_needed_due_to_package_installation():
 		return json_response(True)
 	else:
 		return json_response(False)
@@ -467,10 +469,12 @@ def needs_reboot():
 @app.route('/system/reboot', methods=["POST"])
 @authorized_personnel_only
 def do_reboot():
-	if os.path.isfile("/var/run/reboot-required"):
+	# To keep the attack surface low, we don't allow a remote reboot if one isn't necessary.
+	from status_checks import is_reboot_needed_due_to_package_installation
+	if is_reboot_needed_due_to_package_installation():
 		return utils.shell("check_output", ["/sbin/shutdown", "-r", "now"], capture_stderr=True)
 	else:
-		return "No reboot is required"
+		return "No reboot is required, so it is not allowed."
 
 
 @app.route('/system/backup/status')
diff --git a/management/status_checks.py b/management/status_checks.py
index 1feea68a..36a87ea1 100755
--- a/management/status_checks.py
+++ b/management/status_checks.py
@@ -185,10 +185,13 @@ def check_ssh_password(env, output):
 	else:
 		output.print_ok("SSH disallows password-based login.")
 
+def is_reboot_needed_due_to_package_installation():
+	return os.path.exists("/var/run/reboot-required")
+
 def check_software_updates(env, output):
 	# Check for any software package updates.
 	pkgs = list_apt_updates(apt_update=False)
-	if os.path.exists("/var/run/reboot-required"):
+	if is_reboot_needed_due_to_package_installation():
 		output.print_error("System updates have been installed and a reboot of the machine is required.")
 	elif len(pkgs) == 0:
 		output.print_ok("System software is up to date.")
diff --git a/management/templates/system-status.html b/management/templates/system-status.html
index efc8ad90..dc9233a5 100644
--- a/management/templates/system-status.html
+++ b/management/templates/system-status.html
@@ -1,9 +1,5 @@
 <h2>System Status Checks</h2>
 
-<div id="system-reboot-required" style="display: none">
-  <button type="button" class="btn btn-danger" onclick="confirm_reboot(); return false;">Reboot required</button>
-</div>
-
 <style>
 #system-checks .heading td {
   font-weight: bold;
@@ -38,22 +34,24 @@
   font-family: monospace;
   white-space: pre-wrap;
 }
-#system-reboot-required {
-  max-width: 20em;
-  margin-bottom: 1em;
-}
-#system-privacy-setting {
-  float: right;
-  max-width: 20em;
-  margin-bottom: 1em;
-}
 </style>
 
+<div class="row">
+	<div class="col-md-push-9 col-md-3">
+
+<div id="system-reboot-required" style="display: none; margin-bottom: 1em;">
+	<button type="button" class="btn btn-danger" onclick="confirm_reboot(); return false;">Reboot Box</button>
+	<div>No reboot is necessary.</div>
+</div>
+
 <div id="system-privacy-setting" style="display: none">
 	<div><a onclick="return enable_privacy(!current_privacy_setting)" href="#"><span>Enable/Disable</span> New-Version Check</a></div>
 	<p style="line-height: 125%"><small>(When enabled, status checks phone-home to check for a new release of Mail-in-a-Box.)</small></p>
 </div>
 
+	</div> <!-- /col -->
+	<div class="col-md-pull-3 col-md-8">
+
 <table id="system-checks" class="table" style="max-width: 60em">
   <thead>
   </thead>
@@ -61,6 +59,9 @@
   </tbody>
 </table>
 
+	</div> <!-- /col -->
+</div> <!-- /row -->
+
 <script>
 function show_system_status() {
   $('#system-checks tbody').html("<tr><td colspan='2' class='text-muted'>Loading...</td></tr>")
@@ -81,7 +82,9 @@ function show_system_status() {
     "GET",
     { },
     function(r) {
-      $('#system-reboot-required').toggle(r);
+      $('#system-reboot-required').show(); // show when r becomes available
+      $('#system-reboot-required').find('button').toggle(r);
+      $('#system-reboot-required').find('div').toggle(!r);
     });
 
   api(
@@ -139,16 +142,18 @@ function enable_privacy(status) {
 
 function confirm_reboot() {
   show_modal_confirm(
-    "Reboot server",
-    $("<p>This will reboot your server, until the server is fully restarted your users will not be able to send and receive email. The reboot can't be cancelled</p>"),
-    "Reboot now",
+    "Reboot",
+    $("<p>This will reboot your Mail-in-a-Box <code>{{hostname}}</code>.</p> <p>Until the machine is fully restarted, your users will not be able to send and receive email, and you will not be able to connect to this control panel or with SSH. The reboot cannot be cancelled.</p>"),
+    "Reboot Now",
     function() {
       api(
         "/system/reboot",
         "POST",
         { },
         function(r) {
-          show_modal_error("Reboot", "Please refresh the page after a minute or so." + r);
+          var msg = "<p>Please reload this page after a minute or so.</p>";
+          if (r) msg = "<p>The reboot command said:</p> <pre>" + $("<pre/>").text(r).html() + "</pre>"; // successful reboots don't produce any output; the output must be HTML-escaped
+          show_modal_error("Reboot", msg);
         });
     });
 }