From 541f31b1bae8087ce21537772c222f74969bf4af Mon Sep 17 00:00:00 2001 From: Teal Dulcet Date: Fri, 22 Dec 2023 07:20:10 -0800 Subject: [PATCH] Fixed FURB113 (repeated-append) --- management/dns_update.py | 3 +-- management/mail_log.py | 8 ++------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/management/dns_update.py b/management/dns_update.py index d28db626..515e2195 100755 --- a/management/dns_update.py +++ b/management/dns_update.py @@ -674,8 +674,7 @@ def hash_dnssec_keys(domain, env): keydata = [] for keytype, keyfn in sorted(find_dnssec_signing_keys(domain, env)): oldkeyfn = os.path.join(env['STORAGE_ROOT'], 'dns/dnssec', keyfn + ".private") - keydata.append(keytype) - keydata.append(keyfn) + keydata.extend((keytype, keyfn)) with open(oldkeyfn) as fr: keydata.append( fr.read() ) keydata = "".join(keydata).encode("utf8") diff --git a/management/mail_log.py b/management/mail_log.py index b8494fbe..bb862395 100755 --- a/management/mail_log.py +++ b/management/mail_log.py @@ -302,8 +302,7 @@ def scan_mail_log(env): for date, sender, message in user_data["blocked"]: if len(sender) > 64: sender = sender[:32] + "…" + sender[-32:] - user_rejects.append("{} - {} ".format(date, sender)) - user_rejects.append(" %s" % message) + user_rejects.extend(('{} - {} '.format(date, sender), ' %s' % message)) rejects.append(user_rejects) print_user_table( @@ -710,10 +709,7 @@ def print_user_table(users, data=None, sub_data=None, activity=None, latest=None if sub_data is not None: for l, d in sub_data: if d[row]: - lines.append("┬") - lines.append("│ %s" % l) - lines.append("├─%s─" % (len(l) * "─")) - lines.append("│") + lines.extend(('┬', '│ %s' % l, '├─%s─' % (len(l) * '─'), '│')) max_len = 0 for v in list(d[row]): lines.append("│ %s" % v)