From 163daea41cdbfe521a5c7f271e4e48edf740bc57 Mon Sep 17 00:00:00 2001
From: Mathis Hoffmann <mathis@hoffpost.de>
Date: Thu, 22 Sep 2016 21:59:10 +0200
Subject: [PATCH] dnspython exception with IPv6 addresses

see #945, merges #947
---
 management/ssl_certificates.py | 11 +++++++++++
 management/status_checks.py    | 16 ++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/management/ssl_certificates.py b/management/ssl_certificates.py
index c49443b9..8de929cd 100755
--- a/management/ssl_certificates.py
+++ b/management/ssl_certificates.py
@@ -238,6 +238,17 @@ def get_certificates_to_provision(env, show_extended_problems=True, force_domain
 			except Exception as e:
 				problems[domain] = "DNS isn't configured properly for this domain: DNS lookup had an error: %s." % str(e)
 				return False
+
+			# Unfortunately, the response.__str__ returns bytes
+			# instead of string, if it resulted from an AAAA-query.
+			# We need to convert manually, until this is fixed:
+			# https://github.com/rthalley/dnspython/issues/204
+			#
+			# BEGIN HOTFIX
+			if isinstance(response[0].to_text(), bytes):
+				 response = [response[0].to_text().decode('utf-8')]
+			# END HOTFIX
+
 			if len(response) != 1 or str(response[0]) != value:
 				problems[domain] = "Domain control validation cannot be performed for this domain because DNS points the domain to another machine (%s %s)." % (rtype, ", ".join(str(r) for r in response))
 				return False
diff --git a/management/status_checks.py b/management/status_checks.py
index 527495c7..4077066a 100755
--- a/management/status_checks.py
+++ b/management/status_checks.py
@@ -680,6 +680,22 @@ def query_dns(qname, rtype, nxdomain='[Not Set]', at=None):
 	# periods from responses since that's how qnames are encoded in DNS but is
 	# confusing for us. The order of the answers doesn't matter, so sort so we
 	# can compare to a well known order.
+
+	# Unfortunately, the response.__str__ returns bytes
+	# instead of string, if it resulted from an AAAA-query.
+	# We need to convert manually, until this is fixed:
+	# https://github.com/rthalley/dnspython/issues/204
+	#
+	# BEGIN HOTFIX
+	response_new = []
+	for r in response:
+	        if isinstance(r.to_text(), bytes):
+	                response_new.append(r.to_text().decode('utf-8'))
+	        else:
+	                response_new.append(r)
+	response = response_new
+	# END HOTFIX
+
 	return "; ".join(sorted(str(r).rstrip('.') for r in response))
 
 def check_ssl_cert(domain, rounded_time, ssl_certificates, env, output):