From 12f0dcb23bd6898e827a55376576efd5cbccab37 Mon Sep 17 00:00:00 2001 From: David Piggott Date: Mon, 16 Feb 2015 14:20:39 +0000 Subject: [PATCH] Do not show '_secondary_nameserver' in Custom DNS table It's redundant and potentially confusing, as any secondary NS shows in "Using a Secondary Nameserver". --- management/dns_update.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/management/dns_update.py b/management/dns_update.py index 331ab764..a68046f9 100755 --- a/management/dns_update.py +++ b/management/dns_update.py @@ -258,6 +258,10 @@ def build_zone(domain, all_domains, additional_records, env, is_zone=True): def get_custom_records(domain, additional_records, env): for qname, value in additional_records.items(): + # We don't count the secondary nameserver config (if present) as a record - that would just be + # confusing to users. Instead it is accessed/manipulated directly via (get/set)_custom_dns_config. + if qname == "_secondary_nameserver": continue + # Is this record for the domain or one of its subdomains? # If `domain` is None, return records for all domains. if domain is not None and qname != domain and not qname.endswith("." + domain): continue