add FileExists and DirExists for checking what is at a path

FileExists reports whether a path holds a regular file and DirExists whether it
holds a directory, both answering false for anything they cannot look at.
Comes with doc comments and table-driven tests. (closes #15)

Model: opus-5

chunk.go

@@ -1,26 +0,0 @@
-package util
-
-// ChunkStrings splits input into consecutive slices of at most size elements.
-// The last slice holds whatever is left over and may be shorter than the
-// others. Each returned slice is a copy, so appending to one of them cannot
-// disturb another. A size below one, or an empty input, returns nil.
-func ChunkStrings(input []string, size int) [][]string {
-	if size < 1 || len(input) == 0 {
-		return nil
-	}
-
-	out := make([][]string, 0, (len(input)+size-1)/size)
-
-	for start := 0; start < len(input); start += size {
-		end := start + size
-		if end > len(input) {
-			end = len(input)
-		}
-
-		chunk := make([]string, end-start)
-		copy(chunk, input[start:end])
-		out = append(out, chunk)
-	}
-
-	return out
-}

chunk_test.go

@@ -1,43 +0,0 @@
-package util
-
-import (
-	"reflect"
-	"testing"
-)
-
-func TestChunkStrings(t *testing.T) {
-	tests := []struct {
-		name     string
-		input    []string
-		size     int
-		expected [][]string
-	}{
-		{"exact multiple", []string{"a", "b", "c", "d"}, 2, [][]string{{"a", "b"}, {"c", "d"}}},
-		{"with a remainder", []string{"a", "b", "c"}, 2, [][]string{{"a", "b"}, {"c"}}},
-		{"size larger than input", []string{"a", "b"}, 5, [][]string{{"a", "b"}}},
-		{"size of one", []string{"a", "b"}, 1, [][]string{{"a"}, {"b"}}},
-		{"size of zero", []string{"a", "b"}, 0, nil},
-		{"negative size", []string{"a", "b"}, -1, nil},
-		{"empty input", []string{}, 2, nil},
-		{"nil input", nil, 2, nil},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			got := ChunkStrings(test.input, test.size)
-			if !reflect.DeepEqual(got, test.expected) {
-				t.Errorf("expected %#v got %#v", test.expected, got)
-			}
-		})
-	}
-}
-
-func TestChunkStringsReturnsCopies(t *testing.T) {
-	input := []string{"a", "b", "c", "d"}
-	chunks := ChunkStrings(input, 2)
-	chunks[0][0] = "changed"
-
-	if input[0] != "a" {
-		t.Errorf("expected the input to be unchanged, got %#v", input)
-	}
-}

exists.go

@@ -0,0 +1,31 @@
+package util
+
+import "os"
+
+// FileExists reports whether there is a regular file at path. A directory, a
+// device node or a socket gives false, and so does anything the process is not
+// allowed to look at, since from the caller's point of view there is no usable
+// file there either way.
+//
+// Symbolic links are followed, so a link pointing at a regular file gives true
+// and a link pointing at nothing gives false.
+func FileExists(path string) bool {
+	info, err := os.Stat(path)
+	if err != nil {
+		return false
+	}
+
+	return info.Mode().IsRegular()
+}
+
+// DirExists reports whether there is a directory at path. As with FileExists,
+// anything that cannot be looked at gives false, and symbolic links are
+// followed.
+func DirExists(path string) bool {
+	info, err := os.Stat(path)
+	if err != nil {
+		return false
+	}
+
+	return info.IsDir()
+}

exists_test.go

@@ -0,0 +1,57 @@
+package util
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+)
+
+func TestFileExistsAndDirExists(t *testing.T) {
+	root := t.TempDir()
+
+	file := filepath.Join(root, "a-file")
+	if err := os.WriteFile(file, []byte("contents"), 0644); err != nil {
+		t.Fatalf("could not write the test file: %v", err)
+	}
+
+	directory := filepath.Join(root, "a-directory")
+	if err := os.Mkdir(directory, 0755); err != nil {
+		t.Fatalf("could not make the test directory: %v", err)
+	}
+
+	linkToFile := filepath.Join(root, "link-to-file")
+	if err := os.Symlink(file, linkToFile); err != nil {
+		t.Fatalf("could not make the test link: %v", err)
+	}
+
+	brokenLink := filepath.Join(root, "broken-link")
+	if err := os.Symlink(filepath.Join(root, "nothing-here"), brokenLink); err != nil {
+		t.Fatalf("could not make the broken test link: %v", err)
+	}
+
+	tests := []struct {
+		name          string
+		path          string
+		expectedFile  bool
+		expectedIsDir bool
+	}{
+		{"a regular file", file, true, false},
+		{"a directory", directory, false, true},
+		{"a link to a file", linkToFile, true, false},
+		{"a link to nothing", brokenLink, false, false},
+		{"a path that is not there", filepath.Join(root, "missing"), false, false},
+		{"a path whose parent is not there", filepath.Join(root, "missing", "deeper"), false, false},
+		{"the empty path", "", false, false},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			if got := FileExists(test.path); got != test.expectedFile {
+				t.Errorf("FileExists: expected %v got %v", test.expectedFile, got)
+			}
+			if got := DirExists(test.path); got != test.expectedIsDir {
+				t.Errorf("DirExists: expected %v got %v", test.expectedIsDir, got)
+			}
+		})
+	}
+}